mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Inki Dae <inki.dae@samsung.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Artur Weber <aweber.kernel@gmail.com>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v2 4/4] drm/mipi-dsi: Drop MIPI_DSI_MODE_VSYNC_FLUSH flag
Date: Mon, 30 Jun 2025 17:39:06 +0200	[thread overview]
Message-ID: <7b564815-c9e0-435c-bd77-63da42aabacb@linaro.org> (raw)
In-Reply-To: <20250627-dsi-vsync-flush-v2-4-4066899a5608@pengutronix.de>

On 27/06/2025 13:45, Philipp Zabel wrote:
> Drop the unused MIPI_DSI_MODE_VSYNC_FLUSH flag. Whether or not a display
> FIFO flush on vsync is required to avoid sending garbage to the panel is
> not a property of the DSI link, but of the integration between display
> controller and DSI host bridge.
> 
> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>   include/drm/drm_mipi_dsi.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index b37860f4a895c25ef8ba1c5b3f44827ef53aa100..369b0d8830c3d14a4fc1e8e38d5fa55f04ca143e 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -130,8 +130,6 @@ struct mipi_dsi_host *of_find_mipi_dsi_host_by_node(struct device_node *node);
>   #define MIPI_DSI_MODE_VIDEO_NO_HBP	BIT(6)
>   /* disable hsync-active area */
>   #define MIPI_DSI_MODE_VIDEO_NO_HSA	BIT(7)
> -/* flush display FIFO on vsync pulse */
> -#define MIPI_DSI_MODE_VSYNC_FLUSH	BIT(8)
>   /* disable EoT packets in HS mode */
>   #define MIPI_DSI_MODE_NO_EOT_PACKET	BIT(9)
>   /* device supports non-continuous clock behavior (DSI spec 5.6.1) */
> 

Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

  reply	other threads:[~2025-06-30 15:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 11:45 [PATCH v2 0/4] drm/bridge: samsung-dsim: Stop controlling vsync display FIFO flush in panels Philipp Zabel
2025-06-27 11:45 ` [PATCH v2 1/4] drm/bridge: samsung-dsim: Always flush display FIFO on vsync pulse Philipp Zabel
2025-06-27 11:45 ` [PATCH v2 2/4] drm/panel: samsung-s6d7aa0: Drop MIPI_DSI_MODE_VSYNC_FLUSH flag Philipp Zabel
2025-06-30 15:38   ` Neil Armstrong
2025-06-27 11:45 ` [PATCH v2 3/4] drm/panel: samsung-s6e8aa0: " Philipp Zabel
2025-06-30 15:38   ` Neil Armstrong
2025-06-27 11:45 ` [PATCH v2 4/4] drm/mipi-dsi: " Philipp Zabel
2025-06-30 15:39   ` Neil Armstrong [this message]
2025-07-01  8:50 ` [PATCH v2 0/4] drm/bridge: samsung-dsim: Stop controlling vsync display FIFO flush in panels Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b564815-c9e0-435c-bd77-63da42aabacb@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=aweber.kernel@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_jesszhan@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®