mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Jingbo Xu <jefflexu@linux.alibaba.com>,
	chao@kernel.org, huyue2@coolpad.com,
	linux-erofs@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: deprecate superblock checksum feature
Date: Fri, 14 Jul 2023 13:58:13 +0800	[thread overview]
Message-ID: <7b585c1b-1541-59ce-2886-0d96875bc362@linux.alibaba.com> (raw)
In-Reply-To: <82251dbb-6fb2-63a5-d15b-ba68ec75b4b2@linux.alibaba.com>



On 2023/7/14 12:50, Jingbo Xu wrote:
> 
> 
> On 7/14/23 12:29 PM, Gao Xiang wrote:
>>
>>
>> On 2023/7/14 11:38, Jingbo Xu wrote:
>>> Later we're going to introduce fs-verity based verification for the
>>> whole image.  Make the superblock checksum feature deprecated.
>>
>> I'd suggest that
>>
>>
>> "Later we're going to try the self-contained image verification.
>>   The current superblock checksum feature has quite limited
>>   functionality, instead, merkle trees can provide better protection
>>   for image integrity.
>>
>>   Since the superblock checksum is a compatible feature, just
>>   deprecate now. "
>>   
> 
> Yeah, another concern is that xxhash is used in the following xattr name
> filter feature [1] which is on the way.  It may be redundant to use two
> hashing algorithms for one filesystem.

Please help add this to the commit message when the next version
is sent.

Thanks,
Gao Xiang

      reply	other threads:[~2023-07-14  5:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14  3:38 Jingbo Xu
2023-07-14  4:29 ` Gao Xiang
2023-07-14  4:50   ` Jingbo Xu
2023-07-14  5:58     ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b585c1b-1541-59ce-2886-0d96875bc362@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=huyue2@coolpad.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®