From: Joey Lu <a0987203069@gmail.com>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v7 1/7] dt-bindings: display: verisilicon,dc: add support for nuvoton,ma35d1-dcu
Date: Mon, 21 Sep 2026 10:47:24 +0800 [thread overview]
Message-ID: <7b5c7095-e086-45de-bdc2-9063e8229222@gmail.com> (raw)
In-Reply-To: <ea18c92ce2af08a65bfd8834ea7f262d1bcb4bf2.camel@iscas.ac.cn>
Icenowy Zheng 於 2026/9/18 下午 06:50 寫道:
> 在 2026-09-18五的 11:01 +0800,Joey Lu写道:
>> Add the Nuvoton MA35D1 DCUltraLite (nuvoton,ma35d1-dcu) to the
>> binding.
>> The DCUltraLite uses only four clocks (core, axi, ahb, pix0) and one
>> reset (core), with a single output port.
>>
>> The MA35D1 clock controller gates the core, AXI and AHB clocks with a
>> single bit, but each remains a distinct clock line feeding the IP
>> with
>> its own rate constraints, so all four must still be listed
>> individually
>> in the devicetree; core, axi and ahb happen to share the same clock
>> phandle.
>>
>> Move the clocks/clock-names minItems to 4 and resets/reset-names
>> minItems to 1 at the top level, since that is the lowest count any
>> supported variant needs. Add an allOf/if block that tightens the
>> constraint back up to the fixed 5-clock/3-reset topology required by
>> the existing thead,th1520-dc8200 compatible, and another one that
>> caps
>> the new nuvoton,ma35d1-dcu compatible at the 4-clock/1-reset count it
>> actually wires up.
>>
>> Restrict the same nuvoton,ma35d1-dcu if block to a single port@0,
>> since the DCUltraLite only has one output port.
> By the way, when will the MA35D1 device tree sources be updated? I saw
> a lot of drivers being merged but w/o corresponding DT nodes: sdhci-of-
> ma35d1, nuvoton-ma35d1-nand-controller, phy-ma35d1-usb2, rtc-ma35d1,
> spi-ma35d1-qspi, ma35d1_wdt.
>
> Thanks,
> Icenowy
We are currently reviewing several peripheral device tree updates,
including USB/PHY, CAN, and other related blocks.
Once the core driver support is in place, we plan to do a more thorough
review and update of the MA35D1 device tree
sources to ensure the corresponding DT nodes are properly added and
aligned with the upstream drivers.
Thanks for your patience and feedback.
>> Signed-off-by: Joey Lu <a0987203069@gmail.com>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> .../bindings/display/verisilicon,dc.yaml | 51
>> +++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
>> b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
>> index 919a900122012..e1e6a3a953646 100644
>> --- a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
>> +++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
>> @@ -17,6 +17,7 @@ properties:
>> items:
>> - enum:
>> - thead,th1520-dc8200
>> + - nuvoton,ma35d1-dcu
>> - const: verisilicon,dc # DC IPs have discoverable ID/revision
>> registers
>>
>> reg:
>> @@ -26,6 +27,7 @@ properties:
>> maxItems: 1
>>
>> clocks:
>> + minItems: 4
>> items:
>> - description: DC Core clock
>> - description: DMA AXI bus clock
>> @@ -34,6 +36,7 @@ properties:
>> - description: Pixel clock of output 1
>>
>> clock-names:
>> + minItems: 4
>> items:
>> - const: core
>> - const: axi
>> @@ -42,12 +45,14 @@ properties:
>> - const: pix1
>>
>> resets:
>> + minItems: 1
>> items:
>> - description: DC Core reset
>> - description: DMA AXI bus reset
>> - description: Configuration AHB bus reset
>>
>> reset-names:
>> + minItems: 1
>> items:
>> - const: core
>> - const: axi
>> @@ -79,6 +84,52 @@ required:
>> - reset-names
>> - ports
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: thead,th1520-dc8200
>> + then:
>> + properties:
>> + clocks:
>> + minItems: 5
>> +
>> + clock-names:
>> + minItems: 5
>> +
>> + resets:
>> + minItems: 3
>> +
>> + reset-names:
>> + minItems: 3
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: nuvoton,ma35d1-dcu
>> + then:
>> + properties:
>> + clocks:
>> + maxItems: 4
>> +
>> + clock-names:
>> + maxItems: 4
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + reset-names:
>> + maxItems: 1
>> +
>> + ports:
>> + properties:
>> + port@1: false
>> +
>> + required:
>> + - port@0
>> +
>> additionalProperties: false
>>
>> examples:
next prev parent reply other threads:[~2026-09-21 2:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 3:01 [PATCH v7 0/7] drm/verisilicon: add Nuvoton MA35D1 DCU Lite support Joey Lu
2026-09-18 3:01 ` [PATCH v7 1/7] dt-bindings: display: verisilicon,dc: add support for nuvoton,ma35d1-dcu Joey Lu
2026-09-18 5:57 ` Icenowy Zheng
2026-09-18 10:50 ` Icenowy Zheng
2026-09-21 2:47 ` Joey Lu [this message]
2026-09-18 3:01 ` [PATCH v7 2/7] drm/verisilicon: add register-level macros for DC8000 Joey Lu
2026-09-18 3:01 ` [PATCH v7 3/7] drm/verisilicon: introduce per-variant hardware ops table Joey Lu
2026-09-18 3:01 ` [PATCH v7 4/7] drm/verisilicon: add DC8000 (DCUltraLite) display controller support Joey Lu
2026-09-18 3:01 ` [PATCH v7 5/7] drm/verisilicon: add DCUltraLite chip identity to HWDB Joey Lu
2026-09-18 3:01 ` [PATCH v7 6/7] drm/verisilicon: extend Kconfig to support ARCH_MA35 platforms Joey Lu
2026-09-18 3:01 ` [PATCH v7 7/7] drm/verisilicon: fix DC8200 primary plane disable clearing FB_EN Joey Lu
2026-09-18 5:52 ` Icenowy Zheng
2026-09-21 2:43 ` Joey Lu
2026-09-21 4:18 ` Icenowy Zheng
2026-09-21 7:30 ` Icenowy Zheng
2026-09-21 7:49 ` Joey Lu
2026-09-21 8:48 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b5c7095-e086-45de-bdc2-9063e8229222@gmail.com \
--to=a0987203069@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®