From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753183AbcIIJmZ (ORCPT ); Fri, 9 Sep 2016 05:42:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50420 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbcIIJmY (ORCPT ); Fri, 9 Sep 2016 05:42:24 -0400 Subject: Re: [PATCH] phy-sun4i-usb: select 'USB_COMMON' To: Arnd Bergmann , Kishon Vijay Abraham I References: <20160906125516.1551565-1-arnd@arndb.de> <20915b65-8be3-cee4-cac1-eab512ab74f5@redhat.com> <57D1699C.4080406@ti.com> <2629582.eurAq3q4Wx@wuerfel> Cc: linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: <7b5d0f3d-3a1e-3e35-42f3-2766333dc282@redhat.com> Date: Fri, 9 Sep 2016 11:42:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2629582.eurAq3q4Wx@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 09 Sep 2016 09:42:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 09-09-16 11:25, Arnd Bergmann wrote: > In commit "usb: phy: add USB_SUPPORT dependency", I tried to > fix the dependency for this driver, but unfortunately I missed > that we need both USB_COMMON and USB_SUPPORT here, and we > can still get the same link error in the much rarer case > that USB_COMMON is a loadable module and the phy driver is > build-in: > > drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe': > phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x1a6): undefined reference to `of_usb_get_dr_mode_by_phy' > > This adds the select, hopefully fixing it properly this time. > > Signed-off-by: Arnd Bergmann Thanks for catching this: Reviewed-by: Hans de Goede > --- > I see the original patch hasn't made it into linux-next > yet, so ideally just fold this patch into the first one. The original patch is in 4.8-rc# (it got there after rc1). Regards, Hans > > Sorry for not getting it right the first time around. > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 985dff8558e5..c717f306d131 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -262,6 +262,7 @@ config PHY_SUN4I_USB > depends on POWER_SUPPLY > depends on USB_SUPPORT > select GENERIC_PHY > + select USB_COMMON > help > Enable this to support the transceiver that is part of Allwinner > sunxi SoCs. >