From: taozj888 <taozj888@163.com>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: stable@vger.kernel.org,
"Conor Dooley" <conor.dooley@microchip.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jeff Garzik" <jeff@garzik.org>,
"Haavard Skinnemoen" <hskinnemoen@atmel.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re:Re: [PATCH net v4] net: macb: rate limit netdev error info print in the data path
Date: Wed, 14 Oct 2026 16:47:55 +0800 (CST) [thread overview]
Message-ID: <7b5db407.7d53.1a13998c295.Coremail.taozj888@163.com> (raw)
In-Reply-To: <DLZH4LPJ36YW.1CP7RL0J77DHN@bootlin.com>
Hi Theo:
Sorry for having missed important things.
I would like to append some explanations here.
Please see my answer inline.
Thanks,
Zijin Tao
At 2026-10-14 01:55:03, "Théo Lebrun" <theo.lebrun@bootlin.com> wrote:
>Hello Zijin,
>
> - I'll stop replying inline because you seem to be having issues with
> your mailer. Please fix it to ease the discussion.
>
> See here how your email looks:
> https://lore.kernel.org/netdev/63731290.3f0c.1a1198fe993.Coremail.taozj888@163.com/
>
> - Your V4 commit message says "Fixes: 89e5785fc8a6" but that is wrong
> with the current patch, it shold use 4df95131ea80. I don't
> understand why you are talking about the changelog at the same time,
> this is unrelated.
>
Yes, I made a mistake in V4 commit message with an oversight, it should use 4df95131ea80, so
I just revised it to 4df95131ea80 in the V5 patch, and I will use it in possible later patches.
> - You skipped over explaining why your dropped the start_xmit diff.
>
>I'll have to stop reviewing if you skip over parts of the messages.
>I gave you a TLDR and you skipped over the first bulletpoint.
>
Sorry, I forgot to make an explanation here, maybe due to an omission.
Now I would like to amend it:
Actually when I started to rate limit the error messages in the data path, I saw
the netdev_err message print in both the gem_rx_refill and at91ether_start_xmit,
and I knew they are also in the data path.
But for the following reasons I just omitted adding rate limits for them:
1. For the netdev_err in the gem_rx_refill, there is a "unlikely(!skb)" to check if
the skb is NULL which is a rare case, so I think it's not so needed to add a
rate limit here;
2. For the netdev_err in the at91ether_start_xmit, I think it belongs to another vendor
which I am not familiar with, and I didn't know how popular it was used, even I was not authorized to
change it with my will also.
If you think it's better or needed to add a rate limit for them, I would like to do it in later possible
patches.
Would you please give your opinion here?
>Thanks,
>
>--
>Théo Lebrun, Bootlin
>Embedded Linux and Kernel engineering
>https://bootlin.com
>
>text:
>Mime-Version: 1.0
>Content-Transfer-Encoding: quoted-printable
>Content-Type: text/plain; charset=UTF-8
>Date: Thu, 08 Oct 2026 14:59:55 +0200
>Message-Id: <DLZH4LPJ36YW.1CP7RL0J77DHN@bootlin.com>
>Subject: Re: [PATCH net v4] net: macb: rate limit netdev error info print in
> the data path
>Cc: <stable@vger.kernel.org>, "Conor Dooley" <conor.dooley@microchip.com>,
> "Andrew Lunn" <andrew+netdev@lunn.ch>, "David S. Miller"
> <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub
> Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Jeff
> Garzik" <jeff@garzik.org>, "Haavard Skinnemoen" <hskinnemoen@atmel.com>,
> "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>, "open list"
> <linux-kernel@vger.kernel.org>
>To: "taozj888" <taozj888@163.com>
>From: =?utf-8?q?Théo_Lebrun?= <theo.lebrun@bootlin.com>
>X-Mailer: aerc 0.22.0-0-gc2f86b7abde3
>References: <20261007053211.572073-1-taozj888@163.com>
> <DLYI3O7PFN94.V7VH3HSLKEMD@bootlin.com>
> <63731290.3f0c.1a1198fe993.Coremail.taozj888@163.com>
>In-Reply-To: <63731290.3f0c.1a1198fe993.Coremail.taozj888@163.com>
>X-TUID: tHkCkOndXaQQ
>
>Hello Zijin,
>
> - I'll stop replying inline because you seem to be having issues with
> your mailer. Please fix it to ease the discussion.
>
> See here how your email looks:
> https://lore.kernel.org/netdev/63731290.3f0c.1a1198fe993.Coremail.taozj888@163.com/
>
> - Your V4 commit message says "Fixes: 89e5785fc8a6" but that is wrong
> with the current patch, it shold use 4df95131ea80. I don't
> understand why you are talking about the changelog at the same time,
> this is unrelated.
>
> - You skipped over explaining why your dropped the start_xmit diff.
>
>I'll have to stop reviewing if you skip over parts of the messages.
>I gave you a TLDR and you skipped over the first bulletpoint.
>
>Thanks,
>
>--
>Théo Lebrun, Bootlin
>Embedded Linux and Kernel engineering
>https://bootlin.com
next prev parent reply other threads:[~2026-10-14 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 5:32 taozj888
2026-10-07 9:33 ` Théo Lebrun
2026-10-08 3:30 ` taozj888
2026-10-08 12:59 ` Théo Lebrun
2026-10-14 8:47 ` taozj888 [this message]
2026-10-27 7:23 ` reply to Theo's questions Zijin Tao
2026-10-11 5:46 ` [PATCH net v4] net: macb: rate limit netdev error info print in the data path netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b5db407.7d53.1a13998c295.Coremail.taozj888@163.com \
--to=taozj888@163.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hskinnemoen@atmel.com \
--cc=jeff@garzik.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®