From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: <agk@redhat.com>, <snitzer@redhat.com>, <dm-devel@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: linfeilong <linfeilong@huawei.com>,
Mingfangsen <mingfangsen@huawei.com>,
"wubo (T)" <wubo40@huawei.com>,
Yanxiaodan <yanxiaodan@huawei.com>
Subject: Re: [PATCH] md/persistent-data: exit_ro_spine func return void
Date: Tue, 21 Apr 2020 09:11:22 +0800 [thread overview]
Message-ID: <7b6493a0-685f-5f39-b948-a27716d48cc5@huawei.com> (raw)
In-Reply-To: <a7643d1a-940b-c8a8-686e-a660f0feeb96@huawei.com>
Friendly ping..
On 2020/4/15 19:57, Zhiqiang Liu wrote:
> From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> In commit 4c7da06f5a78 ("dm persistent data: eliminate unnecessary return values"),
> r value in exit_ro_spine will not changes, so exit_ro_spine donot need
> to return values.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
> drivers/md/persistent-data/dm-btree-internal.h | 2 +-
> drivers/md/persistent-data/dm-btree-spine.c | 6 ++----
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/md/persistent-data/dm-btree-internal.h b/drivers/md/persistent-data/dm-btree-internal.h
> index a240990a7f33..55a4096f1334 100644
> --- a/drivers/md/persistent-data/dm-btree-internal.h
> +++ b/drivers/md/persistent-data/dm-btree-internal.h
> @@ -68,7 +68,7 @@ struct ro_spine {
> };
>
> void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info);
> -int exit_ro_spine(struct ro_spine *s);
> +void exit_ro_spine(struct ro_spine *s);
> int ro_step(struct ro_spine *s, dm_block_t new_child);
> void ro_pop(struct ro_spine *s);
> struct btree_node *ro_node(struct ro_spine *s);
> diff --git a/drivers/md/persistent-data/dm-btree-spine.c b/drivers/md/persistent-data/dm-btree-spine.c
> index b27b8091a1ca..e03cb9e48773 100644
> --- a/drivers/md/persistent-data/dm-btree-spine.c
> +++ b/drivers/md/persistent-data/dm-btree-spine.c
> @@ -132,15 +132,13 @@ void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info)
> s->nodes[1] = NULL;
> }
>
> -int exit_ro_spine(struct ro_spine *s)
> +void exit_ro_spine(struct ro_spine *s)
> {
> - int r = 0, i;
> + int i;
>
> for (i = 0; i < s->count; i++) {
> unlock_block(s->info, s->nodes[i]);
> }
> -
> - return r;
> }
>
> int ro_step(struct ro_spine *s, dm_block_t new_child)
>
prev parent reply other threads:[~2020-04-21 1:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 11:57 Zhiqiang Liu
2020-04-21 1:11 ` Zhiqiang Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b6493a0-685f-5f39-b948-a27716d48cc5@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=snitzer@redhat.com \
--cc=wubo40@huawei.com \
--cc=yanxiaodan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®