From: Xiaotian Feng <xtfeng@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
James.Bottomley@suse.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Scsi <linux-scsi@vger.kernel.org>
Subject: Re: qlogic lockdep warning
Date: Thu, 21 Jan 2010 17:14:14 +0800 [thread overview]
Message-ID: <7b6bb4a51001210114g1b2ec290g3fdf098a651b6b38@mail.gmail.com> (raw)
In-Reply-To: <1264064527.4283.1139.camel@laptop>
On Thu, Jan 21, 2010 at 5:02 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, 2010-01-21 at 16:46 +0800, Xiaotian Feng wrote:
>> qla24xx_msix_default is using spin_lock_irq and spin_unlock_irq within
>> the irq handler...
>> I think convert to spin_lock_irqsave/spin_unlock_irqrestore can solve
>> this warning.
>
> Not only that it'll actually solve a bug too ;-)
>
> Also,
>
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
Ah, just realized it by your examples :-) Sorry for the bad manner in e-mail...
>
>
next prev parent reply other threads:[~2010-01-21 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 1:10 Yinghai Lu
2010-01-21 8:22 ` Peter Zijlstra
2010-01-21 8:46 ` Xiaotian Feng
2010-01-21 9:02 ` Peter Zijlstra
2010-01-21 9:14 ` Xiaotian Feng [this message]
2010-01-21 20:38 ` Giridhar Malavali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b6bb4a51001210114g1b2ec290g3fdf098a651b6b38@mail.gmail.com \
--to=xtfeng@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=James.Bottomley@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®