From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752033Ab0AVFPw (ORCPT ); Fri, 22 Jan 2010 00:15:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751325Ab0AVFPw (ORCPT ); Fri, 22 Jan 2010 00:15:52 -0500 Received: from mail-px0-f182.google.com ([209.85.216.182]:59619 "EHLO mail-px0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778Ab0AVFPu convert rfc822-to-8bit (ORCPT ); Fri, 22 Jan 2010 00:15:50 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=aXe+INnT0hA3tt76XqFC9SM0U1abVYPFeKX8rQrgdmq/VHvM//aTJxMGIpON+XUxZs EpdVE691N33Dsb0uePoogzjReFzby56JoEU3AJIW8gmUevKm6HfCRdsAwDcHa4MxdI7C 8Vk0UPzP3JA7Qeynpy19RXxshcp+6hNze+Amw= MIME-Version: 1.0 In-Reply-To: <20100122033004.193166010@intel.com> References: <20100122032102.137106635@intel.com> <20100122033004.193166010@intel.com> Date: Fri, 22 Jan 2010 13:15:50 +0800 Message-ID: <7b6bb4a51001212115j741e91c4p61f3f1d6e2ec1de4@mail.gmail.com> Subject: Re: [PATCH 1/3] resources: introduce generic page_is_ram() From: Xiaotian Feng To: Wu Fengguang Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton , Chen Liqin , Lennox Wu , Ralf Baechle , =?UTF-8?Q?Am=C3=A9rico_Wang?= , linux-mips@linux-mips.org, KAMEZAWA Hiroyuki , Yinghai Lu , x86@kernel.org, LKML , Andi Kleen , shaohui.zheng@intel.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2010 at 11:21 AM, Wu Fengguang wrote: > It's based on walk_system_ram_range(), for archs that don't have > their own page_is_ram(). > > The static verions in MIPS and SCORE are also made global. > > CC: Chen Liqin > CC: Lennox Wu > CC: Ralf Baechle > CC: Américo Wang > CC: linux-mips@linux-mips.org > CC: KAMEZAWA Hiroyuki > CC: Yinghai Lu > Signed-off-by: Wu Fengguang > --- >  arch/mips/mm/init.c    |    2 +- >  arch/score/mm/init.c   |    2 +- >  include/linux/ioport.h |    2 ++ >  kernel/resource.c      |   11 +++++++++++ >  4 files changed, 15 insertions(+), 2 deletions(-) > > --- linux-mm.orig/kernel/resource.c     2010-01-22 11:20:34.000000000 +0800 > +++ linux-mm/kernel/resource.c  2010-01-22 11:20:35.000000000 +0800 > @@ -327,6 +327,17 @@ int walk_system_ram_range(unsigned long > >  #endif > > +#define PAGE_IS_RAM    24 > +static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg) > +{ > +       return PAGE_IS_RAM; > +} > +int __attribute__((weak)) page_is_ram(unsigned long pfn) > +{ > +       return PAGE_IS_RAM == walk_system_ram_range(pfn, 1, NULL, __is_ram); > +} > +#undef PAGE_IS_RAM > + I'm not sure, but any build test for powerpc/mips/score? walk_system_ram_range is defined when CONFIG_ARCH_HAS_WALK_MEMORY is not set. Is it safe when CONFIG_ARCH_HAS_WALK_MEMORY is set for some powerpc archs? >  /* >  * Find empty slot in the resource tree given range and alignment. >  */ > --- linux-mm.orig/include/linux/ioport.h        2010-01-22 11:20:34.000000000 +0800 > +++ linux-mm/include/linux/ioport.h     2010-01-22 11:20:35.000000000 +0800 > @@ -191,5 +191,7 @@ extern int >  walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages, >                void *arg, int (*func)(unsigned long, unsigned long, void *)); > > +extern int page_is_ram(unsigned long pfn); > + >  #endif /* __ASSEMBLY__ */ >  #endif /* _LINUX_IOPORT_H */ > --- linux-mm.orig/arch/score/mm/init.c  2010-01-22 11:20:34.000000000 +0800 > +++ linux-mm/arch/score/mm/init.c       2010-01-22 11:20:35.000000000 +0800 > @@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi >  } > >  #ifndef CONFIG_NEED_MULTIPLE_NODES > -static int __init page_is_ram(unsigned long pagenr) > +int page_is_ram(unsigned long pagenr) >  { >        if (pagenr >= min_low_pfn && pagenr < max_low_pfn) >                return 1; > --- linux-mm.orig/arch/mips/mm/init.c   2010-01-22 11:20:34.000000000 +0800 > +++ linux-mm/arch/mips/mm/init.c        2010-01-22 11:20:35.000000000 +0800 > @@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long >  } > >  #ifndef CONFIG_NEED_MULTIPLE_NODES > -static int __init page_is_ram(unsigned long pagenr) > +int page_is_ram(unsigned long pagenr) >  { >        int i; > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Please read the FAQ at  http://www.tux.org/lkml/ >