From: Xiaotian Feng <xtfeng@gmail.com>
To: Nick Bowler <nbowler@elliptictech.com>
Cc: linux-kernel@vger.kernel.org, Jiri Pirko <jpirko@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Regression, bisected] tcpdump broken in 2.6.34-rc1
Date: Wed, 10 Mar 2010 14:36:21 +0800 [thread overview]
Message-ID: <7b6bb4a51003092236k4f5baa1tbb6dcf0b81038310@mail.gmail.com> (raw)
In-Reply-To: <20100310023143.GA20402@cpu18.student.cs>
On Wed, Mar 10, 2010 at 10:31 AM, Nick Bowler <nbowler@elliptictech.com> wrote:
> After upgrading to 2.6.34-rc1, tcpdump fails with the following message:
>
> tcpdump: setsockopt: Invalid argument
>
> The issue is reproducable on two very different machines: one using
> iwlagn and the other using et131x. Bisection reveals the following and
> reverting the implicated commit resolves the issue.
>
> 914c8ad2d18b62ad1420f518c0cab0b0b90ab308 is the first bad commit
> commit 914c8ad2d18b62ad1420f518c0cab0b0b90ab308
> Author: Jiri Pirko <jpirko@redhat.com>
> Date: Wed Feb 24 23:57:04 2010 +0000
>
I think this regression has been fixed in today's net pull request.
http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=1162563f82b434e3099c9e6c1bbdba846d792f0d
> af_packet: do not accept mc address smaller then dev->addr_len in packet_mc_add()
>
> There is no point of accepting an address of smaller length than dev->addr_len
> here. Therefore change this for stonger check.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> :040000 040000 e76af2835c200aea1f3b1268f5e2e7c930ece887 87d5869972605cc130372168f450ee0def0b169b M net
>
> git bisect start
> # bad: [57d54889cd00db2752994b389ba714138652e60c] Linux 2.6.34-rc1
> git bisect bad 57d54889cd00db2752994b389ba714138652e60c
> # good: [baac35c4155a8aa826c70acee6553368ca5243a2] security: fix error return path in ima_inode_alloc
> git bisect good baac35c4155a8aa826c70acee6553368ca5243a2
> # bad: [47871889c601d8199c51a4086f77eebd77c29b0b] Merge branch 'master' of /home/davem/src/GIT/linux-2.6/
> git bisect bad 47871889c601d8199c51a4086f77eebd77c29b0b
> # good: [e0d272429a34ff143bfa04ee8e29dd4eed2964c7] Merge branch 'tracing-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
> git bisect good e0d272429a34ff143bfa04ee8e29dd4eed2964c7
> # good: [b3b3f04fb587ecb61b5baa6c1c5f0e666fd12d73] tg3: Update driver version to 3.107
> git bisect good b3b3f04fb587ecb61b5baa6c1c5f0e666fd12d73
> # good: [19bc291c99f018bd4f2c38bbf69144086dca903f] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6
> git bisect good 19bc291c99f018bd4f2c38bbf69144086dca903f
> # good: [f66ffdedbf0fc059a92219bb08c1dbcac88f074b] Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
> git bisect good f66ffdedbf0fc059a92219bb08c1dbcac88f074b
> # bad: [46976c042ba1ff59253f2f7a513099175c24794e] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-next-2.6
> git bisect bad 46976c042ba1ff59253f2f7a513099175c24794e
> # bad: [b914a250e7b390c713b36a9405a39c4c11abad80] Bluetooth: Convert Marvell driver to use per adapter debugfs
> git bisect bad b914a250e7b390c713b36a9405a39c4c11abad80
> # good: [a4dde3abbf87a495154a876576e1ab34b17b5ef1] cnic: Use union for the status blocks of different devices.
> git bisect good a4dde3abbf87a495154a876576e1ab34b17b5ef1
> # bad: [738b0343e73604750feb107e063c28b3ca36cb84] Revert "ethtool: Add n-tuple string length to drvinfo and return it"
> git bisect bad 738b0343e73604750feb107e063c28b3ca36cb84
> # bad: [e5e26d75f490d7d41f25a4b39ed6db1713beb417] netdev: use list_first_entry macro
> git bisect bad e5e26d75f490d7d41f25a4b39ed6db1713beb417
> # good: [2a3f279034b46204b50408aa2c25ee0882120147] myri10ge: optimize 4k-boundary check when stocking rx pages
> git bisect good 2a3f279034b46204b50408aa2c25ee0882120147
> # bad: [4edb246626be6e031950205c885bdf29fb2ff1eb] rtnetlink: clean up SR-IOV config interface
> git bisect bad 4edb246626be6e031950205c885bdf29fb2ff1eb
> # bad: [914c8ad2d18b62ad1420f518c0cab0b0b90ab308] af_packet: do not accept mc address smaller then dev->addr_len in packet_mc_add()
> git bisect bad 914c8ad2d18b62ad1420f518c0cab0b0b90ab308
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2010-03-10 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 2:31 Nick Bowler
2010-03-10 6:36 ` Xiaotian Feng [this message]
2010-03-10 14:15 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b6bb4a51003092236k4f5baa1tbb6dcf0b81038310@mail.gmail.com \
--to=xtfeng@gmail.com \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®