From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guangshuo Li <lgs201920130244@gmail.com>,
Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>,
Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov2735: fix power cleanup on remove
Date: Tue, 15 Sep 2026 13:06:27 +0200 [thread overview]
Message-ID: <7b6dd295-602c-488c-a3c0-b0fefc5c2cd2@kernel.org> (raw)
In-Reply-To: <20260915085031.2331315-1-lgs201920130244@gmail.com>
On 15/09/2026 10:50, Guangshuo Li wrote:
> ov2735_probe() explicitly powers on the sensor before enabling runtime
> PM. The probe failure paths call ov2735_power_off(), but the remove path
> does not perform the corresponding power-off operation.
>
> The managed runtime PM helpers only clean up the runtime PM state.
> devm_pm_runtime_set_active_enabled() disables runtime PM and restores
> the suspended state during device resource release, while
> devm_pm_runtime_get_noresume() drops the runtime PM usage reference.
> Neither helper invokes ov2735_power_off().
AGAIN, you send patch by one, instead of grouping them in a patchset.
I already asked you to stop this and fix your workflow.
Please read submitting patches document.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-15 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 8:50 Guangshuo Li
2026-09-15 11:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b6dd295-602c-488c-a3c0-b0fefc5c2cd2@kernel.org \
--to=krzk@kernel.org \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=himanshu.bhavani@siliconsignals.io \
--cc=hverkuil+cisco@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®