From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32197C433EF for ; Tue, 23 Nov 2021 18:00:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239605AbhKWSDK (ORCPT ); Tue, 23 Nov 2021 13:03:10 -0500 Received: from smtprelay0111.hostedemail.com ([216.40.44.111]:36764 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233945AbhKWSDJ (ORCPT ); Tue, 23 Nov 2021 13:03:09 -0500 Received: from omf13.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id EDEAD18473E35; Tue, 23 Nov 2021 18:00:00 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA id 68803200051E; Tue, 23 Nov 2021 17:59:58 +0000 (UTC) Message-ID: <7b6e9af20d5e18315986c8e004a13c3840afb9ad.camel@perches.com> Subject: Re: arch/mips/mm/tlbex.c:2243:3: warning: unannotated fall-through between switch labels From: Joe Perches To: "Gustavo A. R. Silva" Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Kees Cook , Nathan Chancellor Date: Tue, 23 Nov 2021 09:59:58 -0800 In-Reply-To: <20211123175610.GA8713@embeddedor> References: <202111230719.OZDUHU4z-lkp@intel.com> <20211123005528.GA550759@embeddedor> <20211123165057.GA7382@embeddedor> <20211123175610.GA8713@embeddedor> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 68803200051E X-Stat-Signature: 5abhep5mpfpktxggxmmiw73fyko5caxd X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/3DYbCkrweiDXwhQT+VPuLXXf9uS+UqMU= X-HE-Tag: 1637690398-387024 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-11-23 at 11:56 -0600, Gustavo A. R. Silva wrote: > On Tue, Nov 23, 2021 at 09:25:17AM -0800, Joe Perches wrote: > > On Tue, 2021-11-23 at 10:50 -0600, Gustavo A. R. Silva wrote: > > > On Tue, Nov 23, 2021 at 12:52:30AM -0800, Joe Perches wrote: > > > > > > > > Perhaps this would be better: > > > > > > Feel free to send a proper patch. > > > > I commented on your proposed patch. > > And I reply giving you an option if you want to proceed. > > > And I'd prefer you actually look at and improve the code instead > > of merely silencing warnings. > > If this is a matter of preference then I should express my preferences, too. > So, I prefer to give you the opportunity of improving the code and not being > pedantic at the same time. :) It appears to be difficult to give you suggestions on how to improve what you do. cheers, Joe