From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A87730E83A for ; Tue, 21 Jul 2026 11:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784631914; cv=none; b=rsQhTyIRalmDsnr1mW3gEWKMOCJ0m1F761eg9S8MLiL4e5bcf9X1sweeXpS3np8PYdaPypCnx/feBUrpupUPJqZUOhqVCFFdqAiC2lDWdiZs5l2EnnT6r4BiZpgfhX+/uFUDNJwVE0B7Jk6XnO+ZEU9D6pz9C1OGgval/G6OPuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784631914; c=relaxed/simple; bh=5vLtRZl0KY1lopmT7Vey9A6ugpTj+4/jRYXPaak9q5M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LiAUoS0KpPXWMUW4cWSQl0cZcFTePrasCSsJqtntM86s6tQjNAbXUequAyby3r0o7pLCR8py9BJ32bjdna1DbwsR+RlOvrQ/gBU/gbW/E2TU52/1X3qClFbolHiHbhcR2KfVNG7r9uf+xAyL4dSkx2qVCoCFRGETjORSpXaDyzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fL3Rroxs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OYB+j2Mb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fL3Rroxs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OYB+j2Mb" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LAQqUZ1611726 for ; Tue, 21 Jul 2026 11:05:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PUXrHGT89/HXVVPekH8oE4K2uUkHmOQY+kGVM52cxQY=; b=fL3RroxsPpMOxRp5 Mf3wh4o4it64oq9GJGIBZl4beI/tFzYST3GhOpERDbdWWFlBoGKHK/0lzZAbOtwf SfRtwsG4cXrjV+ua7FNKIiKZTwmoYBsIuAx5GueE88h60KA5JZ4xChfjjdjr0KOJ sMBCt++MTLbY71sWAn1SzFrofEnAybd9Wh7aNCeSDquf6q/QZne8L0imiGrD4Kng BnFGQIflMndbWKcon3tezbjKbE2iEHugWl+GYPFnjcvM5byuQsyUc3bKfw21ZGa0 pagzNLrYkipc2CzUatAcrOjKpGY2E+LfYMUyRSWPmoTILB4XY15WZYPqXFllFokx eT8iZQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj6r3g7fx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 11:05:12 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb7049fa552so1898069a12.2 for ; Tue, 21 Jul 2026 04:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784631912; x=1785236712; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PUXrHGT89/HXVVPekH8oE4K2uUkHmOQY+kGVM52cxQY=; b=OYB+j2MbPyflXAHpZq5zc+D9G0VWAQOnZoDYsv0a8rwmW0DnV305CiJrTVsK+9V18b H5SufvIE8olniYw/a87Lb6/Ff7jACf+jgvxtyG3Pp3PrWdn4eO3fM077Dgs0oU3VtpNH lDKcBUzhE6hHneqSmELqrEIsNwqYVl1zJaitPFlbbspo0mFMjRduznG9zlrTKsnxaoNI HbmqZc1kTz9zaLljTsPjwSMVz5LlmdrxfqUyXYuxEcYCa7rizx/zXyrOBvkAYXoiVZm/ khsfrRsBlGF0B/LhQRk6C3SDAJFVEtFG+iLgOKtwJPP8F55+vHrjjjxEcEO0uJFG4izZ tgxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784631912; x=1785236712; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PUXrHGT89/HXVVPekH8oE4K2uUkHmOQY+kGVM52cxQY=; b=KAC033TzIy3jM9FlWO66w6Chicc4jOAlLqUN4ibLeHLhzTJwVg/22yz/AzzPtwc/0M clXeFnCuywsmQTnPKbzrwWD9VjHXSJpgi3P4nLLZUWAKFc/vFlkxOT0g6mRv2YDqFque xjx0zc41dSKxX8nK7kkcmlOLdENEcmWRRUUl5K7M+8avRAPXQkOTALo0pfi01qoZ7wHS yYyslKn1MVd8yIHNU7fvvwzhn/R+RtCFqf3OojFcmabTyzqoQWUzjXe/20RjwmHc8/ko uKtUGo0516r7KayP6dvZuKc6eJ837G+WXVx4qRCwFQGHWSi9iVNYNh4YjRp8YTWonlHb r4kQ== X-Forwarded-Encrypted: i=1; AHgh+RqR6ix2EFrdA0u+ah8utH0PNGqTYe77hAC3AFgJUenG72zf2QCpV1l4/SxOv3DJ9C1VVv1Me94W44oaivo=@vger.kernel.org X-Gm-Message-State: AOJu0YzkLbPG3CMAp777rMBAQJD/4DD9rB6OXaT3EoqLgfsxCCE2JxBx gkRM5GxkgUZ04jsTjsWSOrzsj2rbrDWQF1oPRCdCq9KMcHCAWznRjCc/b5ehc0QteNLb/r+D+Sz cwW/VUyUnH+TblsacYYsOJLE/p1i9PuOy5OLWRk9Z9MSk8zXYzyz99oGwdZ3JeX3ul/30iGyNEw == X-Gm-Gg: AR+sD108KwnaWftIPB+AXZGhZpYEPfZmooSefx+hIHHnQZtwOckh7kQv8Mf605YYvDn zWRVG9fcOzJ8I8Hv8TGy5fEB5lw/j9UiE5Uz8uudq7+cXTr7zUBFBVTMkpWsCj40yUPQQ7jjYiE 5inSTZzJFR5KJRqg1dEh5xcojq2bGjk5IsKg356DTrSB18eU8nJZuAjuH34nucQ1w8pl+DRhXbT qeDf6c6lBA9bjZRJNKOr9KESEblHmk3SHK/bAu4+aMArHSj1ifHATp/WmUIUD/NuDogivxbYofv KU+sT8cmnD8BHuBvHzP/qsYsEqr8Ntth4KPoBQThyDIbfwru/a+oLxbPcmEmBBAdL90WKWBpqxb WPBhxssQR/iGHBuD9UzDGThm4Q79CEoc= X-Received: by 2002:a17:903:234d:b0:2cc:f4d4:29a7 with SMTP id d9443c01a7336-2cf3499781cmr197604405ad.24.1784631911858; Tue, 21 Jul 2026 04:05:11 -0700 (PDT) X-Received: by 2002:a17:903:234d:b0:2cc:f4d4:29a7 with SMTP id d9443c01a7336-2cf3499781cmr197603705ad.24.1784631911184; Tue, 21 Jul 2026 04:05:11 -0700 (PDT) Received: from [10.218.33.235] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3471557bsm73364625ad.58.2026.07.21.04.05.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 04:05:10 -0700 (PDT) Message-ID: <7b74e6de-fa0f-493c-a159-56bfb0c7de4a@oss.qualcomm.com> Date: Tue, 21 Jul 2026 16:35:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] watchdog: pscrr: add watchdog pretimeout reason tracking To: Guenter Roeck Cc: Sebastian Reichel , Wim Van Sebroeck , Benson Leung , Tzung-Bi Shih , Oleksij Rempel , Srinivas Kandagatla , Daniel Lezcano , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-msm@vger.org, kernel@pengutronix.de, avaneesh.dwivedi@oss.qualcomm.com, Umang Chheda References: <20260714-pscrr-reboot-reason-v1-0-a09f23b12527@oss.qualcomm.com> <20260714-pscrr-reboot-reason-v1-2-a09f23b12527@oss.qualcomm.com> <5c824be9-59d8-4acb-a2a3-784182ba3c8c@roeck-us.net> Content-Language: en-US From: Faruque Ansari In-Reply-To: <5c824be9-59d8-4acb-a2a3-784182ba3c8c@roeck-us.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDExNyBTYWx0ZWRfX90PUH1+36XIr IES7d0C7NyIljMqHc2H+GKuYEVdjH5xLrC0XEPTf6+DoQyrWXGeztS1RTwtjjicZQLjcGqhpmqb 8mtFuiJtlbtBnAaTMJCktAN6LB5koNqUXu7i1Hb7N+Jl5zkDXMnqM/nt3dY/7+URka/ieHXsjvq LQhMxFSV8mB9/jQIIHNvWeuwbNwHUkpmW7AewTTUfBrjxhZFCg3z7hF9g61Ha6pJ7gWwFXotA9X 2LZZXQFRPNKZq0YBAsRnpi/YFuUeHZraCOXGy69np1VSqZj+UEp8UE/5oYDenrvPR1t7tw6Yd4X sJ7WANvD2JI7nUp/Szb62QxwnrLDL4Diac3uBJw1LgKSgZYO7hCbd5mMjkw2c6ovcZ9wtDjSz5l xY7ofPa9fH8wsOJL40kHSMoTJxe1p9LbsMSyi4xPd+7D+g4vzjyrq6Evt1jFqRA3KS1y93PRY31 ZSVLxLHRvOBK0XL1HSA== X-Proofpoint-ORIG-GUID: gZH3mu_w3VX4f3Vy2r1nWLORaf74o-oi X-Proofpoint-GUID: gZH3mu_w3VX4f3Vy2r1nWLORaf74o-oi X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDExNyBTYWx0ZWRfXyblx1XJWbvQu q3a3ysr8o2SUMWXaIy6AamW5Z9gL50fJiKoIql7U4hDNAffZqn35XPbBZ5qLi28BUb1mswY4huG qZVHZ3DJrmC8sfdDRc3RkLGazNZov8Q= X-Authority-Analysis: v=2.4 cv=SIRykuvH c=1 sm=1 tr=0 ts=6a5f5268 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=xrrK5rgqtf9zyDDYa30A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_01,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 suspectscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210117 Hi Guenter, On 20-Jul-26 10:09 PM, Guenter Roeck wrote: > On Tue, Jul 14, 2026 at 03:22:35PM +0530, Faruque Ansari wrote: >> A watchdog pretimeout fires before the actual reset, giving the kernel >> a brief window to record what happened. Without this change that >> window goes unused and the next boot sees PSCR_UNKNOWN, making it >> impossible to tell a watchdog-driven reset from any other cause. >> >> Call set_psc_reason(PSCR_WATCHDOG_PRETIMEOUT) at the top of >> watchdog_notify_pretimeout() so the reason is recorded as soon as the >> pretimeout is signalled, before any governor action runs. >> >> Signed-off-by: Faruque Ansari >> --- >> drivers/power/reset/pscrr.c | 3 ++- >> drivers/watchdog/watchdog_pretimeout.c | 3 +++ >> include/linux/power/power_on_reason.h | 1 + >> include/linux/reboot.h | 1 + >> kernel/reboot.c | 1 + > > This is a cross-subsystem change. As far as I can see it would > be easy to split it into two patches. Please do that. > > Guenter > Thanks for taking the time to review this. I'll split into separate PSCRR and watchdog patches in v2. Thanks, Faruque Ansari