From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80E3A423164 for ; Thu, 26 Mar 2026 17:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774546921; cv=none; b=A2Pl1Yt+y6J8Q0IOjmYT5bSjNjOyHKclTMkiJHBPmPC7WgfMEbqNS8oKUIRxPxRxN9U6MTPwd7MO2VGPkIrFO2JCCznAEr/8krfZsfYDZg4eqVYJYCizt291Z7SajBv6KYHI5AEdBhPzwqj5l7ImSrou8nSMcc9mXTIB4sGSNaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774546921; c=relaxed/simple; bh=BzFTvF5t/B6LMlmOGdwHLYYwYDMPyGL2NIRFdw7HOck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I6R+dYO/Cm93WT8mhmnzAzIf7GDvaSJSZugC5XVZmp21cYrezXqg8AmCQHmk0U+LU39oeX0xf/ghhbys35xw8DYdT55DThgOzx2nHDdcTukLTWJ6JV8jY3pHPnvc3uPLv8rmlmtrqhml/FkHry2BSF+6bk/OIMZAldgOTb/8Flk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MiWeT0u8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MiWeT0u8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774546916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MlL0KdtRd8ZQS35f7AZRbMl7B5ahDl/nxKgfSCklydY=; b=MiWeT0u8YdrCznJMlJQ4QCuIqAlM756dUiGtA/NVOr8+GCkKgU30VzyeAqRzRTTQ1eImzO suofHMrK4b+SLCnc7cF1js6oyf/YGeJKFVPQlIgPlOC5baMKxFLwX73b4p2LKpwr4F0lA6 7uO0F6kDzh7M/i7EwkTncozPR+OJxA8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-vMm5o646MxG0naIzniFitA-1; Thu, 26 Mar 2026 13:41:50 -0400 X-MC-Unique: vMm5o646MxG0naIzniFitA-1 X-Mimecast-MFC-AGG-ID: vMm5o646MxG0naIzniFitA_1774546908 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 832D2180034E; Thu, 26 Mar 2026 17:41:47 +0000 (UTC) Received: from [10.44.32.95] (unknown [10.44.32.95]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C95CC180036E; Thu, 26 Mar 2026 17:41:42 +0000 (UTC) Message-ID: <7b7705cd-4a2e-41a6-83c4-7c66e011689b@redhat.com> Date: Thu, 26 Mar 2026 18:41:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/3] dpll: add actual frequency monitoring to netlink spec To: Vadim Fedorenko , netdev@vger.kernel.org Cc: Arkadiusz Kubalewski , Jiri Pirko , Jonathan Corbet , Shuah Khan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Prathosh Satish , Petr Oros , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325193914.124898-1-ivecera@redhat.com> <20260325193914.124898-2-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 3/26/26 12:06 PM, Vadim Fedorenko wrote: > On 25/03/2026 19:39, Ivan Vecera wrote: >> Add DPLL_A_FREQUENCY_MONITOR device attribute to allow control over >> the frequency monitor feature. The attribute uses the existing >> dpll_feature_state enum (enable/disable) and is present in both >> device-get reply and device-set request. >> >> Add DPLL_A_PIN_ACTUAL_FREQUENCY pin attribute to expose the measured >> input frequency in Hz. The attribute is present in the pin-get reply. > > Overall looks ok, but the wording can be improved, I think. What about > using "MEASURED" or "READ" instead of "ACTUAL"? The spec file has this > note already, looks like there were some concerns already? > MEASURED looks good... will change this appropriately. Thanks, Ivan