From: David Heidelberg <david@ixit.cz>
To: Val Packett <val@packett.cool>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/panel: himax-hx83102: Add support for DSI DCS backlight control
Date: Thu, 5 Mar 2026 09:58:11 +0100 [thread overview]
Message-ID: <7b7e3fea-514a-4a3f-bdb4-0d51df7df21a@ixit.cz> (raw)
In-Reply-To: <20260217070121.190108-5-val@packett.cool>
On 17/02/2026 08:00, Val Packett wrote:
[...]
> +
> +static struct backlight_device *
> +hx83102_create_dcs_backlight(struct mipi_dsi_device *dsi)
> +{
> + struct device *dev = &dsi->dev;
> + const struct backlight_properties props = {
> + .type = BACKLIGHT_RAW,
> + .brightness = 4095,
Series looks good, just nitpick here.
While this is not OLED, where full brightness reduces the lifetime of display a
lot, are you sure you want to bring the display backlight up to 100% by default?
Usually I've and others put ~ 50%. It's important to keep display well readable
until userspace takes over, but not have to be full-throttle :)
David
[...]
--
David Heidelberg
next prev parent reply other threads:[~2026-03-05 8:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 7:00 [PATCH 0/4] Add support for hx83102-based Holitech HTF065H045 panel Val Packett
2026-02-17 7:00 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add Holitech Val Packett
2026-02-17 20:25 ` Krzysztof Kozlowski
2026-02-17 7:00 ` [PATCH 2/4] dt-bindings: display: panel: Add compatible for Holitech HTF065H045 Val Packett
2026-02-17 20:26 ` Krzysztof Kozlowski
2026-02-17 7:00 ` [PATCH 3/4] drm/panel: himax-hx83102: Add support " Val Packett
2026-03-04 16:26 ` Neil Armstrong
2026-03-04 19:00 ` Val Packett
2026-02-17 7:00 ` [PATCH 4/4] drm/panel: himax-hx83102: Add support for DSI DCS backlight control Val Packett
2026-03-04 16:27 ` Neil Armstrong
2026-03-05 8:58 ` David Heidelberg [this message]
2026-03-05 8:52 ` [PATCH 0/4] Add support for hx83102-based Holitech HTF065H045 panel David Heidelberg
2026-03-26 9:02 ` (subset) " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7e3fea-514a-4a3f-bdb4-0d51df7df21a@ixit.cz \
--to=david@ixit.cz \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®