From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
fenghua.yu@intel.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] selftests/resctrl: Simplify test cleanup functions
Date: Tue, 27 Feb 2024 14:49:10 +0200 (EET) [thread overview]
Message-ID: <7b86f718-abfb-aa8f-5d4b-ebf5dd7b3e62@linux.intel.com> (raw)
In-Reply-To: <cover.1709018050.git.maciej.wieczor-retman@intel.com>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Tue, 27 Feb 2024, Maciej Wieczor-Retman wrote:
> Cleaning up after tests is implemented separately for individual tests
> and called at the end of each test execution. Since these functions are
> very similar and a more generalized test framework was introduced a
> function pointer in the resctrl_test struct can be used to reduce the
> amount of function calls.
>
> These functions are also all called in the ctrl-c handler because the
> handler isn't aware which test is currently running. Since the handler
> is implemented with a sigaction no function parameters can be passed
> there but information about what test is currently running can be passed
> with a global variable.
>
> Series applies cleanly on top of kselftests/next.
Thanks. For the entire series:
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-02-27 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 7:21 Maciej Wieczor-Retman
2024-02-27 7:21 ` [PATCH v5 1/3] selftests/resctrl: Add cleanup function to test framework Maciej Wieczor-Retman
2024-02-27 7:21 ` [PATCH v5 2/3] selftests/resctrl: Simplify cleanup in ctrl-c handler Maciej Wieczor-Retman
2024-02-27 7:21 ` [PATCH v5 3/3] selftests/resctrl: Move cleanups out of individual tests Maciej Wieczor-Retman
2024-02-27 12:49 ` Ilpo Järvinen [this message]
2024-02-27 16:36 ` [PATCH v5 0/3] selftests/resctrl: Simplify test cleanup functions Reinette Chatre
2024-03-27 23:08 ` Reinette Chatre
2024-03-28 19:25 ` Shuah Khan
2024-03-28 20:28 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b86f718-abfb-aa8f-5d4b-ebf5dd7b3e62@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®