From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF722673A6 for ; Mon, 14 Apr 2025 10:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744625256; cv=none; b=SnEuTMAiv7EO5WLAqCMvJDkueCluwzkuwZU0QABsh1xNsSbeRWNj9Qsnboesns9NIePB+Nj7N+yuFbCnQYTc3R96vhLqnqB6IhYqOBxNEmWUJx+81jjK6fvEp6czu/LQcIDPhw6q8t6eq8kcoRqyk7BKngGlJ4URX2rSmrV2kTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744625256; c=relaxed/simple; bh=oW4WrrQloYzqMgUY4QYvrcjwRb7Mw60Ix2d89Udrn+0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R+BeS282eJb1UI/NOIEcFSq3u+mgLjHBvc3r+DhToGi7APZzmMs9ZOWyQwAlW2RIWvTBS24gUOaXBWgrwjbJK9gvgqm4OlIAZVIdf3lB0TcemY5a9yQ9bO9V1Wt6MBetq+VL2HSbl6TlsOq06qu8atDdKQ0iU28X7QqSu1eghro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HVe9d1iw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HVe9d1iw" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53E99p6S016522 for ; Mon, 14 Apr 2025 10:07:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ly7+Lf4BHJrMjAm9Lfb1Z2p3t9Jk/PAnGffPfBrIx/Y=; b=HVe9d1iw++Z4b9v7 BpiBexfZ0qtbbE9eg5sJFsmaVq+oumcPRIJ2q68IDqwfI6wo8ML5j9CutI/lNTO3 PUzjWbW8nSkeCtH8FE/+BJAIBzmmYwjuOsg34kYDrkYoj9t6yM5p5/KNmbnX+H22 uh79OBlFb1oNUooaQvKivG+y0kNZpCfqj6ZxNvwgsMckzqiWSYI0eRLmVs6TEe3B NBb7x9CS+2XyUkMt4BFr+2sQ89/sApqDaxE2PsOejHxqzNR+WOWo/lnCkzMlflV6 2EQ/KfPXXfcyXTF3bU5QAMpJ4DSspisoK8AJPyjmw0XwFMPncd3Eyy7hVq6Og3G7 XoOgqA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yf69m72e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Apr 2025 10:07:33 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c54767e507so717364085a.1 for ; Mon, 14 Apr 2025 03:07:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744625252; x=1745230052; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ly7+Lf4BHJrMjAm9Lfb1Z2p3t9Jk/PAnGffPfBrIx/Y=; b=rpI3jAQqJozrK3/95hrBUiBR/z4vDfMcwgAwJq9++DClmXaWsFtWO8QC2WlOm7YmR3 lZ6dq2lyeLQTcaI4tc7NnUYx1vuH01DDSxI1EnHzW3k+qJ6F6APHFGR0fxVGIGRQwlQR wB8deYbQmpb+RjPcbQ4kQudTAL4b5rE3icMHxQCjC05YPS7+5cregko7WXa5brhwqX2p 2XB6KjdGUP2loS4WLFyyCjjGXrHVvYb21QrEpRUjMd+Vm/kqcO5C64mVB9DSElZsQ7wh HSLXbjb7pahWcOLNvbTmrC11JZokKlVmLEArpxwcDDMPDYsYyXC/Kzr97PJaOjhSsQlG asuQ== X-Forwarded-Encrypted: i=1; AJvYcCX6jUaoROt80kC19rHfLS0rloy65IR9LdoReYJeYFo/86+SSHTXQaFJQ7r43J4bn6AUIsY0tezj4vuVUK8=@vger.kernel.org X-Gm-Message-State: AOJu0YwtztHJkdKazDC2KsPa3nL/P/pCkxF3pcIrw6GFJ955POC1BtyS vqLmg26XB8ZS9qINQDJqHEwXAOqzA1cyFhg2vfNcjI5BYZAfnC65ZT9FihhwxS/PLMoYagqvm2w fdN0Mrlhz1yZMSE+GZHsEVLGroykm9tEv4hG24/UxD/RGy7KcaVDPKvIFMzGoqLkYuc8fg8M= X-Gm-Gg: ASbGncv+AyWNUoe+wFJSlKfL7vsxNTVLZwFtSMJ874GDFSveeqqcmR+eM8xNdsC9bCx zQ6gLmFRfUT+BjQMbBoJSw37tHyKeJjnQ9GGfRPT8gpzqaL8MKf5y6TI+CNsayAh2q75yKJ7EUi Dup1mq1Tfsdo8tRqeG7Iy/1UF/wIkg30VDzNK4XTjFg4tFqEpzWfyO53/vo3bXDeWpYGQiTejfQ w/USOl8F0sMkc3B9nbE+0OIlCRIcMCJca8cqKTej9QSZGK6/D0MSZaZKpuK1jz2Qjo88xUvg0J8 DnK+yJk2xe1OXDouVt+7qKtwIrsFSEckYBvqAGs4A+KtH/NouNKiupy4/5WGoPOxvyAY4Jm+pP+ SP5ZvrcuFsTnPWdtKb8t2C257Y6OoWaWVdiewPfCiZbXh5ZV4CrK/UzZj5AV1 X-Received: by 2002:a05:620a:2983:b0:7c7:a736:b698 with SMTP id af79cd13be357-7c7af113829mr2043022185a.40.1744625252388; Mon, 14 Apr 2025 03:07:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhW/DRW1SX+Ynk28CKsmigZX51jEHaeI2hluFbgc7JLNiukOLlnHIMVtoWmJiDxFw7PgmHqA== X-Received: by 2002:a05:620a:2983:b0:7c7:a736:b698 with SMTP id af79cd13be357-7c7af113829mr2043015385a.40.1744625251811; Mon, 14 Apr 2025 03:07:31 -0700 (PDT) Received: from ?IPV6:2001:14bb:c3:3f5:b80a:2e22:2f23:20a1? (2001-14bb-c3-3f5-b80a-2e22-2f23-20a1.rev.dnainternet.fi. [2001:14bb:c3:3f5:b80a:2e22:2f23:20a1]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30f464cc0c3sm16322941fa.37.2025.04.14.03.07.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 03:07:30 -0700 (PDT) Message-ID: <7b876428-6f54-4c40-a234-57443eb97ecb@oss.qualcomm.com> Date: Mon, 14 Apr 2025 13:07:29 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes To: Ayushi Makhija Cc: konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, andersson@kernel.org, robh@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, quic_abhinavk@quicinc.com, quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com, quic_jesszhan@quicinc.com References: <20250404115539.1151201-1-quic_amakhija@quicinc.com> <20250404115539.1151201-8-quic_amakhija@quicinc.com> <0f4eca6c-67df-4730-88b3-a277903deabc@quicinc.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: dHxcQXyZCngCvDU64HVG7nWASmF1xckr X-Authority-Analysis: v=2.4 cv=JNc7s9Kb c=1 sm=1 tr=0 ts=67fcde65 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=gEfo2CItAAAA:8 a=COk6AnOGAAAA:8 a=VaffO4KUCATw7Byn6EkA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: dHxcQXyZCngCvDU64HVG7nWASmF1xckr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_03,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140073 On 14/04/2025 12:56, Ayushi Makhija wrote: > Hi Dmitry, > > On 4/11/2025 1:31 AM, Dmitry Baryshkov wrote: >> On Thu, Apr 10, 2025 at 06:37:54PM +0530, Ayushi Makhija wrote: >>> Hi Dmirity/Konard >>> >>> On 4/7/2025 1:42 AM, Dmitry Baryshkov wrote: >>>> On Fri, Apr 04, 2025 at 05:25:36PM +0530, Ayushi Makhija wrote: >>>>> Add anx7625 DSI to DP bridge device nodes. >>>>> >>>>> Signed-off-by: Ayushi Makhija >>>>> --- >>>>> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 208 ++++++++++++++++++++- >>>>> 1 file changed, 207 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>>> index 175f8b1e3b2d..8e784ccf4138 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>>> @@ -28,6 +28,13 @@ chosen { >>>>> stdout-path = "serial0:115200n8"; >>>>> }; >>>>> >>>>> + vph_pwr: vph-pwr-regulator { >>>>> + compatible = "regulator-fixed"; >>>>> + regulator-name = "vph_pwr"; >>>>> + regulator-always-on; >>>>> + regulator-boot-on; >>>>> + }; >>>>> + >>>>> vreg_conn_1p8: vreg_conn_1p8 { >>>>> compatible = "regulator-fixed"; >>>>> regulator-name = "vreg_conn_1p8"; >>>>> @@ -128,6 +135,30 @@ dp1_connector_in: endpoint { >>>>> }; >>>>> }; >>>>> }; >>>>> + >>>>> + dp-dsi0-connector { >>>>> + compatible = "dp-connector"; >>>>> + label = "DSI0"; >>>>> + type = "full-size"; >>>>> + >>>>> + port { >>>>> + dp_dsi0_connector_in: endpoint { >>>>> + remote-endpoint = <&dsi2dp_bridge0_out>; >>>>> + }; >>>>> + }; >>>>> + }; >>>>> + >>>>> + dp-dsi1-connector { >>>>> + compatible = "dp-connector"; >>>>> + label = "DSI1"; >>>>> + type = "full-size"; >>>>> + >>>>> + port { >>>>> + dp_dsi1_connector_in: endpoint { >>>>> + remote-endpoint = <&dsi2dp_bridge1_out>; >>>>> + }; >>>>> + }; >>>>> + }; >>>>> }; >>>>> >>>>> &apps_rsc { >>>>> @@ -517,9 +548,135 @@ &i2c11 { >>>>> >>>>> &i2c18 { >>>>> clock-frequency = <400000>; >>>>> - pinctrl-0 = <&qup_i2c18_default>; >>>>> + pinctrl-0 = <&qup_i2c18_default>, >>>>> + <&io_expander_intr_active>, >>>>> + <&io_expander_reset_active>; >>>> >>>> These pinctrl entries should go to the IO expander itself. >>>> >>>>> pinctrl-names = "default"; >>>>> + >>>>> status = "okay"; >>>>> + >>>>> + io_expander: gpio@74 { >>>>> + compatible = "ti,tca9539"; >>>>> + reg = <0x74>; >>>>> + interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>; >>>>> + gpio-controller; >>>>> + #gpio-cells = <2>; >>>>> + interrupt-controller; >>>>> + #interrupt-cells = <2>; >>>>> + >>>>> + gpio2-hog { >>>> >>>> This needs a huuge explanation in the commit message. Otherwise I'd say >>>> these pins should likely be used by the corresponding anx bridges. >>> >>> Thanks, for the review. >>> >>> Previously, I was referring to the downstream DT and misunderstood the use of gpio-hog. >>> After reading the schematic, I realized that gpio2, gpio3, gpio10, and gpio11 are all input pins >>> to the IO expander TC9539. We have already configured gpio2 and gpio10 as interrupts in the >>> ANX7625 bridges, so the gpio-hog is not required. It is working without the gpio-hog configuration. >> >> Please make sure that there are pinctrl entries for all pins. >> > > Thanks, for the review. > > While declaring the pinctrl entries inside the io_expander node, I am getting below error while checking the DTBS check against DT-binding. > > Error : /local/mnt/workspace/amakhija/linux_next_11042025/linux/arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: gpio@74: 'dsi0-int-pin-state', 'dsi1-int-pin-state' do not match any of the regexes: > '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# TCA9539 is a GPIO controller rather than a pinctrl device, so it doesn't use pinctrl functions. You don't need to describe properties of the pins that it provides. However, it can use some pins on its own (like reset-gpios). In such a case corresponding pin should have a pinctrl configuration under its pinctrl device. > > io_expander: gpio@74 { > compatible = "ti,tca9539"; > reg = <0x74>; > interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>; > gpio-controller; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > > pinctrl-0 = <&io_expander_intr_active>, > <&io_expander_reset_active>; > pinctrl-names = "default"; > > dsi0_int_pin: dsi0-int-pin-state { > pins = "gpio2"; > input-enable; > bias-disable; > }; > > dsi1_int_pin: dsi1-int-pin-state { > pins = "gpio10"; > input-enable; > bias-disable; > }; > > }; > > I couldn't find any devicetree example of tca9539 which is using pinctrl. The gpio-pca95xx.yaml DT binding does not match with any regex of the patterns properties. > > Thanks, > Ayushi -- With best wishes Dmitry