From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] f2fs: fix to restore whint_mode in ->remount_fs
Date: Thu, 1 Mar 2018 10:54:54 +0800 [thread overview]
Message-ID: <7b8a2429-974d-e6d0-f5cc-9bd12a09ebf9@huawei.com> (raw)
In-Reply-To: <20180301024515.GB18665@jaegeuk-macbookpro.roam.corp.google.com>
Hi Jaegeuk,
On 2018/3/1 10:45, Jaegeuk Kim wrote:
> On 02/28, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> If we fail in ->remount_fs, it needs to restore old whint_mode as other
>> mount options.
>>
>> Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")
>
> Hi Chao,
>
> It was not merged, so please allow me to integrate this into the original
> patch.
No problem, please go ahead. ;)
Thanks,
>
> Thanks,
>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/super.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 89abe4087e66..8a93f78efca2 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>> sbi->s_qf_names[i] = s_qf_names[i];
>> }
>> #endif
>> + sbi->whint_mode = old_whint_mode;
>> sbi->mount_opt = org_mount_opt;
>> sbi->active_logs = active_logs;
>> sb->s_flags = old_sb_flags;
>> --
>> 2.14.1.145.gb3622a4ee
>
> .
>
prev parent reply other threads:[~2018-03-01 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 14:01 Chao Yu
2018-03-01 2:45 ` Jaegeuk Kim
2018-03-01 2:54 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8a2429-974d-e6d0-f5cc-9bd12a09ebf9@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®