mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: mysteryli <m13940358460@163.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Willem de Bruijn" <willemb@google.com>,
	"Mina Almasry" <almasrymina@google.com>,
	"Jason Xing" <kerneljasonxing@gmail.com>,
	"Michal Luczaj" <mhal@rbox.co>,
	"Eric Biggers" <ebiggers@google.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	“mystery” <929916200@qq.com>
Subject: Re: [PATCH] net/core: Replace offensive comment in skbuff.c
Date: Thu, 28 Aug 2025 17:23:57 +0200	[thread overview]
Message-ID: <7b8de23e-67c3-46ee-ad02-b80e74f8bea4@intel.com> (raw)
In-Reply-To: <39356464-0b83-46f5-bf13-4f38c3ba2b53@lunn.ch>

From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, 28 Aug 2025 14:36:40 +0200

> On Thu, Aug 28, 2025 at 04:42:53PM +0800, mysteryli wrote:
>> From: “mystery” <929916200@qq.com>
>>
>> The original comment contained profanity to express the frustration of
>> dealing with a complex and resource-constrained code path. While the
>> sentiment is understandable, the language is unprofessional and
>> unnecessary.
>> Replace it with a more neutral and descriptive comment that maintains
>> the original technical context and conveys the difficulty of the
>> situation without the use of offensive language.
>>
>> Signed-off-by: “mystery” <929916200@qq.com>
> 
> Sorry, but this signed-off is not valid:
> 
> https://docs.kernel.org/process/submitting-patches.html
> 
> says:
> 
> Signed-off-by: Random J Developer <random@developer.example.org>
> 
> using a known identity (sorry, no anonymous contributions.)
> 
> Please resubmit using a real identity. Please also take a read of:
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Should we consider applying such patches at all? There are tons of such
comments, mostly in old code, while I highly doubt it may "offense" anyone.

> 
> 
>     Andrew

Thanks,
Olek

      reply	other threads:[~2025-08-28 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  8:42 mysteryli
2025-08-28 12:36 ` Andrew Lunn
2025-08-28 15:23   ` Alexander Lobakin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b8de23e-67c3-46ee-ad02-b80e74f8bea4@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=929916200@qq.com \
    --cc=almasrymina@google.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=ebiggers@google.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m13940358460@163.com \
    --cc=mhal@rbox.co \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®