From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2E5EB64DA for ; Mon, 26 Jun 2023 12:47:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229479AbjFZMrx (ORCPT ); Mon, 26 Jun 2023 08:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229714AbjFZMrU (ORCPT ); Mon, 26 Jun 2023 08:47:20 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94B6E2126 for ; Mon, 26 Jun 2023 05:46:29 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fa74d06d72so32581585e9.3 for ; Mon, 26 Jun 2023 05:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687783583; x=1690375583; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5U82YOAZDYPyrN/dkGhB4WlxPaaJ5TYlLh0PEWA0G34=; b=BpB+X19vNnGSaXQ1f/jI6MKnwETXPmNP/AbUPwUOiw93wVA4Ws/ohU1qqaJp65RlOE wQ1gz/t/jbAGapccMR6W+aKYK/5z7P7DTVFFfsC85+76xgqG2S3NZwVaBvuJpvzOfKvE toKw8UDWLYjNs9ZOzu5JzdI6fTRKuOMgdYDWoUZwspQmRz79xERB3iFfIkWO5Zj3Do89 yMo7kWHEun19RJSr+k+uC4g07nPzOtvcGqin6RdQEvDgf7+AWGd72nroinoYF4/IwF0N 1KLrxbchEXoYPj3fGIKeDt19NU7Ugm43QaJH3p6D+yG+xY3l6G6rRA5j6yc/cvUjaF1+ wevQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687783583; x=1690375583; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5U82YOAZDYPyrN/dkGhB4WlxPaaJ5TYlLh0PEWA0G34=; b=fpxdvXkmKZ+rCCIEzi3KuW9VzEtbhuuN4ur6A4uJTkqhYftBKWQOCg/H8zITWHLFUL FermvDSI1TUkjnUg6DJSArSHIYZcR7jkD25HbEgghDG7/tXEl0h8OxA2MhF/ncy0AmfO ReEE+lthbvGdD2TtpZ2fYxksXdeQNxXfytUD3QRZ43r1W0waQ3tg8U7rbaIDzTnMaXng aPXyiVSzoboXWftBE6xe519aMZPYRQWu4/AU9LlZweFysCHh9HouoT46iwD6I7/zRu3U 5O0WfTOa+Q2MU5e4lzkzopwYEj1kBiyguzXDoJNqp7ghd/g7gAgmD7MVuXD7MKxY5TzU 6c/Q== X-Gm-Message-State: AC+VfDxCaGn6ZTWzxDQEE5WOL4mUbEaHPUd6ZjE/1XAS6652ork+990X 1Vdv0QjiEccn2sTqpglIqR9fBA== X-Google-Smtp-Source: ACHHUZ6DW6Wg0F+Tewscf7xVbXFLxWQfWf0srEoFBzX3rTH3U3MkNhnZv9qxjm/FN7b7cm30qiJPoQ== X-Received: by 2002:a7b:ce0b:0:b0:3f9:b7cc:723 with SMTP id m11-20020a7bce0b000000b003f9b7cc0723mr12953150wmc.21.1687783582958; Mon, 26 Jun 2023 05:46:22 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id d9-20020a5d6dc9000000b0030ae53550f5sm7281468wrz.51.2023.06.26.05.46.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 05:46:22 -0700 (PDT) Message-ID: <7b909a56-1b3d-79fb-0286-b10117982dc3@linaro.org> Date: Mon, 26 Jun 2023 14:46:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot Content-Language: en-US To: Luca Weiss , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Manivannan Sadhasivam References: <20230621143627.189134-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/2023 13:32, Luca Weiss wrote: > Hi Krzysztof, > > On Wed Jun 21, 2023 at 4:36 PM CEST, Krzysztof Kozlowski wrote: >> SM8350 HDK and MTP boards were silently dying and rebooting during BAM >> DMA probe: >> >> [ 1.574304] vreg_bob: Setting 3008000-3960000uV >> [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - >> Optional Info >> Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic >> S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 >> S - IMAGE_VARIANT_STRING=SocLahainaLAA >> S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 >> S - Boot Interface: UFS >> >> It seems that BAM DMA is locally controller (not by firmware) and >> requires proper initialization by the driver prior to use, at least on >> HDK8350 and MTP8350, but probably on all boards. > > Are you sure that the bam (and subsequent the qce) actually probes with > this change? From reading the code I don't see how the bam should probe > without either qcom,controlled-remotely or qcom,powered-remotely but no Why the binding does not require either this or that? Eh, buggy stuff... > clocks supplied. I think the probe just fails with this change, right? I will need to double check. I was happy enough to be able to boot my device instead of having crashes, but indeed it would be nice to fix it fully. Best regards, Krzysztof