mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tom Spink" <tspink@gmail.com>
To: lkml <linux-kernel@vger.kernel.org>, "Jeff Dike" <jdike@addtoit.com>
Subject: UML Reboot Panic
Date: Sun, 24 Aug 2008 21:49:15 +0100	[thread overview]
Message-ID: <7b9198260808241349v45c4d5ffjd908c7ffe34286a1@mail.gmail.com> (raw)

Hi,

When using UML with a UML block device, and issuing a reboot, I was
getting a kernel panic on the next kernel startup because UML was
unable to open the file mapped to the UBD.  I think this is because
the file is not closed when the UBD is released, and the following
patch appears to resolve this issue.  I'm not sure if it's the right
fix, as I may have missed something, but it works for me.

-- Tom

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index b58fb89..946a171 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -802,6 +802,7 @@ static void ubd_device_release(struct device *dev)
        struct ubd *ubd_dev = dev->driver_data;

        blk_cleanup_queue(ubd_dev->queue);
+       os_close_file(ubd_dev->fd);
        *ubd_dev = ((struct ubd) DEFAULT_UBD);
 }

             reply	other threads:[~2008-08-24 20:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-24 20:49 Tom Spink [this message]
2008-08-25 22:11 ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b9198260808241349v45c4d5ffjd908c7ffe34286a1@mail.gmail.com \
    --to=tspink@gmail.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®