From: Paolo Bonzini <pbonzini@redhat.com>
To: Muhammad Usama Anjum <musamaanjum@gmail.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: x86: annotate RCU pointers
Date: Fri, 12 Mar 2021 19:17:47 +0100 [thread overview]
Message-ID: <7ba3b977-d6a3-3518-7426-42e36ec546fc@redhat.com> (raw)
In-Reply-To: <20210305191123.GA497469@LEGION>
On 05/03/21 20:11, Muhammad Usama Anjum wrote:
> This patch adds the annotation to fix the following sparse errors:
> arch/x86/kvm//x86.c:8147:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//x86.c:8147:15: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//x86.c:8147:15: struct kvm_apic_map *
> arch/x86/kvm//x86.c:10628:16: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//x86.c:10628:16: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//x86.c:10628:16: struct kvm_apic_map *
> arch/x86/kvm//x86.c:10629:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//x86.c:10629:15: struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//x86.c:10629:15: struct kvm_pmu_event_filter *
> arch/x86/kvm//lapic.c:267:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:267:15: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:267:15: struct kvm_apic_map *
> arch/x86/kvm//lapic.c:269:9: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:269:9: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:269:9: struct kvm_apic_map *
> arch/x86/kvm//lapic.c:637:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:637:15: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:637:15: struct kvm_apic_map *
> arch/x86/kvm//lapic.c:994:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:994:15: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:994:15: struct kvm_apic_map *
> arch/x86/kvm//lapic.c:1036:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:1036:15: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:1036:15: struct kvm_apic_map *
> arch/x86/kvm//lapic.c:1173:15: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//lapic.c:1173:15: struct kvm_apic_map [noderef] __rcu *
> arch/x86/kvm//lapic.c:1173:15: struct kvm_apic_map *
> arch/x86/kvm//pmu.c:190:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:190:18: struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:190:18: struct kvm_pmu_event_filter *
> arch/x86/kvm//pmu.c:251:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:251:18: struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:251:18: struct kvm_pmu_event_filter *
> arch/x86/kvm//pmu.c:522:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:522:18: struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:522:18: struct kvm_pmu_event_filter *
> arch/x86/kvm//pmu.c:522:18: error: incompatible types in comparison expression (different address spaces):
> arch/x86/kvm//pmu.c:522:18: struct kvm_pmu_event_filter [noderef] __rcu *
> arch/x86/kvm//pmu.c:522:18: struct kvm_pmu_event_filter *
>
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
> ---
> arch/x86/include/asm/kvm_host.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 84499aad01a4..ad675c8c05e7 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -958,7 +958,7 @@ struct kvm_arch {
> struct kvm_pit *vpit;
> atomic_t vapics_in_nmi_mode;
> struct mutex apic_map_lock;
> - struct kvm_apic_map *apic_map;
> + struct kvm_apic_map __rcu *apic_map;
> atomic_t apic_map_dirty;
>
> bool apic_access_page_done;
> @@ -1030,7 +1030,7 @@ struct kvm_arch {
>
> bool bus_lock_detection_enabled;
>
> - struct kvm_pmu_event_filter *pmu_event_filter;
> + struct kvm_pmu_event_filter __rcu *pmu_event_filter;
> struct task_struct *nx_lpage_recovery_thread;
>
> #ifdef CONFIG_X86_64
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-03-12 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 19:11 Muhammad Usama Anjum
2021-03-12 18:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba3b977-d6a3-3518-7426-42e36ec546fc@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=musamaanjum@gmail.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®