From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-input@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] Input: max7359_keypad: Delete an error message for a failed memory allocation in max7359_probe()
Date: Sat, 27 Jan 2018 13:14:16 +0100 [thread overview]
Message-ID: <7ba43976-2b29-abc7-6d08-e8c49b4564a6@users.sourceforge.net> (raw)
In-Reply-To: <95f7f53b-fa1e-8270-ae4c-5b3d721a4831@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 27 Jan 2018 12:56:25 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/input/keyboard/max7359_keypad.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/max7359_keypad.c b/drivers/input/keyboard/max7359_keypad.c
index cd44d22d8770..ba6a670a769e 100644
--- a/drivers/input/keyboard/max7359_keypad.c
+++ b/drivers/input/keyboard/max7359_keypad.c
@@ -184,10 +184,8 @@ static int max7359_probe(struct i2c_client *client,
keypad = devm_kzalloc(&client->dev, sizeof(struct max7359_keypad),
GFP_KERNEL);
- if (!keypad) {
- dev_err(&client->dev, "failed to allocate memory\n");
+ if (!keypad)
return -ENOMEM;
- }
input_dev = devm_input_allocate_device(&client->dev);
if (!input_dev) {
--
2.16.1
next prev parent reply other threads:[~2018-01-27 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 12:13 [PATCH 0/2] Input: max7359_keypad: Adjustments for max7359_probe() SF Markus Elfring
2018-01-27 12:14 ` SF Markus Elfring [this message]
2018-01-27 12:15 ` [PATCH 2/2] Input: max7359_keypad: Improve a size determination in max7359_probe() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba43976-2b29-abc7-6d08-e8c49b4564a6@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®