From: "mirela.rabulea@oss.nxp.com" <mirela.rabulea@oss.nxp.com>
To: Ming Qian <ming.qian@nxp.com>,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] media: imx-jpeg: Correct some definition according specification
Date: Sun, 5 Jun 2022 19:23:17 +0300 [thread overview]
Message-ID: <7ba5f29f-4454-f2e1-c4bb-329fc3f11516@oss.nxp.com> (raw)
In-Reply-To: <20220530074731.14252-1-ming.qian@nxp.com>
On 30.05.2022 10:47, Ming Qian wrote:
> the register CAST_NOMFRSIZE_LO should be equal to CAST_STATUS16
> the register CAST_NOMFRSIZE_HI should be equal to CAST_STATUS17
> the register CAST_OFBSIZE_LO should be equal to CAST_STATUS18
> the register CAST_OFBSIZE_HI should be equal to CAST_STATUS19
>
> Fixes: 2db16c6ed72ce ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
> ---
> v2
> - add Fixes tag
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
> index e7e8954754b1..07655502f4bd 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h
> @@ -53,10 +53,10 @@
> #define CAST_REC_REGS_SEL CAST_STATUS4
> #define CAST_LUMTH CAST_STATUS5
> #define CAST_CHRTH CAST_STATUS6
> -#define CAST_NOMFRSIZE_LO CAST_STATUS7
> -#define CAST_NOMFRSIZE_HI CAST_STATUS8
> -#define CAST_OFBSIZE_LO CAST_STATUS9
> -#define CAST_OFBSIZE_HI CAST_STATUS10
> +#define CAST_NOMFRSIZE_LO CAST_STATUS16
> +#define CAST_NOMFRSIZE_HI CAST_STATUS17
> +#define CAST_OFBSIZE_LO CAST_STATUS18
> +#define CAST_OFBSIZE_HI CAST_STATUS19
>
> #define MXC_MAX_SLOTS 1 /* TODO use all 4 slots*/
> /* JPEG-Decoder Wrapper Slot Registers 0..3 */
prev parent reply other threads:[~2022-06-05 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 7:47 Ming Qian
2022-06-05 16:23 ` mirela.rabulea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba5f29f-4454-f2e1-c4bb-329fc3f11516@oss.nxp.com \
--to=mirela.rabulea@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®