From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755468AbdJIWRV (ORCPT ); Mon, 9 Oct 2017 18:17:21 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:61145 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754959AbdJIWRT (ORCPT ); Mon, 9 Oct 2017 18:17:19 -0400 Subject: Re: [RFT PATCH v2] gpiolib: allow gpio irqchip to map irqs dynamically To: Linus Walleij CC: Mika Westerberg , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jerome Brunet , Chris Gorman References: <20170721164900.7070-1-grygorii.strashko@ti.com> <20170928083348.GI4630@lahna.fi.intel.com> From: Grygorii Strashko Message-ID: <7ba9913d-9411-a75d-e7f0-2e9dcd71d742@ti.com> Date: Mon, 9 Oct 2017 17:17:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2017 02:57 PM, Linus Walleij wrote: > On Mon, Oct 9, 2017 at 8:10 PM, Grygorii Strashko > wrote: > >> At the moment it was merged there were no user of irq_base except gpio-mockup.c. > > OK I feel calmer. > >> And actually there are shouldn't as calling irq_create_mapping() in cycle >> will not guarantee sequential Linux IRQ numbers allocation. > > Yeah. I always felt that was bad practice. > > But we should really kill off that irq_base member from gpio_chip. It looks > dangerous to have arond. patch posted. -- regards, -grygorii