From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A32C282C3 for ; Tue, 22 Jan 2019 16:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CD0B21726 for ; Tue, 22 Jan 2019 16:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548174060; bh=OiF8SEdwDvmQixUXJGQiHbsxraGMdVz1ikZXY9obWhw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=IG7T/okct3NFzmmQkc8+PaUra7lfJZCsG8m6WToaxwgh4qGW/l5lZx5KYagAcxtQ5 QVD2DBa/AGTL74ihKUo3cmIgZB+1O0kyNlUfcZ0yXENm/fn2mEQV5mSf4XNVDpcSVJ 4CwzmzCeRwBUID08zjyeRQihypYKXUW1qogHMpPY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729206AbfAVQU6 (ORCPT ); Tue, 22 Jan 2019 11:20:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:48214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728669AbfAVQU5 (ORCPT ); Tue, 22 Jan 2019 11:20:57 -0500 Received: from [10.84.151.24] (unknown [167.220.148.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C185D20870; Tue, 22 Jan 2019 16:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548174056; bh=OiF8SEdwDvmQixUXJGQiHbsxraGMdVz1ikZXY9obWhw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=s9aLRquZSYEk6lV/U+5B0LjL8WHD93WdItwF/Z42kRpBS3iTREH2Uyp8MLGQqd81f wUdyuRHY+y8gSsXQse7dpLZFDrMVg+3SNNvVQk+gVWWv0kdRQXePCHF9DUvcuauHvD z/iei1MH9/AgfWsN6MC4EgKIy8e4UaKUG6qjkJ7k= Subject: Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS To: Kalle Valo Cc: Luciano Coelho , linux-next@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190121233102.13705-1-okaya@kernel.org> <87munsmztb.fsf@kamboji.qca.qualcomm.com> From: Sinan Kaya Message-ID: <7baaaf76-7f96-cd1d-2a8d-e6c4342c10dd@kernel.org> Date: Tue, 22 Jan 2019 11:20:54 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87munsmztb.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/2019 11:17 AM, Kalle Valo wrote: > Sinan Kaya writes: > >> On 1/22/2019 5:15 AM, Luciano Coelho wrote: >>> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote: >>>> There is an unresolved dependency as follows: >>>> >>>> IWLWIFI_LEDS selects MAC80211_LEDS. >>>> MAC80211_LEDS depends on MAC80211. >>>> >>>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 >>>> (n) >>>> >>>> WARNING: unmet direct dependencies detected for MAC80211_LEDS >>>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && >>>> LEDS_CLASS [=y] >>>> Selected by [y]: >>>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && >>>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || >>>> LEDS_CLASS [=y]=IWLWIFI [=y]) >>>> >>>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this >>>> configuration. >>>> >>>> Signed-off-by: Sinan Kaya >>>> --- >>> >>> Thanks for your patch! But we already have another patch to fix this >>> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git): >>> >>> https://patchwork.kernel.org/patch/10762079/ >> >> Is it possible to queue this up soon? There is an effort to clean up >> linux-next against randconfig failures and this issue showed up there. > > It already should be in linux-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1 > > But it's not in Linus' tree, yet. > Thanks, let me grab a recent linux-next tag.