From: Guenter Roeck <linux@roeck-us.net>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] hwmon: (pwm-fan): Default to the Maximum cooling level if provided
Date: Mon, 13 Jan 2025 08:56:36 -0800 [thread overview]
Message-ID: <7bad4087-5ad1-448e-ac9f-c298a66052d8@roeck-us.net> (raw)
In-Reply-To: <20250113135118.3994998-1-peter@korsgaard.com>
On Mon, Jan 13, 2025 at 02:51:18PM +0100, Peter Korsgaard wrote:
> The pwm-fan driver uses full PWM (255) duty cycle at startup, which may not
> always be desirable because of noise or power consumption peaks.
>
> The driver optionally accept a list of "cooling-levels" for the thermal
> subsystem. If provided, use the PWM value corresponding to the maximum
> cooling level rather than the full level as the initial PWM setting.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Applied, after
> + ret = pwm_fan_get_cooling_data(dev, ctx);
> + if (ret)
> + return ret;
> +
> +
dropping this double empty line.
Guenter
prev parent reply other threads:[~2025-01-13 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 13:51 Peter Korsgaard
2025-01-13 16:56 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bad4087-5ad1-448e-ac9f-c298a66052d8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®