From: Philipp Zabel <p.zabel@pengutronix.de>
To: Andrew Davis <afd@ti.com>, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: Remove ARCH_HAS_RESET_CONTROLLER Kconfig symbol
Date: Fri, 13 Nov 2026 16:22:54 +0100 [thread overview]
Message-ID: <7baedb8836f538707d008b03e259780bc4fc8bd9.camel@pengutronix.de> (raw)
In-Reply-To: <20261112214223.765100-1-afd@ti.com>
On Do, 2026-11-12 at 15:42 -0600, Andrew Davis wrote:
> Many ARCH_HAS_* symbols change some behavior based on what an ARCH
> supports, but ARCH_HAS_RESET_CONTROLLER is used only to set a default
> for RESET_CONTROLLER. Those ARCH symbols that select this can skip the
> middleman and directly select RESET_CONTROLLER, and many already do.
>
> Replace all selection of this symbol with a direct selection of
> RESET_CONTROLLER when it is not already in the selection list. In the
> latter case when RESET_CONTROLLER is also already selected we can simply
"In the latter case" and "when RESET_CONTROLLER is also already
selected" are saying the same thing. I'd choose one and drop the other.
> remove the ARCH_HAS_RESET_CONTROLLER without changing existing behavior.
>
> Some ARCHs "select" this symbol when they actually "depend on" the
> RESET_CONTROLLER framework to build, in those cases the indirect select
> could lead to broken randconfig builds. In cases when it is not needed
> for building the ARCH code, these selections can be switched to the weaker
> "imply" to allow it deselected for minimal builds without reset support.
Can't it just be dropped completely for those? See for example mach-
gemini below.
> Additional checking will be needed to find such cases.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> arch/arm/Kconfig | 2 +-
> arch/arm/Kconfig.platforms | 1 -
> arch/arm/mach-bcm/Kconfig | 4 ++--
> arch/arm/mach-berlin/Kconfig | 2 +-
> arch/arm/mach-ep93xx/Kconfig | 2 +-
> arch/arm/mach-gemini/Kconfig | 2 +-
> arch/arm/mach-imx/Kconfig | 2 +-
> arch/arm/mach-keystone/Kconfig | 2 +-
> arch/arm/mach-mmp/Kconfig | 6 +++---
> arch/arm/mach-omap2/Kconfig | 1 -
> arch/arm/mach-rockchip/Kconfig | 2 +-
> arch/arm/mach-socfpga/Kconfig | 1 -
> arch/arm/mach-sti/Kconfig | 1 -
> arch/arm/mach-stm32/Kconfig | 1 -
> arch/arm/mach-sunxi/Kconfig | 1 -
> arch/arm/mach-tegra/Kconfig | 1 -
> arch/arm/mach-zynq/Kconfig | 2 +-
> arch/arm64/Kconfig.platforms | 9 +++------
> arch/mips/Kconfig | 6 ++----
> arch/riscv/Kconfig.socs | 2 +-
> drivers/reset/Kconfig | 4 ----
> 21 files changed, 19 insertions(+), 35 deletions(-)
>
[...]
> diff --git a/arch/arm/mach-gemini/Kconfig b/arch/arm/mach-gemini/Kconfig
> index f436a2009eca3..11e0e966c3bb6 100644
> --- a/arch/arm/mach-gemini/Kconfig
> +++ b/arch/arm/mach-gemini/Kconfig
> @@ -3,7 +3,7 @@ menuconfig ARCH_GEMINI
> bool "Cortina Systems Gemini"
> depends on ARCH_MULTI_V4
> depends on CPU_LITTLE_ENDIAN
> - select ARCH_HAS_RESET_CONTROLLER
> + select RESET_CONTROLLER
I don't think this is required. There is no reset controller
implementation in arch/arm/mach-gemini ...
> select ARM_AMBA
> select ARM_APPENDED_DTB # Old Redboot bootloaders deployed
> select COMMON_CLK_GEMINI
... and COMMON_CLK_GEMINI already selects RESET_CONTROLLER in
drivers/clk/Kconfig.
regards
Philipp
prev parent reply other threads:[~2026-11-13 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 21:42 Andrew Davis
2026-11-13 13:27 ` Arnd Bergmann
2026-11-13 15:22 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7baedb8836f538707d008b03e259780bc4fc8bd9.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=afd@ti.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®