From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 497461C8626 for ; Tue, 11 Nov 2025 17:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762883135; cv=none; b=oGbpdL0HVL0Rtl5EzSVjmYT4rR+CnRBqPLpUriu1dRdmC5RS4Z3Fy+DgRYmF/eyHdVDWUKcZZW/qY04lxZ22QMsQi7W6N1dRShkiUBoDNfTXbS/Kc7ij3JIEObUm11oTMB5NDvVT16ijlP2fwQCzwSNFE8B64CcqgGmgQXNntvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762883135; c=relaxed/simple; bh=qFqfVNv8CY7kl1TbSgBJCASJkrGC7v0dIcn8lg+2R1c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PLMXXkO5bvy3+BMAffSOFagItGcdXglM1Tsqoz7HZoiJetigvKcirqHoGbFl79LjUJEI8qVHYPWgTxZg1qw67Jr/C/1NKcjWWimfjsXq5TbHj1LIknwPySeZHzjOBsJZJPN+O05tG3nDnQ5Xi3olwGM1hti5dBiOrPDyQHdE+ZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DRkCKmqv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SQDWRIMJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DRkCKmqv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SQDWRIMJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762883132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aRxMT/jej8MFjJFwaDpo3RirJca38pxpSFHOzHKFSiY=; b=DRkCKmqvNqVMWum+2QZ66lYr/DUfaNjroMhhuGSvgHPTq7wkW3VWE2TUowB0YnQrLUQy0d 7WnaVgCOxYJKDVOxOPNxFNx9qaHZYeva+qBiZbVVWjVasm3IaVyExCo26ovx+vK4Ew4bVA wz/QYiXfILIHCq0TD0g9bl39PjM2F1Q= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-ILGLD042Nm6byIkxPR18Rg-1; Tue, 11 Nov 2025 12:45:28 -0500 X-MC-Unique: ILGLD042Nm6byIkxPR18Rg-1 X-Mimecast-MFC-AGG-ID: ILGLD042Nm6byIkxPR18Rg_1762883128 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-42b487cda00so293276f8f.3 for ; Tue, 11 Nov 2025 09:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762883127; x=1763487927; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=aRxMT/jej8MFjJFwaDpo3RirJca38pxpSFHOzHKFSiY=; b=SQDWRIMJB7vmhVpBpkXW0Ecc+3bKUkEV6/QjtPUpsonCmyO1HFSYQKnwqLBluO9tby tiQ4UEOjd7nCZ03/5s6ChMTnyZxkDCeE352oX1uZvD1bLqf/N8TVOcU1f29Yo4PWRu/e EXux/VQaGX7GAAyYSoh7lwWPZ+wS6JqAU3LgMx91BKidMx95GACsaU6v0kjOEPMOwjKC m0hcDmfqZ/cs03I9BQvyS72lQX3oftn9pWzXof6bLlONMazGQwLvqt3LF3tTbOexl86O WsMrch8+V3Zc2NwOpVeHQQ1FkSYKWgzVRY/kHmgO849zzrKuonnEax+c4J++XTjuNNXq ugrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762883127; x=1763487927; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aRxMT/jej8MFjJFwaDpo3RirJca38pxpSFHOzHKFSiY=; b=PNyEFPCY52cS0YvAOb5yF1+6MPe2maOxKRB9XO343/SSHjS13NGISPZkMPBc8sdLOT zZVFnFFSLkZpWeKDBAY+n4HPSR8zoSMbrzP4zrqPOOjwQK0m//3YJGD++mBOBPSgvq3T DHJivlwSVtmDmHpuYKZp71prbGIerNebsyUoq9g603Za5BlzRS0JfZRHpNZq+ySDW05b CnX27cEaD6cmE9xwT/9JWD9iWadDLQbx0RTMafjgmeDYSeXu0Ll/86t0wYaLFff14N+D ef7yUIi+bSbxMWZvas1gAnVhIGMRpcFpCIDk7HU5RwCRSUEO+Ra3Ppv5DFmW7RDfXrSf PNYA== X-Forwarded-Encrypted: i=1; AJvYcCWc1RcPQzdqltm7LLAkohNLsQclfpMVokm/dPU/+gAr1ZI6PH23Bjs9X6WbPUWvb6Eni8NIsVDRxO8UyaE=@vger.kernel.org X-Gm-Message-State: AOJu0YySC1tOseSvbxww35w3y8ToofriwZsWj9mFqpvDRyDDPKfydg6T s8gWX26alNUk9rnX9ppMZ/cIzpwGnR/tTE6hQ3nQVh02npa4eZLNVuyfjtowfblTuwIK7vQCAew lYk2jNIcjYvPEgACgnzMcjtvX5S1tk8RLQTbuOUd9K3K6yDQTwjP5LQ1KcZyGA9aUbQ== X-Gm-Gg: ASbGncswPtpblbD45GES5V5D2tnloXm8GQVsFeGFvOFrO2/OMxdEjpMFeyGWUFRA3H5 zF1JYU5sxdUQA7705JAS54Ethgqyi6TmcCkxQmJCAy4aZcQWKy7l/bIVdgy6Mgrh2WvKnwGEfoW pMJqshBoa/kvldURO+5aOBb+o4cSBdC/g5MW4qoCh3QKsFYFBBTw3IbxE7kngWMTEwC4YreXBtU 3Om4tLsUvA1rmqogOHbPSr00Fj4WhiI6g6CdBHjfIxVtY2e8Pkb2WWjiSH8A3BMJa0nru8X9+lw sOlsDKysYeaItdffjU1OWNTR3e40mJ5eWzpISr+QzsXF3yT6RtLBZqlIwX1sxi3zPMPCLhaMFQe bTC64s0CVuOVui8KOzV4XB5mHWGWV1MnfJQreBFiJibXU5eLx1fezq0KggG6R4MrXyfvrqRUdHa osfBDxEg== X-Received: by 2002:a05:6000:2dc1:b0:42b:30d4:e3f0 with SMTP id ffacd0b85a97d-42b4bb93645mr58482f8f.22.1762883127649; Tue, 11 Nov 2025 09:45:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4iotn4s//bsY/hXaMRsE/Z1iP1fzTtupCR3bGIiAkiu5lxA8fj5eP9KfVURpbWXHL/LzIIw== X-Received: by 2002:a05:6000:2dc1:b0:42b:30d4:e3f0 with SMTP id ffacd0b85a97d-42b4bb93645mr58456f8f.22.1762883127259; Tue, 11 Nov 2025 09:45:27 -0800 (PST) Received: from [192.168.10.81] ([176.206.111.214]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-42ac677abeasm29848626f8f.33.2025.11.11.09.45.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Nov 2025 09:45:26 -0800 (PST) Message-ID: <7bb14722-c036-4835-8ed9-046b4e67909e@redhat.com> Date: Tue, 11 Nov 2025 18:45:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v1 08/20] KVM: VMX: Support extended register index in exit handling To: "Chang S. Bae" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: seanjc@google.com, chao.gao@intel.com, zhao1.liu@intel.com References: <20251110180131.28264-1-chang.seok.bae@intel.com> <20251110180131.28264-9-chang.seok.bae@intel.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20251110180131.28264-9-chang.seok.bae@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/10/25 19:01, Chang S. Bae wrote: > Support to 5-bit register indices in VMCS fields when EGPRs are enabled. > > Signed-off-by: Chang S. Bae > --- > RFC note: > The "chicken bit" (XCR0.APX) checker is intentionally deferred, as the > emulator in the next series will do a similar check. Consolidating the > XCR0 handling at the end keeps the logic clearer during the feature > exposition. > --- > arch/x86/kvm/vmx/vmx.h | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h > index b8da6ebc35dc..6cf1eb739caf 100644 > --- a/arch/x86/kvm/vmx/vmx.h > +++ b/arch/x86/kvm/vmx/vmx.h > @@ -374,12 +374,17 @@ struct vmx_insn_info { > > static inline bool vmx_egpr_enabled(struct kvm_vcpu *vcpu __maybe_unused) { return false; } > > -static inline struct vmx_insn_info vmx_get_insn_info(struct kvm_vcpu *vcpu __maybe_unused) > +static inline struct vmx_insn_info vmx_get_insn_info(struct kvm_vcpu *vcpu) > { > struct vmx_insn_info insn; > > - insn.extended = false; > - insn.info.word = vmcs_read32(VMX_INSTRUCTION_INFO); > + if (vmx_egpr_enabled(vcpu)) { > + insn.extended = true; > + insn.info.dword = vmcs_read64(EXTENDED_INSTRUCTION_INFO); > + } else { > + insn.extended = false; > + insn.info.word = vmcs_read32(VMX_INSTRUCTION_INFO); > + } Could this use static_cpu_has(X86_FEATURE_APX) instead, which is more efficient (avoids a runtime test)? > return insn; > } > @@ -415,7 +420,10 @@ static __always_inline unsigned long vmx_get_exit_qual(struct kvm_vcpu *vcpu) > > static inline int vmx_get_exit_qual_gpr(struct kvm_vcpu *vcpu) > { > - return (vmx_get_exit_qual(vcpu) >> 8) & 0xf; > + if (vmx_egpr_enabled(vcpu)) > + return (vmx_get_exit_qual(vcpu) >> 8) & 0x1f; > + else > + return (vmx_get_exit_qual(vcpu) >> 8) & 0xf; Can this likewise mask against 0x1f, unconditionally? Paolo > } > > static __always_inline u32 vmx_get_intr_info(struct kvm_vcpu *vcpu)