From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794390841; b=q3APlLjutkQ/qa9GkEqWQ0qV0v8CX0/rvwDF+qoydB20Kvm29pIEPP+p3B6fyCure3Oc vlb49Y/Sbw2slezAJAtyFCSHwJCiZ0oSHy0/mI7w9Qcje1ehanCO8JDTp9VqRUczG7MVK 6gnk1ZvtcnuC9ifg5VZSbRkepEiBiMXCl/bCXzhlQrpAXIH9XHDmCO5sD/Wr1Jy+Gwx4H 0oMWtEJNOd4PtyFvZKFAIZHvXXHFntPgdxpdC+dByFiG4v7csE6jKLUhDW6V3jMQuftHL VgFlYKgJaUzSLReRy0D9AublWYw7DzUY5m7hvsBB/psT+xbhYwqqUaCAaBlNZEZ1XJA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794390841; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=iiynlEyig9LsinGQop9Fw8MYPPe7GVoPwBaprgGhDdM=; b=kLH48NN9EEZC5BlW3FrbNY2/o/LYy2/aRuxnxWft9RYba5/1oLGqL8oqVV0lsR/AEQyM utjmFR8XUyACH8PAidvVKWAFTUcYI+1EUq/AR+TK8VElTwDAlx5MJpnQXeMBv1gBUjRDu /Pc6jBTaJ5w4Bj+veadp17Rffnc/0KzPAGqYrgS10tni1uhh/hIQwXeOOhkTmjhTaUu6F cJZXdQuBd8VrleZh8KCBMzzEDNsRB3OTaWho1lS9Fbs9zEKX3h6TFRyUGlBbzS9mI6T7/ CQT0yLpXykDgqPpkEh9fWLXPtNW7mo4fYdYt/iOKcE3hCtOFniOek8dgVhrxfDZFCOQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=KTmdlz2s; arc=none smtp.remote-ip=209.85.128.48 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CF2F606A324 for ; Wed, 11 Nov 2026 09:54:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8CF2F606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=KTmdlz2s Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4afe2d546f9so37860905e9.3 for ; Wed, 11 Nov 2026 01:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794390839; x=1794995639; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iiynlEyig9LsinGQop9Fw8MYPPe7GVoPwBaprgGhDdM=; b=KTmdlz2si8eq6rRIBxKwHAL6SXnZylgbStbTdORWZgkdG7iRcET8/w2ikrDMefQPhX 5SZDXG/avNQCvCY9x+4qmMNc2Ftjbq1QS9RzMV8DtEPnLwfMdHncnvpuejgQ5KlfMNQP 3LZ0xfmy5rVbFt3ug7FXg1bztnDoBZlEEsYI2yj3mwl3R+t6zxzZOzGxGEVbEIz0dzze +VzJ8wwJdQ5KiMxucpR8CUuFnWGjoHFRDFsWoeEw3M1XaNpvyN2mOST/UEGy+QMJcrzN lsKNVjBdSZWKkfMtxgdsLwPiGhdYr0tquEHcFPUfDalBZsLfMSc0Rf9ETvLkoU3Hh12t 7/Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794390839; x=1794995639; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iiynlEyig9LsinGQop9Fw8MYPPe7GVoPwBaprgGhDdM=; b=1fpyjVb1ENJq3jV4OH2yMwxlXT9uly71fubAGdT1SR3rEy6IdVMSrNm+iPSLR8j7Ir /ZCo3Uhnj0G9RfJ1nL+SlF0vUaP7aLyR9PJw19rHWtU95nrxI3f/VAHkyQPGDWExHiSs GE12QzHvZ+gUyksPKcFTcAA7xODYrQ0XOaF9zWuyKXJsTfkdKVukkn09dnDb154pFBxb h4oOXK43ZSFWSkKN0h57AeYxJXi9P0NXa8Zq/C5CGdOPCNTuwl8N/vap7MAPChQP3VCP m0Sfe73aNe2ZbDvQCJZWlegxmzL6wlqqijXSFbgAkvZ9OWtfCHVuVqme45V3hp++NiF1 /rqA== X-Forwarded-Encrypted: i=1; AL+hErGWXiUYXN3+Ikcs0PRWmSiIbRIIQ4yLPrrae3Sk7SonffKnDmOzOwqVQO7i74pKvtlw6J+12BWLmHIPOpw=@vger.kernel.org X-Gm-Message-State: APuU4Z94R6ThhYQH0aANjJuhMSBwANnwvyF7XZRThleEwWNNu/vopfmB SOJFgohzzuz5YoiEb2u3nO65Qfs4Ma5LIgZC9I9DDUXfxPi1ivdRxwBa52czzg+at5o= X-Gm-Gg: AYBFou1MgFIVLbvI6voonDIUaMtYhELfWtf3nVbBWMY4s5YywUUiZTt8xUh+cullK3k fG+n5SuQ25BeP7VcM6G3qZFxlUlKrpMwMxlcbOKdmw+X6IwmAAd3qRGkwDZ0ciMdSP2lOv8HJro y67d5aEEc8t2j49+ZcZum1xfTIgI/t6s8EDVJDIEuZqBfIa3lh9HPtBZGsrj03WIbOtzZA7LJAo /1eNHJnrUYiEizA2bP6I26IqKg41531+VLCCLJnJygSbSWXBo29q8JWa6G2U254mBQm6ur5H+hA A8RtISya8j34hbTqiP4hrYXOsf2Rb0/6spLow18d1UW3BH15ryudqaSIAejR0+ompEhGYgQtJ/H 7vw6ybuZxNC2tS+7pLI6BgvjUGBC5WjWaAmQwJsD9wwrOcyaeCeKxnPSh8Ma+yXlwGzSVUIxzyt xUHobepoHM6LvD4BG8Pi/78gbTv9BZki4SCD+KItcVuhE0pXWQx3EQIhnUofveFAer9W7Mevw3w 9HZ6stFcAeKRyuzsIqvtqGDrNd4AwHuVDp80TZ/9ydMQ4Yh5J5EnIcI+O8thIRcmudemNwgmv3I CgAuA3XyD3r9SPK0+t5O7n5267GviPop3g== X-Received: by 2002:a05:600c:1549:b0:4a2:cbe:bebc with SMTP id 5b1f17b1804b1-4ba0938ba0amr31926455e9.23.1794390838905; Wed, 11 Nov 2026 01:53:58 -0800 (PST) Received: from [192.168.1.3] ([37.18.141.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba01fba35csm116824795e9.1.2026.11.11.01.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2026 01:53:58 -0800 (PST) Message-ID: <7bb2995a-e510-41e3-ac3f-cc4135b3774c@linaro.org> Date: Wed, 11 Nov 2026 09:53:57 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: perf: Drop the example the userspace counter section points at To: TAKANO Mitsuhiro Cc: Mark Rutland , Jonathan Corbet , Namhyung Kim , linux-doc@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon References: <20261111023550.1971639-1-takano32@gmail.com> <20261111034432.2020955-1-takano32@gmail.com> Content-Language: en-US From: James Clark In-Reply-To: <20261111034432.2020955-1-takano32@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/11/2026 03:44, TAKANO Mitsuhiro wrote: > Documentation/arch/arm64/perf.rst points at > tools/perf/arch/arm64/tests/user-events.c, in the text and in the link > target, but that file is not in the tree and no commit in the history > leading to this base has added one. > > The section already describes how to use the libperf helpers and points at > tools/lib/perf/tests/test-evsel.c as the example, so the sentence that > sends the reader elsewhere is redundant. Remove it and the link target > rather than pointing at another test, and move the instruction for running > the example into the How-to section, next to the reference it belongs to. > > Signed-off-by: TAKANO Mitsuhiro > --- > v2: drop the reference instead of pointing it at another file, and move > the instruction for running the example into the How-to section. > v3: the v1 history moves here, so the commit log is the change alone; the > sentence about the missing file is stated once. Raised by Sashiko. > > Documentation/arch/arm64/perf.rst | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/Documentation/arch/arm64/perf.rst b/Documentation/arch/arm64/perf.rst > index 997fd716b82f..5b9cc2aeb642 100644 > --- a/Documentation/arch/arm64/perf.rst > +++ b/Documentation/arch/arm64/perf.rst > @@ -131,7 +131,12 @@ changed. > > The userspace access is supported in libperf using the perf_evsel__mmap() > and perf_evsel__read() functions. See `tools/lib/perf/tests/test-evsel.c`_ for > -an example. > +an example, which can be built and run from the source tree: > + > +.. code-block:: sh > + > + make -C tools/lib/perf make-tests > + tools/lib/perf/tests-static > > About heterogeneous systems > --------------------------- > @@ -140,14 +145,6 @@ only be enabled when the tasks are pinned to a homogeneous subset of cores and > the corresponding PMU instance is opened by specifying the 'type' attribute. > The use of generic event types is not supported in this case. > > -Have a look at `tools/perf/arch/arm64/tests/user-events.c`_ for an example. It > -can be run using the perf tool to check that the access to the registers works > -correctly from userspace: > - > -.. code-block:: sh > - > - perf test -v user > - > About chained events and counter sizes > -------------------------------------- > The user can request either a 32-bit (config1:0 == 0) or 64-bit (config1:0 == 1) > @@ -160,8 +157,6 @@ userspace must treat the upper 32-bits read from the counter as UNKNOWN. The > and should be used to mask the upper bits as needed. > > .. Links > -.. _tools/perf/arch/arm64/tests/user-events.c: > - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/arch/arm64/tests/user-events.c > .. _tools/lib/perf/tests/test-evsel.c: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/lib/perf/tests/test-evsel.c > > > base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb Reviewed-by: James Clark