From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386AbcHVNGN (ORCPT ); Mon, 22 Aug 2016 09:06:13 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34028 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755263AbcHVNGJ (ORCPT ); Mon, 22 Aug 2016 09:06:09 -0400 Subject: Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute To: Jaroslav Kysela , Takashi Iwai References: <20160806095837.25885-1-nicolas.iooss_linux@m4x.org> Cc: linux-kernel@vger.kernel.org From: Nicolas Iooss Message-ID: <7bb40eff-d1ae-4739-0396-6f24089416f5@m4x.org> Date: Mon, 22 Aug 2016 15:06:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160806095837.25885-1-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, After I sent the following patch a few weeks ago, I have not received any feedback. Could you please review it? Thanks, Nicolas On 06/08/16 11:58, Nicolas Iooss wrote: > asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format > some of its arguments. Adding a __printf attribute to this function > makes it possible to detect at compile-time errors related to format > strings. > > Signed-off-by: Nicolas Iooss > --- > include/sound/simple_card_utils.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h > index 86088aed9002..3207b1a70d38 100644 > --- a/include/sound/simple_card_utils.h > +++ b/include/sound/simple_card_utils.h > @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev, > struct device_node *codec, > char *prefix, > unsigned int *retfmt); > +__printf(3, 4) > int asoc_simple_card_set_dailink_name(struct device *dev, > struct snd_soc_dai_link *dai_link, > const char *fmt, ...); >