From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.158 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794952046; b=F+hSrvq7224dJ7daMQfDnanqgDURoxcOjeuQ7lw4j67eGHw/TiKmznwXk6lLn6MMLflX mvldtu5qjnMrpGM7i/aPg9SIsQrBKwdeVxC/T5COwmVomDFU8YyX66UOuO5v4E0DCrQll 6AzgJuSN/5xkdWP4nud3QHngSCqr3zLO3WHTPSzfq6FlhL216Vi3EAwd5bLOEukQTecSz THneE0fkePKTPhTDdWovlm6EhDEOhMfT7+O7dojf2Xvrh4/uJ04sGdzNdP0n7koa3/Mch uIY7YhxV6UNtgR12Mx80VwSx/9qzLM/XdKcb67cBriiU3UMW5lOhMbcEqbRd3ru7iAg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794952046; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc: References:From:Content-Language:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=3yhBkhMN26vnloZoWn5dl5+ivW+PJjpitXBcGq1NB/c=; b=BYAx5raqTnL1lkpHeh4Twxa60CEYKv7qdrGMaS2LErjUXE1651lmYp3+q/Q2RO6PIWMD TicRZU6y6ELKsHCCs5ENT4LiqyNt/3jYCPQ3MojYlhS3bH9ParkifdTfDRMBZdxSDBSJQ P9c3x9nf4Gk+VzEy6SsjIeYEuFkdCzz29RcLYjKdwtPi+5D//YUi/fni8zL8bnEcmXoU9 s/S0HPoEPkWiS/s6mI/6SG6MKUMeoT3g8cjwX7SJ8swJSktaw4KNq1hSwnbTQEB7ZuB2v L9wHj3Oxm/GL9AKsUFDsGP1HqaYbF0qp6T98wI6T2y2a2oZKAfT6harsAGfo3Bf+pVw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bsbernd.com; spf=pass smtp.mailfrom=bsbernd.com; dkim=pass header.d=bsbernd.com header.i=@bsbernd.com header.a=rsa-sha256 header.s=fm2 header.b=B+wgJLpp; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=Kb9GNFir; arc=none smtp.remote-ip=202.12.124.158 Received: from fhigh-b7-smtp.messagingengine.com (fhigh-b7-smtp.messagingengine.com [202.12.124.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332D1606A338 for ; Tue, 17 Nov 2026 21:47:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 332D1606A338 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bsbernd.com header.i=@bsbernd.com header.a=rsa-sha256 header.s=fm2 header.b=B+wgJLpp; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=Kb9GNFir Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 62B407A0258 for ; Tue, 17 Nov 2026 16:47:25 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Tue, 17 Nov 2026 16:47:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsbernd.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1794952044; x=1795038444; bh=3yhBkhMN26vnloZoWn5dl5+ivW+PJjpitXBcGq1NB/c=; b= B+wgJLpph/ZiX12qdjSkFpmEqaTF+ks7B7uuzccHBhWKvsIg4SswA2ah0VZxGtfV hUsPIgrUdiIAifX3dqswsNGdo2NMOIS6+Zan8luwkZoZiFGaQJ8aboAMKSdot6fR zP8NrX0/IDKQJHzHhDD0PzdKZdF/U7EwRyg5X/BkvrCEnBDsGyEa1ZBWAu7iXxIP 3oAjNneIqnegEIbmSxqSwW3XILpGvhRoEmM+0+GhDW+cFX9MbRP5kB/Z8CYQ5Ck5 JX7BfIqEj3RHi1nKOAU8des+PyTxQ09TAde5ooHIQ1M9WUQQTAlBo168VGwepLUl W7mNK3eeGx1c/Hm2awv4lw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794952044; x= 1795038444; bh=3yhBkhMN26vnloZoWn5dl5+ivW+PJjpitXBcGq1NB/c=; b=K b9GNFir1+Hy9IUKYFpHArVmYZBL1H7M4FJucCwW5JexT7Ou5qWxJTnFpD3Sp1Q9v jmhQKUfop97z5wyL+Z+ESDKLKoJNP7VLSQpcPFzzKko9Eanel0swfMuxTaUEtzvb eY/7dZh3MmUSVzwA1oF9DBNvIkMzz6waiPionOmsHg/QKaNqA6IYzfAzFgs7gnD/ 3VMrweKvkGFpP24XA5F72dJ5+gMLR0+aXAXyENS83hvHwbNkhZeRta8g/IwyY7vq bkoAj1BqG06Knzrl+nvVpQ8Q2W/IczCZSZQ/z9gVEuU7jpriB38PE2Peh5snDHov wsZPQt/JlKiwUHsxA+QRQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=bsbernd.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794952044; d=bsbernd.com; mf=PGJlcm5kQGJzYmVybmQuY29tPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm2:rsa-sha256:HEn6F4Kb/3IImc5DmTo1He4zjDYs/kqJTspYj1QHE5Bl93Z xqEaDvrFiK9UzYCnXtMxahdse3+5/6dhSb6F1kqLaOEYfXIH37VxUaohvVEQmxTN NQJP4rDi/PN17uIQf7k9br8LkJ+BtsuJk29vbYxOiqgowTwOnD/XYCC47R7yJBjX /gwxoeIWysajny/9T+008/v6wG2wkOac/s6eC9IMGJtuENGGnHVRVSTIUk17oQXM JNN3kpECFFwkSgInIfqgdMmCXsR/VunpNwid/Lu9rKfkeB5jyfyIHc2PQnNk+YIP 0cK0w5IILR6piJGR/QJS4hJxF7fNikgekJva7dw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=14; hn=cc,content-language,content-transfer-encoding,content-type, date,feedback-id,from,in-reply-to,message-id,mime-version, references,subject,to,user-agent; Message-Instance: m=1; h=sha256:l/xewH31JcsHKZ/rtP4n+RLtgwszb6PhEbx7llNpivI=:viLTBmPNSyOHS70EIiWYcahgvhcIMUxFSOZ9D1rELM0=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTE9Z/V8qt9NuPrQY/pJHtbJkEFd7tmFyocFF9Jep6ai76hrzxx4iG3kg7wGmLLv34 zpuDSYSTPCafu9x1cVknf3C6Awr/VRkqfueR3ixaY8/EUfNsm9QYjfHCpsKsxpamLCgZ5H EpT/EeO0wTbjH6NQiNv+dN7mn7h2OteUlX1mVikmh4/x2KXtoi4q8haIxUFgsg85nQUrxr fO9Ru57tqPNMdj4VswJUc7HjN9ujkRGUho2hoaYb81A6yMyxqOJSizBAkU7u6Em1nb/hnc /cfyg4IZ5NbUuiwvbP55rpm0egxJNsIRfeLNmPngkY+IdyEDfGKDLSHwgVWf5wYSkZDWE5 x26clLvCKcsXzrWoD74O0G8ErZz7YX5mwCl0kCGcDU44v89avDHhHWjt9Iz/geGpivbx0Y VjEpgMV4Pr0kQFg+bxbDzu/D7tO5URWQSzG+ZgvDOEoSsQbp32dyKiJ9p3xhV0zO6wl/G/ kYf4Hw/mlee8rCIAMSPEHs9ctfnIHfUcF7NehXB+L7+NgJ/H9wBGt5J4vuLUdj8TeQMoWW u76hVlgUYmvx+IuVzOFtnBDnZOqEW5wxbx5VgYK8GaxfNGXy/bVsQn9bEoPG30cph7QLCy Eoa7UDJs7pnX1gj7Pkz+v+E8waCHL52L3pcAZmoH2TYwgqedT0YVahRHKRTg X-ME-Proxy: Feedback-ID: i5c2e48a5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Nov 2026 16:47:23 -0500 (EST) Message-ID: <7bb720d9-30ef-4d3f-8ab8-81c5fe2e0fe1@bsbernd.com> Date: Tue, 17 Nov 2026 22:47:21 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] fuse: don't wait for a sync-init mount in fuse_uring_cmd() To: Yun Wang , Miklos Szeredi Cc: Joanne Koong , fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org References: <20261117075632.59959.p12-0-arsenova@a7snv.com> <20261116235814.60702-1-arsenova@a7snv.com> From: Bernd Schubert Content-Language: fr, en-US, de-DE, ru-RU In-Reply-To: <20261116235814.60702-1-arsenova@a7snv.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/17/26 00:58, Yun Wang wrote: > fuse_uring_cmd() gets the device with fuse_get_dev(), which waits for > the mount of a device in sync-init mode. io_uring normally issues the > command from the task that called io_uring_enter(2), so an > IORING_OP_URING_CMD on such a device before the mount puts that task > to sleep until the mount or a signal. This happens before the > enable_uring check, so also when fuse-over-io-uring is disabled. > > Until FUSE_INIT has completed, fuse_uring_cmd() returns -EAGAIN anyway > and the server has to send the command again later. Return -EAGAIN > at once when the device is not mounted yet either, using > fuse_get_dev_nowait() from the previous patch, and don't log "No fuse > device found" for it. And what is if io-uring is enabled? Userspace busy loop until the device is available? I don't think that is nice. Thanks, Bernd > > Fixes: dfb84c330794 ("fuse: allow synchronous FUSE_INIT") > Signed-off-by: Yun Wang > --- > fs/fuse/dev_uring.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/fs/fuse/dev_uring.c b/fs/fuse/dev_uring.c > index 460776cd69..0f725172ae 100644 > --- a/fs/fuse/dev_uring.c > +++ b/fs/fuse/dev_uring.c > @@ -1664,9 +1664,15 @@ int fuse_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags) > if (!(issue_flags & IO_URING_F_SQE128)) > return -EINVAL; > > - fud = fuse_get_dev(cmd->file); > + /* > + * Don't wait for the mount of a sync-init device: this may run in > + * the task that called io_uring_enter(), and the ring can't be > + * registered before FUSE_INIT anyway, see the -EAGAIN below. > + */ > + fud = fuse_get_dev_nowait(cmd->file); > if (IS_ERR(fud)) { > - pr_info_ratelimited("No fuse device found\n"); > + if (PTR_ERR(fud) != -EAGAIN) > + pr_info_ratelimited("No fuse device found\n"); > return PTR_ERR(fud); > } > fch = fud->chan;