From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shengyang Chen <shengyang.chen@starfivetech.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
tomi.valkeinen@ideasonboard.com, r-ravikumar@ti.com,
rdunlap@infradead.org, u.kleine-koenig@pengutronix.de,
bbrezillon@kernel.org, changhuang.liang@starfivetech.com,
keith.zhao@starfivetech.com, jack.zhu@starfivetech.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: display: bridge: cdns: Add properties to support StarFive JH7110 SoC
Date: Mon, 27 Nov 2023 13:23:43 +0100 [thread overview]
Message-ID: <7bba5723-97c2-4301-9864-353d8bfda752@linaro.org> (raw)
In-Reply-To: <20231127113436.57361-2-shengyang.chen@starfivetech.com>
On 27/11/2023 12:34, Shengyang Chen wrote:
> From: Keith Zhao <keith.zhao@starfivetech.com>
>
> Add properties in CDNS DSI yaml file to match with
> CDNS DSI module in StarFive JH7110 SoC.
>
> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> ---
> .../bindings/display/bridge/cdns,dsi.yaml | 38 ++++++++++++++++++-
> 1 file changed, 36 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> index 23060324d16e..3f02ee383aad 100644
> --- a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> @@ -17,6 +17,7 @@ properties:
> enum:
> - cdns,dsi
> - ti,j721e-dsi
> + - starfive,cdns-dsi
BTW, one more thing, I really doubt that starfive created "cdns" block.
"cdns" is vendor prefix. Use SoCs-specific compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-27 12:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 11:34 [PATCH v1 0/2] Add StarFive JH7110 SoC DSI support Shengyang Chen
2023-11-27 11:34 ` [PATCH v1 1/2] dt-bindings: display: bridge: cdns: Add properties to support StarFive JH7110 SoC Shengyang Chen
2023-11-27 12:22 ` Krzysztof Kozlowski
2023-12-08 6:54 ` Shengyang Chen
2023-11-27 12:23 ` Krzysztof Kozlowski [this message]
2023-12-08 7:00 ` Shengyang Chen
2023-11-28 15:52 ` Rob Herring
2023-12-08 7:03 ` Shengyang Chen
2023-11-27 11:34 ` [PATCH v1 2/2] gpu: drm: bridge: cadence: Add a driver and platform ops for " Shengyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bba5723-97c2-4301-9864-353d8bfda752@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=bbrezillon@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jack.zhu@starfivetech.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=keith.zhao@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=r-ravikumar@ti.com \
--cc=rdunlap@infradead.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shengyang.chen@starfivetech.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®