From: stsp <stsp2@yandex.ru>
To: Jeff Layton <jlayton@kernel.org>, linux-kernel@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests: add OFD lock tests
Date: Thu, 22 Jun 2023 21:40:52 +0500 [thread overview]
Message-ID: <7bbb29d2-4cae-48bd-1b97-9f4dbf6ffb19@yandex.ru> (raw)
In-Reply-To: <4db7c65bee0739fe7983059296cfc95f20647fa3.camel@kernel.org>
22.06.2023 16:48, Jeff Layton пишет:
> I'm not opposed to adding a selftest here, but most filesystem testing
> is done via xfstests:
>
> https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/
>
> It would be better to add this test to the existing generic/478 test
> that tests OFD locks. Can you patch that to add a test for the new
> functionality?
I don't actually think its possible.
It seems like their script creates 2
t_ofd_locks processes, one for creating
the lock, one for testing it.
This is not our case.
To make it work our way, we'd probably
need to hack that test directly into
t_ofd_locks.c, so that it can set and test
from the same fd. And I don't know how
to even run these tests. :)
So I am really inclined to limit myself
with a kernel selftest.
next prev parent reply other threads:[~2023-06-22 16:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:22 [PATCH 0/2] v2: F_OFD_GETLK extension to read lock info Stas Sergeev
2023-06-21 15:22 ` [PATCH 1/2] fs/locks: F_UNLCK extension for F_OFD_GETLK Stas Sergeev
2023-06-21 15:22 ` [PATCH 2/2] selftests: add OFD lock tests Stas Sergeev
2023-06-22 11:48 ` Jeff Layton
2023-06-22 16:40 ` stsp [this message]
2023-06-22 16:58 ` Chuck Lever III
2023-06-22 17:05 ` stsp
2023-06-22 17:12 ` Chuck Lever III
2023-06-22 17:31 ` stsp
2023-06-22 22:15 ` Dave Chinner
2023-06-22 17:34 ` Frank Filz
2023-08-09 7:56 ` stsp
2023-06-22 16:54 ` stsp
2023-06-21 15:22 ` [PATCH] fcntl.2: document F_UNLCK F_OFD_GETLK extension Stas Sergeev
2023-06-22 12:03 ` Jeff Layton
2023-06-23 10:07 ` stsp
2023-06-22 16:52 [PATCH 0/2] v3: F_OFD_GETLK extension to read lock info Stas Sergeev
2023-06-22 16:52 ` [PATCH 2/2] selftests: add OFD lock tests Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bbb29d2-4cae-48bd-1b97-9f4dbf6ffb19@yandex.ru \
--to=stsp2@yandex.ru \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®