From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D385133A001 for ; Wed, 26 Nov 2025 15:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172062; cv=none; b=murR/32PFNWM9hF1kxFX2O3kBSHUgTe2raBDgRWVLZ3oGpUeaFjAxqbS2z6sR0ulYqyeEZbQ0yaSLEnqXHERuTDtAbXOzsmtNhFjzcGB8+GrvC5lCUIOXFu5gVVNr13JvfLT2PpGLl2E8GVIk9pR1kCssdaFXjVpHThbVCnMeIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172062; c=relaxed/simple; bh=7iiTxNdc8046qU8odOqHiUP/nHnycJlb1fa0+2jHNdw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qbkseMDSDNV0zp5Qq+9oD7SITbzhg8MS/v2rlcGED0jAOoZkjtP8vV4k/mT/CX1P81ChJzTu/Ie6r6ItEZmF8I5DfTpey/jpkP40v92xHyUogZKI2HlcWL9hf+CjOb7YBX4NJmGEW/mSCQc2uXd2cAPVdC9SmNoxIKiVVRjVWlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UvoGeLaJ; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UvoGeLaJ" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7b8eff36e3bso10661169b3a.2 for ; Wed, 26 Nov 2025 07:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764172060; x=1764776860; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=xF5Xtni1/AYFqCokHeYYJP04NlV/hJc9AHFoC1o2Aug=; b=UvoGeLaJsLMoTI2lZhAh3Wf37obj7diZAie+ritTKO6yvTE92EI/INsx1UQNWJJS7F DlRV6/woYkCIrobQvIyzvXjoIpuFMTBwsldegDOoGyoA7SU8ncXTLyfMRcwWn4IdYcHg iLrVEAQg+wPizvbacUtjP15av/6v3XD+1XvKaEX4F7YuInOOp4M7XYxhUf+Gti1ss1Ze bAnrdjm4UgnfkUE6lH1hk44SkFTmGGcHhlvB9A3ZBf+zbhGhBoWCZNTUP0Dmw6Y3n6w+ XKh2zZVgtOy5AYYOrxednZxvAd2BhWGfj3rvf8d6Vx0YsHYvZ8rqy/P3NQrngChS7N5M 8L3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764172060; x=1764776860; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xF5Xtni1/AYFqCokHeYYJP04NlV/hJc9AHFoC1o2Aug=; b=Etof2YpnOrGE2Pih3Xf0cWHEet84fgQV0quDsY6U9zhdEWMcEql0yLtg5VrZDyuDmf clV1HVSowiib6+0Cl0frNQLwusSlZtFOSXD+39pm8ArHSAMLNX59Dr3OIe8BBivvGil8 nLqCApmsioJRhQSYOarlM10tfd3G56yB1+lumFDfyatkqiiCRjilA+pf53g5cy3E/MRL zR/tKhEOHjZA8MX7YlzvJ21wRiXTCYMhJQ8LIn+7FhMrHcHpMhPXInMHlNDbt+6WYP6K mOXZaQvqalD2fkpytt440dC63cj1B/n/nOLMwNMXKVbykw7ARSsd40h8nbdj7/m+cFIJ Oxgg== X-Forwarded-Encrypted: i=1; AJvYcCVSJ0fkwl/tfz0hOq5vfbbaqqV5kyeAFFYUvRZ8Vr5iZmVYx6oOp0Pd3xxOljHWn9iWUWGt99GDNxpa+gg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy28XGMU8gk6l6qSgq8kKd5u/st1yQk0BiWcA+s2Y0mfJL5bpxL T0QTCsSurcAS0lUvSHXYTpsfLV4myTV95HupZZm59RsnveWCjjOQwApGBQzQLQ== X-Gm-Gg: ASbGncvk3NMXIES+Ejs3sndLFjDna31QMy8px33D07TsoF9AYPTbFoTUWLcZ0HUUYE+ xz2/Q4w9uK7Cy9zg0oFbZO6vta2nRAtugqYPIIjBJg2iSuZNKJt+ReohtaPWY/+CrLEVRsRalWA FYKM4ndfL5CdF4lEIJo7tPyJ1qDIjA6rTOxDX6ySagqcFOsd0xp0GAyXMiHmB/35ZV58Ul22sfw KJEpsKAXUr/P/qznAXNQ4jZFkvvGW44yz1L4K/mTEw79qym8S0h5QDfkt5KPeAbJIw3naCsUFDL IVRaTVtTzeaR2Z37t/1CmInGbo4IvT3JZGZOu86FsGefUQI0LTVWe8nUAB6lalvX6fCDtuB5Jk6 pXy6uMn3gcr3ovK36hMfaJR6/hhr5RMxDgoJ7EJr4uEJyq3kZnsi9yJuZQuvR2udSy+ok4Jf2OI jx0ZUPt+mAvRLwfx2QXTxpDsw= X-Google-Smtp-Source: AGHT+IFw0xH5oGTzPJ8jc3QTmyTJlEB4ZkNkdi8h2SLw4qW7lsXPs1iPmfIJlo4B9zuyjXSwSJOgQg== X-Received: by 2002:a05:7022:7e05:b0:119:e56b:c75b with SMTP id a92af1059eb24-11cbba4a4edmr4966865c88.32.1764172059996; Wed, 26 Nov 2025 07:47:39 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11c93db556csm95966195c88.1.2025.11.26.07.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 07:47:39 -0800 (PST) Sender: Guenter Roeck Date: Wed, 26 Nov 2025 07:47:37 -0800 From: Guenter Roeck To: Gui-Dong Han Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: (lm87) Convert macros to functions to avoid TOCTOU Message-ID: <7bbdaf5a-4d88-4fc1-bcc8-597fec2851dd@roeck-us.net> References: <20251126113542.9968-1-hanguidong02@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251126113542.9968-1-hanguidong02@gmail.com> On Wed, Nov 26, 2025 at 07:35:42PM +0800, Gui-Dong Han wrote: > The macro FAN_FROM_REG evaluates its arguments multiple times. When used > in lockless contexts involving shared driver data, this causes > Time-of-Check to Time-of-Use (TOCTOU) race conditions. > > Convert the macro to a static function. This guarantees that arguments > are evaluated only once (pass-by-value), preventing the race > conditions. > > Adhere to the principle of minimal changes by only converting macros > that evaluate arguments multiple times and are used in lockless > contexts. > > Link: https://lore.kernel.org/all/CALbr=LYJ_ehtp53HXEVkSpYoub+XYSTU8Rg=o1xxMJ8=5z8B-g@mail.gmail.com/ > Signed-off-by: Gui-Dong Han Applied. Thanks, Guenter