From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1211C64EC4 for ; Mon, 13 Feb 2023 10:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbjBMKbX (ORCPT ); Mon, 13 Feb 2023 05:31:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjBMKbV (ORCPT ); Mon, 13 Feb 2023 05:31:21 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BA0B9760 for ; Mon, 13 Feb 2023 02:31:20 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id h16so11588811wrz.12 for ; Mon, 13 Feb 2023 02:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pSJxkHq1/+KN60z3aJ0f+o2Ykzd3sm8k0tBtf9FSMJE=; b=CKd+sBizFSNQ1+ZIn8g6A0LAK470iKiLyeyeQpcnR6bzhPWIgu4B4zYI6bwjso9iMF 59mLEggSJYwJu/3t4b+5j6AZOZi/rh4PLHhDtgoJHJuFNFxE8dkQadBrt2q0bXyjVxeQ 79GpyYWKP+lhozeZyc7wv9WrBdJQb98YyWBo1SH7gO1FxqxACC/cTStZBZWt9IemEqdi O/wLNSqinUtHEOTsoQoRjZ2s7uP1Wm52008X0Zf/80QR77a4p+p7WGVeeKyEP6sLLJS4 y0K2Ax41Ml4Qj/VUaLt+rGOqzg5JzYi1SwixeiIE6+znKZrMoQKhsqTAbLO7GbVWC+Em rIoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pSJxkHq1/+KN60z3aJ0f+o2Ykzd3sm8k0tBtf9FSMJE=; b=tMovQxIULYNyMM2DuPcktoDxB4JbaS15VNyd58fobR8o9DXRNQNBeAiJIMRGmNi+LW YM9+CYBjFEGG30G6qnFCOxo1ZOfAG3BoZ4a39ezwSixfcp0K/br8+B6UNzVyoZ5ZciVg Ioxikq09YbQNp09+g4L87/qdZUWFBBPvfcfFZcQ+cbqLydWRAjTddDFykQAlUVsIkzd5 w5tCYM4XLthw7iBvUiSOGjT3D8oOlokNL9HbFK9DLkISQl9FF97nILhc/5kjLSeVrlHL 8PafcHbQhARWv3dzBnE4gMRZWGHMe5eRNRCWLeB17z15hpGh7dFYcC5r/YRWj+dwSuYc Vq8g== X-Gm-Message-State: AO0yUKUxJP+bVCBAvi3eN4X6Tq3qJBFP54bqOFt88wvqg2oqKXmyEoib 1K+fPH1BXgJEVtb/dWFBPkUJCEScz1hsWsQC X-Google-Smtp-Source: AK7set9j8KS4QQXEBoxZeDdEun+TnHWrN4d/TE+6xf2nqPRJUfN3Q/ADAMTx/jhK15FJvkzIt1BY5w== X-Received: by 2002:a05:6000:1d2:b0:2bf:b661:87d9 with SMTP id t18-20020a05600001d200b002bfb66187d9mr19719073wrx.50.1676284278636; Mon, 13 Feb 2023 02:31:18 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id p3-20020adff203000000b002c3f6d7d5fesm10261929wro.44.2023.02.13.02.31.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 02:31:18 -0800 (PST) Message-ID: <7bc0971f-86c4-2fb7-2b47-6bee93c02921@linaro.org> Date: Mon, 13 Feb 2023 11:31:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] dt-bindings: spi: conversion of spi-st-ssc into DT schema YAML Content-Language: en-US To: Alain Volmat , Mark Brown , Rob Herring , Krzysztof Kozlowski Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230210101403.14609-1-avolmat@me.com> From: Krzysztof Kozlowski In-Reply-To: <20230210101403.14609-1-avolmat@me.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2023 11:14, Alain Volmat wrote: > File st,ssc-spi.yaml replaces spi-st-ssc.txt for the > ST Microelectronics SSC SPI driver. subject: spi: dt-bindings: spi-st-ssc: convert to DT schema YAML is redundant, "conversion" of too long > > Signed-off-by: Alain Volmat > --- > .../devicetree/bindings/spi/spi-st-ssc.txt | 40 ------------ > .../devicetree/bindings/spi/st,ssc-spi.yaml | 61 +++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 62 insertions(+), 40 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/spi-st-ssc.txt > create mode 100644 Documentation/devicetree/bindings/spi/st,ssc-spi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/spi-st-ssc.txt b/Documentation/devicetree/bindings/spi/spi-st-ssc.txt > deleted file mode 100644 > index 1bdc4709e474..000000000000 > --- a/Documentation/devicetree/bindings/spi/spi-st-ssc.txt > +++ /dev/null > @@ -1,40 +0,0 @@ > -STMicroelectronics SSC (SPI) Controller > ---------------------------------------- > - > -Required properties: > -- compatible : "st,comms-ssc4-spi" > -- reg : Offset and length of the device's register set > -- interrupts : The interrupt specifier > -- clock-names : Must contain "ssc" > -- clocks : Must contain an entry for each name in clock-names > - See ../clk/* > -- pinctrl-names : Uses "default", can use "sleep" if provided > - See ../pinctrl/pinctrl-bindings.txt > - > -Optional properties: > -- cs-gpios : List of GPIO chip selects > - See ../spi/spi-bus.txt > - > -Child nodes represent devices on the SPI bus > - See ../spi/spi-bus.txt > - > -Example: > - spi@9840000 { > - compatible = "st,comms-ssc4-spi"; > - reg = <0x9840000 0x110>; > - interrupts = ; > - clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>; > - clock-names = "ssc"; > - pinctrl-0 = <&pinctrl_spi0_default>; > - pinctrl-names = "default"; > - cs-gpios = <&pio17 5 0>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - st95hf@0{ > - compatible = "st,st95hf"; > - reg = <0>; > - spi-max-frequency = <1000000>; > - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml b/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml > new file mode 100644 > index 000000000000..496118df3a1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/st,ssc-spi.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/st,ssc-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics SSC SPI Controller > + > +description: | > + The STMicroelectronics SSC SPI controller can be found on STi platforms > + and it used to communicate with external devices using the > + Serial Peripheral Interface. > + > +maintainers: > + - Patrice Chotard > + > +allOf: > + - $ref: "spi-controller.yaml#" Drop quotes. > + > +properties: > + compatible: > + const: st,comms-ssc4-spi > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: ssc > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + spi@9840000 { > + compatible = "st,comms-ssc4-spi"; > + reg = <0x9840000 0x110>; > + interrupts = ; > + clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>; > + clock-names = "ssc"; > + pinctrl-0 = <&pinctrl_spi0_default>; > + pinctrl-names = "default"; > + #address-cells = <1>; > + #size-cells = <0>; Messed coding style. Only one space before =. Best regards, Krzysztof