Re: [PATCH] mfd: stmpe: Support disabling sub-functions

[Marcel Ziswiler <marcel.ziswiler@toradex.com>]

Hi Francesco

On Wed, 2021-10-27 at 10:21 +0200, Francesco Dolcini wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> 
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
> 
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Cc: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
> Hello,
> the main reason for this patch is to allow enabling/disabling sub-fuctions

:s/sub-fuctions/sub-functions/

> using DTS overlay to enable more flexibility on SoM/Carrier boards

:s/boards/board/

> combinations.
> ---
>  drivers/mfd/stmpe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index e928df95e316..aeb9ea55f97d 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -1361,7 +1361,7 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
>  
>         pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
>  
> -       for_each_child_of_node(np, child) {
> +       for_each_available_child_of_node(np, child) {
>                 if (of_node_name_eq(child, "stmpe_gpio")) {
>                         pdata->blocks |= STMPE_BLOCK_GPIO;
>                 } else if (of_node_name_eq(child, "stmpe_keypad")) {

Cheers

Marcel