From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D62C433FE for ; Thu, 6 Oct 2022 14:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231710AbiJFOPs (ORCPT ); Thu, 6 Oct 2022 10:15:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231970AbiJFOPM (ORCPT ); Thu, 6 Oct 2022 10:15:12 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1F0CBCB2 for ; Thu, 6 Oct 2022 07:12:47 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id r14so2922848lfm.2 for ; Thu, 06 Oct 2022 07:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=n77JB3v5NQQWYXMjQE9mQos/CzAUaBxNKKkh7H62z+s=; b=LErqkYQ3SKuNYCFFC05liT3/69AynMf1KtPpKCZaBCGgTDRYRpQMD+PACtiHdUHNVI CvL7H/8TXvtFKsOimAKz9j64XVLhx++47eDDb4XoEJHNRQ4A1yei0XH+pHhZ/nuCbToP QnT6vhg+DQWa0u+MCmqLMJX7KlspTevR+QOJ/exQD7s+yqOU9jDMeonj0iIrBJ7dF6GK +XDbYeLQ9pUwvE+s97XqKmB3SsHEs5se1x5e6mSZGwuKp5/UvT+ejwzFzCpZXHUi4IEM rciTiYPNX+VBCe04KFWxwdPqiRhlwgi0aD3xSse+ZGkoUdleRcyiWu60qAEtHCBiWSAN 9ldQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=n77JB3v5NQQWYXMjQE9mQos/CzAUaBxNKKkh7H62z+s=; b=6M2ZmM9mXw5XjdxikbLIemFoC8RTuzOBKJWXZuepj9KUoyef8wRr5dOGzyPH+j/F1U hucCC84JuIFxwkiUV+QDODqQ6ePWG2/J1kk/AhiKxa28zJowV2Bn+FvU/SIlaZXUZ/3w YS+cQ8+BJ5yKa4Qg38PFG3tfAg9G1k529zp2XSvEKZMSmRFa26nwNLAr4+Ihsy1KMW+g 7g1ukHkuImJQB0a2MsZGNFMoDlsqD1pUT9HmNyq83KC6qU2UHryfHW6csUtfSkGVqsBM /17TgCsHoA8+Lnoc3xZWhNylQpDmirlmNNBCvUylnD6ZFqcR+LnlE2kOz5xeS560G8CI s+gA== X-Gm-Message-State: ACrzQf0It+eSvKZp0C7l3mk4a4/kQlkYlXB1okM4Qk61wcdHKefc3g4g ToqjNThcaPGnTcy1qjlfUiIetg== X-Google-Smtp-Source: AMsMyM4ylZPoyJycfqTxZLE/wBpDPIPW+NjZKnv18zVYR3Uj+em69HKE9roVPotUhNN1V5zutAzBpw== X-Received: by 2002:a05:6512:261c:b0:49f:af36:d47 with SMTP id bt28-20020a056512261c00b0049faf360d47mr65017lfb.284.1665065502063; Thu, 06 Oct 2022 07:11:42 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id be25-20020a05651c171900b0026c1cbbf461sm1922973ljb.80.2022.10.06.07.11.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Oct 2022 07:11:40 -0700 (PDT) Message-ID: <7bcb9ef1-6b56-2f5f-3ac9-acc9ed9370df@linaro.org> Date: Thu, 6 Oct 2022 16:11:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states Content-Language: en-US To: Amjad Ouled-Ameur , Krzysztof Kozlowski , Neil Armstrong , Rob Herring , Martin Blumenstingl , Kevin Hilman , Jerome Brunet , Mark Brown Cc: Da Xue , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221004-up-aml-fix-spi-v2-0-3e8ae91a1925@baylibre.com> <20221004-up-aml-fix-spi-v2-1-3e8ae91a1925@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2022 12:57, Amjad Ouled-Ameur wrote: > Hi Krzysztof, > > Thank you for the review. > > On 10/5/22 10:14, Krzysztof Kozlowski wrote: >> On 04/10/2022 13:10, Amjad Ouled-Ameur wrote: >>> SPI pins of the SPICC Controller in Meson-GX needs to be controlled by >>> pin biais when idle. Therefore define three pinctrl names: >>> - default: SPI pins are controlled by spi function. >>> - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled >>> by spi function. >>> - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled >>> by spi function. >>> >>> Reported-by: Da Xue >>> Signed-off-by: Neil Armstrong >>> Signed-off-by: Amjad Ouled-Ameur >>> --- >>> .../devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >>> index 0c10f7678178..53013e27f507 100644 >>> --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >>> +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >>> @@ -43,6 +43,14 @@ properties: >>> minItems: 1 >>> maxItems: 2 >>> >>> + pinctrl-0: >>> + minItems: 1 >> maxItems? >> > Will fill it in next version. >>> + >>> + pinctrl-1: >>> + maxItems: 1 >>> + >>> + pinctrl-names: true >> Why do you need all these in the bindings? > > SPI clock bias needs to change at runtime depending on SPI mode, here is an example of > > how this is supposed to be used ("spi_idle_low_pins" and "spi_idle_low_pins" are defined > > in the second patch of this series): I know what it the point in general of pinctrl configuration... But the question is why do you need to specify them in the bindings? Core handles that. IOW, do you require them and missing/incomplete pinctrl should be reported? Best regards, Krzysztof