From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227x0vq4KbZQX0Z0SXvkQzXuH1X2bNYnQuQDAOX8rX65lKbSixLvCaTfCe/N/iLtYkcGLSlW ARC-Seal: i=1; a=rsa-sha256; t=1517358007; cv=none; d=google.com; s=arc-20160816; b=OAv/1CdFW8ApGC4IVySalpjb4RHVK8fZre86xPOSAB9kLlnmuz/GI2E2QUk6W78vaI Aebk0w8NE0D2pzVgM+tbXEKzKKvfoK7f8rNE1X6Cjqmyfevy56qf5S6D/ZrgUhuyQIti Lvu/DtP+9SskU2wuJGS+oMt5aHfgdEp0o8EBtQcRoe8VswxgN9giDgHAGDl2KcmJW+RK E5vn/0uw57+6+3e3xA9l+do2jmipS9R9kPnkKn6Hn+we6GNqzGTMo8WXF/e/NGWMC+zR TRuBYUYRuGe4moGxCoyC/vEM19pifTgPSeV5DsBYchz0s5EOWfSQwSU1ieKMizfu7IRu KkQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=w61tDjBuNYGUxbjzYJBagxl+sbAHpIH3Cd2tNZEcITo=; b=pRKX+7EucBgGUCOG84f4M9o/UH9UHTLyPTSTKsKik6Ql9t+EOI/ZDAQu20h7SI4BM7 ELWbHP4tqZk+Wx5quSyKuqQ16WWQEddoRjKuTfO02Z2ZI2RuISNrdmzdlWmGzLwLrMU7 5DPdjYfXDEg+zUnfRR68j+1b3sWTLAxkpusUG+NfgG4anNaNZBklP5rd8mFTGYl1lTQE QxB1acxdEoYS/M9SaE9JFQ7/9G/jHTQvKXMOyN/93Nzs3URss/fBbrxbh12jHAP4hBg3 FgR8MgNK68YX8STEid0FnqSLvuXTr1wfV4KO/JU42BGV3DMoi4SLbJ7RPIxBl66wOuTH XQdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of pbonzini@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of pbonzini@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Subject: Re: [PATCH v3 4/4] KVM: VMX: Allow direct access to MSR_IA32_SPEC_CTRL To: KarimAllah Ahmed , Jim Mattson Cc: KarimAllah Ahmed , kvm list , LKML , the arch/x86 maintainers , Asit Mallick , Arjan Van De Ven , Dave Hansen , Andi Kleen , Andrea Arcangeli , Linus Torvalds , Tim Chen , Thomas Gleixner , Dan Williams , Jun Nakajima , David Woodhouse , Greg KH , Andy Lutomirski , Ashok Raj References: <1517271028-15916-1-git-send-email-karahmed@amazon.de> <1517271028-15916-5-git-send-email-karahmed@amazon.de> <43859417-ae76-ed1f-eb4f-8a84a35998fc@amazon.com> From: Paolo Bonzini Message-ID: <7bd999e6-bc15-2470-80fb-771161df39d6@redhat.com> Date: Tue, 30 Jan 2018 19:19:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590974131114135545?= X-GMAIL-MSGID: =?utf-8?q?1591065189412103414?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 30/01/2018 18:50, KarimAllah Ahmed wrote: > On 01/30/2018 11:49 PM, Jim Mattson wrote: >> On Tue, Jan 30, 2018 at 1:00 PM, KarimAllah Ahmed >> wrote: >>> Ooops! I did not think at all about nested :) >>> >>> This should be addressed now, I hope: >>> >>> http://git.infradead.org/linux-retpoline.git/commitdiff/f7f0cbba3e0cffcee050a8a5a9597a162d57e572 >>> >> >> +               if (cpu_has_vmx_msr_bitmap() && data && >> +                   !vmx->save_spec_ctrl_on_exit) { >> +                       vmx->save_spec_ctrl_on_exit = true; >> + >> +                       msr_bitmap = is_guest_mode(vcpu) ? >> vmx->nested.vmcs02.msr_bitmap : >> + >> vmx->vmcs01.msr_bitmap; >> +                       vmx_disable_intercept_for_msr(msr_bitmap, >> +                                                     MSR_IA32_SPEC_CTRL, >> +                                                     MSR_TYPE_RW); >> +               } >> >> There are two ways to get to this point in vmx_set_msr while >> is_guest_mode(vcpu) is true: >> 1) L0 is processing vmcs12's VM-entry MSR load list on emulated >> VM-entry (see enter_vmx_non_root_mode). >> 2) L2 tried to execute WRMSR, writes to the MSR are intercepted in >> vmcs02's MSR permission bitmap, and writes to the MSR are not >> intercepted in vmcs12's MSR permission bitmap. >> >> In the first case, disabling the intercepts for the MSR in >> vmx->nested.vmcs02.msr_bitmap is incorrect, because we haven't yet >> determined that the intercepts are clear in vmcs12's MSR permission >> bitmap. >> In the second case, disabling *both* of the intercepts for the MSR in >> vmx->nested.vmcs02.msr_bitmap is incorrect, because we don't know that >> the read intercept is clear in vmcs12's MSR permission bitmap. >> Furthermore, disabling the write intercept for the MSR in >> vmx->nested.vmcs02.msr_bitmap is somewhat fruitless, because >> nested_vmx_merge_msr_bitmap is just going to undo that change on the >> next emulated VM-entry. > > Okay, I took a second look at the code (specially > nested_vmx_merge_msr_bitmap). > > This means that I simply should not touch the MSR bitmap in set_msr in > case of nested, I just need to properly update the l02 msr_bitmap in > nested_vmx_merge_msr_bitmap. As in here: > > http://git.infradead.org/linux-retpoline.git/commitdiff/d90eedebdd16bb00741a2c93bc13c5e444c99c2b > > > or am I still missing something? (sorry, did not actually look at the > nested code before!) The new code in nested_vmx_merge_msr_bitmap should be conditional on vmx->save_spec_ctrl_on_exit. Also, guest_cpuid_has is pretty slow (because of kvm_find_cpuid_entry); calling it once or twice on each and every nested vmexit is probably not a good idea. Apart from this, it looks good to me. Paolo