From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752393AbdHRTJd (ORCPT ); Fri, 18 Aug 2017 15:09:33 -0400 Received: from mout.web.de ([212.227.15.4]:57902 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdHRTJc (ORCPT ); Fri, 18 Aug 2017 15:09:32 -0400 Subject: [PATCH 3/3] jffs2: Adjust a null pointer check in two functions From: SF Markus Elfring To: linux-mtd@lists.infradead.org, David Woodhouse Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <7be00642-75c6-f774-49f8-51a264b3404d@users.sourceforge.net> Date: Fri, 18 Aug 2017 21:08:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:IwRfdLi28EKLdHnEYbn38UECZBOrKFSdngnh6BLAyE/iiJr76rD jwct5y/bY8WFg/GEf4utvDEyqA3cgSP9uFT+z3e24Vm3BmK+j0uAUGAp37mWdwkloqaf4Hz YhFGEqzOc+FIlpcDYvmaOTu/oWf5vwd23XaA8wUvFFEcDCnzD95GHP+Po8GtWU6hni6s1HA 4e1U7/25vIepK9mh+GnZw== X-UI-Out-Filterresults: notjunk:1;V01:K0:oStaRgnrlR8=:V1RvJnN6jFYXKNgGjuGimX yne/qQwCVo4ccqkzGk6QzEeaUyVG74Hukr9EvcG+qdyv+/x7vSTS1oWwcgFcudmrkbMQGb9Kq 2Ag7aZMES+ZIPta+Zh08fZLPdXFdodWTOSL+oj52Ib5qtKMD61R3kT3nhWiLOZdzn+PnODbDq yvJ6A1I0RkJPuOjZS60yoPZKkVv+f+JhOr0Q5O/1uk3TeJiaMLf+mFDTI+CqKHh7x76glt+Rg tI1qe3GzQ1tkxETYNq0c0owWEBUjQOGqcqVTAhVC6C3+wZO4CMxyh7UjjH1nJjIz2KBBiAHfQ Iaxwx11PDiTDweILxheFbTUjeqXvBYYKwL6efBRpoTecLHVqnVnGTcs+wgqcQnqF1EPBlbDZu UjeicJlCMTn09uX653QRCMDDa4vqqDbjMaN/qVl/0E6OYKv+w0QJcSD5mB6hVdJdfYc0dzcb4 2uSe5/BiDo4FNk6EzL7Y8/k+d3HuAL0ZnCggLR+qoV8RtnAO/WGPhbvIzTJz1rWi96eUe+u9y /e3AoC7XntAW74IluuRFk+JTKwzA33EIs3MOqaSI2LDmFQvL30sCoyIEbj2bt7SuD93GW/Bgh fh98Z1zKL3jMN7C6G4wu+ELfHsqaWp/2ZF7jYL5cTwVcyTo1EwvwIqeTZ2DeagHqiM/XuVK1a +h4Ht4pXYey7iNeU7XvZDkCAHVEY3UywsJpz6JIrIotBzrLBGc0u24zNWqu/a7Bb/9PrrbOsk L73E7DxeHye8WAPxw8Z1LAPgPP6c7Br9+w3q4UOb4t3q68INlBoiHu/EMpXofIUsXJV9smdYo TJSQsX6t2fjKWpT81r/8b8uST45Vi0IaAahSB66Mtq7WvqSwTc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 18 Aug 2017 20:40:35 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring --- fs/jffs2/nodemgmt.c | 3 +-- fs/jffs2/security.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/jffs2/nodemgmt.c b/fs/jffs2/nodemgmt.c index a7bbe879cfc3..d5346ba782f7 100644 --- a/fs/jffs2/nodemgmt.c +++ b/fs/jffs2/nodemgmt.c @@ -242,8 +242,7 @@ int jffs2_reserve_space_gc(struct jffs2_sb_info *c, uint32_t minsize, static void jffs2_close_nextblock(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb) { - - if (c->nextblock == NULL) { + if (!c->nextblock) { jffs2_dbg(1, "%s(): Erase block at 0x%08x has already been placed in a list\n", __func__, jeb->offset); return; diff --git a/fs/jffs2/security.c b/fs/jffs2/security.c index c2332e30f218..9859b522721f 100644 --- a/fs/jffs2/security.c +++ b/fs/jffs2/security.c @@ -29,7 +29,7 @@ static int jffs2_initxattrs(struct inode *inode, const struct xattr *xattr; int err = 0; - for (xattr = xattr_array; xattr->name != NULL; xattr++) { + for (xattr = xattr_array; xattr->name; xattr++) { err = do_jffs2_setxattr(inode, JFFS2_XPREFIX_SECURITY, xattr->name, xattr->value, xattr->value_len, 0); -- 2.14.0