From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744C319CC32 for ; Fri, 1 Nov 2024 12:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730464170; cv=none; b=RhFPZeP2dz0daxW9n2BfgZSVt9Q7SvwcmO2bQ+8738wk62dPF0FzJIZGQHFye06/yZ+TF7jQKDnoky0LSa5ud9mdzIcaHeoSbcg6rg8WAuwCXQdU1bhpmYMIAA9kiVIBm2SiqlBbjRAqxpFnMymf++6Ki+HG6Oup9Vf/LK8k7cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730464170; c=relaxed/simple; bh=LfkUxi30J7XZTgC+jEuHIwl8b+Zfd3uc3w+dbK/9Uss=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JBLY9poLsUTy0bCNFCK3dmNdL+FNHoe0OO804RqiOZqdllqBtcpk6riBLcrGj3f2JCISwCNEoUOrYVgNuXVs+1mkfPb4zXT1XiOMWtVgrL3Gs+b3wrWg2nwQCq79oOUpobT3AoS8iNMS05NFdPMw+hViKI6J0sdtdIWQLpvdiXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xdH0TcYZ; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xdH0TcYZ" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-37d808ae924so1086344f8f.0 for ; Fri, 01 Nov 2024 05:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730464167; x=1731068967; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6PYW2VODU+6ARkfOsKMX9HiT8wjTVrQXTg+TMoq0+tk=; b=xdH0TcYZXLSOgycmYCeVtfz7T2HP+D5xDSUlUqkgvahpqIser0DzGGkeaaCG29mDRj 8kTGP0umKMlh5DRXmBmRxG7+a9nFozGjVt9+UxYevzjqgXL4wAoPFT1/+lYb4bxioFDr qdU64qSES4EVgBLgI1u41W4E0y1RllrOozl94MaMDxEBVa6h4djreY+IsIn/n9w0PEBj DjEvy43H8hDH7kiHIhVvg62RSw8G0decDybb0fVqsg9ZRgZlSwvwZFZAZ6v5oN8igjcB p+vaISDIN3JFle2cryIjxt/GuYEyhPwwrg6+d7ZUVExaC842TdJuGBwAQVSajswpnknU kq8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730464167; x=1731068967; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6PYW2VODU+6ARkfOsKMX9HiT8wjTVrQXTg+TMoq0+tk=; b=vPNHcA6oT7zlHsJXnHWHKvZWBZodJh9z0ce8ijL5oeQ1nISk3YhYcS/lTEl8eEg/vg Bps50C0ppiSS14iXDMTRvvzaJbtW+tv1cx8/Zw+cqwkxjkRa6ZabxhZG6nGoYqRsEMEe FgPhrNRx6gbydo5cHhVTq/zUp01c6SnbYO/HkNPgV4M1omx1I9PoIH7CCI7SBaSqvoJh VVkbG3HgrfardlagcwOqebYXaQdCjRjIiFW6xDWqL8MPtAgTkX4VUMGZVBdU+grO+U6h Jf4SZHuWTdw1oeqb18MIRulnilbgdDtT1aR52kBfruZuuvKNyWsIdHSr1+oLU+/bCHw+ gNow== X-Forwarded-Encrypted: i=1; AJvYcCXQHoJ/U2X88f059np1KG4/pj+pLXGFCwNHj0tbpZrWoovr4NacPzPE1V1goEiacsrdKMyLsyU6huN3+18=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1SFhjmweXoxHQ+hW1V3RIUggRVuPpvaw8CzU6vIP2M91lB/hu cAJIOppmqskpp+xcHqH7JYPqZP9+17UgfHsZFj+vY/MfHvlZ2BNxoaOZxzLi7CQ= X-Google-Smtp-Source: AGHT+IEexgLpdNZzNx7qKEixOWvz0WoBXAOf4WpMS8azuyv76BwBUIhQnnmrQYq6kNbYJFzHI4wWCA== X-Received: by 2002:a5d:4fc4:0:b0:37d:52e3:e3f0 with SMTP id ffacd0b85a97d-38061200becmr16575623f8f.44.1730464166764; Fri, 01 Nov 2024 05:29:26 -0700 (PDT) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10e734csm4981745f8f.60.2024.11.01.05.29.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Nov 2024 05:29:26 -0700 (PDT) Message-ID: <7be231c6-a5b6-41ec-b43d-cbba07e7c448@linaro.org> Date: Fri, 1 Nov 2024 12:29:25 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver To: Taniya Das , Michael Turquette , Stephen Boyd , Bjorn Andersson , Abhishek Sahu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20241101-qcs615-mm-clockcontroller-v2-0-d1a4870a4aed@quicinc.com> <20241101-qcs615-mm-clockcontroller-v2-4-d1a4870a4aed@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20241101-qcs615-mm-clockcontroller-v2-4-d1a4870a4aed@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/11/2024 10:38, Taniya Das wrote: > + .vco_val = 0x2 << 20, vco_val = BIT(21) > + .vco_mask = 0x3 << 20, Instead of bit shifting couldn't we just use GENMASK ? Aside from anything else shifting a hex value by a decimal value isn't the clearest code in the world. vco_mask = GENMASK(21, 20) Much cleaner. drivers/clk/qcom/gcc-sm6115.c Same comment for all of the bit-shifts in the series, I appreciate the shifts are what the downstream code does but BIT/GENMASK does this job better. Once fixed you can add my Reviewed-by: Bryan O'Donoghue to this file --- bod