From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762806Ab3ECIdY (ORCPT ); Fri, 3 May 2013 04:33:24 -0400 Received: from smtprelay02.ispgateway.de ([80.67.31.29]:37352 "EHLO smtprelay02.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761195Ab3ECIdV (ORCPT ); Fri, 3 May 2013 04:33:21 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 May 2013 10:33:13 +0200 From: Dirk Eibach To: Guenter Roeck Cc: , Kumar Gala , Wim Van Sebroeck , , Subject: Re: [PATCH] powerpc: Make Book E watchdog reset type configurable In-Reply-To: <20130503011741.GA23266@roeck-us.net> References: <1367505913-18970-1-git-send-email-dirk.eibach@gdsys.cc> <20130502161720.GA7797@roeck-us.net> <429ec64cf7c30a139db40eb20fd3e682@gdsys.cc> <20130503011741.GA23266@roeck-us.net> Message-ID: <7be2cb3417615ff206270a756c6422d6@gdsys.cc> User-Agent: Roundcube Webmail/0.8.1 X-Df-Sender: ZGlyay5laWJhY2hAZ2RzeXMuY2M= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, >>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >>>> index e89fc31..6048593 100644 >>>> --- a/drivers/watchdog/Kconfig >>>> +++ b/drivers/watchdog/Kconfig >>>> @@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT >>>> >>>> The value can be overridden by the wdt_period command-line >>>> parameter. >>>> >>>> +choice >>>> + prompt "PowerPC Book-E Watchdog reset type" >>>> + depends on BOOKE_WDT >>>> + default BOOKE_WDT_RESET_CHIP >>>> + help >>>> + Specify what kind of reset will be executed on watchdog >>>> timeout. >>>> + >>> Seems to me it would be much better to make this configurable via >>> platform data >>> and/or device tree. >> >> good catch. What do the device-tree gurus think to be a nice >> property name? having a closer look, I realized booke_wdt is not device-tree based yet. Migrating it would come close to a rewrite, breaking compatibility for all current users. Sorry, this is way beyond the time I have for this project. So I suggest merging the change the way it is, as it is clearly an improvement. Cheers Dirk