mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiaoming Ni <nixiaoming@huawei.com>
To: Kees Cook <keescook@chromium.org>, Peter Zijlstra <peterz@infradead.org>
Cc: David Windsor <dwindsor@gmail.com>,
	Hans Liljestrand <ishkamiel@gmail.com>,
	Elena Reshetova <elena.reshetova@intel.com>,
	"Paul Moore" <paul@paul-moore.com>, <edumazet@google.com>,
	<paulmck@kernel.org>, David Howells <dhowells@redhat.com>,
	<shakeelb@google.com>,
	James Morris <jamorris@linux.microsoft.com>,
	<alex.huangjianhui@huawei.com>, <dylix.dailei@huawei.com>,
	<chenzefeng2@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t
Date: Mon, 15 Jun 2020 10:10:08 +0800	[thread overview]
Message-ID: <7be4d56b-0406-099b-e505-02e074c5173e@huawei.com> (raw)
In-Reply-To: <20200612183450.4189588-1-keescook@chromium.org>

On 2020/6/13 2:34, Kees Cook wrote:
> This series was never applied[1], and was recently pointed out as
> missing[2]. If someone has a tree for this, please take it. Otherwise,
> please Ack and I'll send it to Linus.
> 
> Thanks!
> 
> -Kees
> 
> [1] https://lore.kernel.org/lkml/20190306110549.7628-1-elena.reshetova@intel.com/
> [2] https://lore.kernel.org/lkml/1591957695-118312-1-git-send-email-nixiaoming@huawei.com/
> 
> Elena Reshetova (3):
>    nsproxy: convert nsproxy.count to refcount_t
>    groups: convert group_info.usage to refcount_t
>    creds: convert cred.usage to refcount_t
> 
>   include/linux/cred.h    | 15 +++++++-------
>   include/linux/nsproxy.h |  7 +++----
>   kernel/cred.c           | 44 ++++++++++++++++++++---------------------
>   kernel/groups.c         |  2 +-
>   kernel/nsproxy.c        |  6 +++---
>   net/sunrpc/auth.c       |  2 +-
>   6 files changed, 38 insertions(+), 38 deletions(-)
> 

Should mm->mm_users also be replaced by refcount_t?

In addition, is it better to change all variables that use 
atomic_dec_and_test to control the release process to refconut_t?

Thanks
Xiaoming Ni


  parent reply	other threads:[~2020-06-15  2:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 18:34 Kees Cook
2020-06-12 18:34 ` [PATCH 1/3] nsproxy: convert nsproxy.count " Kees Cook
2020-06-12 18:34 ` [PATCH 2/3] groups: convert group_info.usage " Kees Cook
2020-06-15  0:57   ` [groups] 67467ae141: will-it-scale.per_process_ops 4.3% improvement kernel test robot
2020-06-12 18:34 ` [PATCH 3/3] creds: convert cred.usage to refcount_t Kees Cook
2020-06-15  2:02   ` Xiaoming Ni
2020-06-15  2:10 ` Xiaoming Ni [this message]
2020-06-15  3:55   ` [PATCH 0/3] Convert nsproxy, groups, and creds " Kees Cook
2020-06-15  5:35     ` Reshetova, Elena
2020-06-15 18:08       ` Kees Cook
2020-06-18  7:39         ` Reshetova, Elena
2020-07-21 11:02         ` David Howells
2020-07-21 10:51   ` David Howells
2020-07-21 18:44     ` Kees Cook
2020-07-21 19:51       ` Peter Zijlstra
2020-07-28 10:56       ` David Howells
2020-07-29 11:11         ` [RFC][PATCH] locking/refcount: Provide __refcount API to obtain the old value peterz
2020-07-29 11:37           ` peterz
2020-07-29 19:29             ` Kees Cook
2020-07-29 19:30           ` Kees Cook
2020-08-27  7:54           ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-09-21 11:22           ` [RFC][PATCH] " Will Deacon
2021-01-26 11:25           ` David Howells
2020-07-29 20:41         ` David Howells
2020-07-29 20:52           ` Kees Cook
2020-07-28 11:01     ` [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7be4d56b-0406-099b-e505-02e074c5173e@huawei.com \
    --to=nixiaoming@huawei.com \
    --cc=alex.huangjianhui@huawei.com \
    --cc=chenzefeng2@huawei.com \
    --cc=dhowells@redhat.com \
    --cc=dwindsor@gmail.com \
    --cc=dylix.dailei@huawei.com \
    --cc=edumazet@google.com \
    --cc=elena.reshetova@intel.com \
    --cc=ishkamiel@gmail.com \
    --cc=jamorris@linux.microsoft.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shakeelb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®