From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CC4335074 for ; Thu, 4 Dec 2025 10:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764842668; cv=none; b=UI1dJnDdr/fWiBgOqywCB+2U1Jwc3LkCsW9cUceNPLIqUUuNU9+Vy39YFPhUyjHgd254GiRU+YNRW3w/aEFAVTgaLUWBAp9jOLWBJ2/vPb2KOTFBfvTu18QUoYpqpWUaB3hDaJubWUruKJaoagzla2whKGfzOwlDvomW7NP8wKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764842668; c=relaxed/simple; bh=NkGy5Yxav+hxu5WxRgjThmTZ5m0bK0FqnEpQGAWdXWE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Iid/7G+s/AGDwqYRzOrnrhi67+TQ1W7vA1mHA5OxKBDyLHHZveOXhdBLizDcsLgECiK4wGwvUKDrmwDRVz7aoWec2/fdCFh6+QK6jQEMs3uNgE1HpijU6DmSiojoXhsXEyRTmHd6NU8aJtls/BLtSTs3PN1Ei+VpZk1HbpdG7VU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MP26kmnm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Eg/kfJ0A; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MP26kmnm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Eg/kfJ0A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764842665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jYJIwmIzAHmgYcwAHqAyW0oXzjS8vsesR3EEDMcroX8=; b=MP26kmnmGLttWZzboeQSGrRU5VRx+7AuLiEOdhVHvfXQa9Vyo8JvXjqAzBNB55DyeDc+7N lHeSdFmElYRGDHVtgaApGSdtjkfrHrelqlEKgIjQQaY5GfZBI+aO+tRPCzy/B3/QOnEh3L Uo7pSJnoeLnFUmcUyYUeeOeQlOmnJ8E= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-uNdhOJJ8MfGrLn1zuDeZQA-1; Thu, 04 Dec 2025 05:04:22 -0500 X-MC-Unique: uNdhOJJ8MfGrLn1zuDeZQA-1 X-Mimecast-MFC-AGG-ID: uNdhOJJ8MfGrLn1zuDeZQA_1764842661 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477cf25ceccso5342295e9.0 for ; Thu, 04 Dec 2025 02:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764842661; x=1765447461; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jYJIwmIzAHmgYcwAHqAyW0oXzjS8vsesR3EEDMcroX8=; b=Eg/kfJ0ALXJT/PXWpmHyLdK3n13XQ4cMgMCzjWcG7f7wYXua3Wm2Y3tB5hXu+Oub1L xopAsZUysi2IwFWePLtNOeCQ/wRyJGo0eNAO+10emZ9i3VxKGouN6STizy3RvBKa3oHl C4fP3m9DPjmmGvtYzvAfNVTRzSknVOqAjsxdRCkPnzi7ook6xWGHNoUWrjQYWQDoazcY gVdE2vz0XZmFbakCwydGXPdrHfFB7ciLYwelZs7AV9WAhb7CqOG7Q7zFDtSHlFJ7JR1K 6gUPsaYQ2/ruGTJQuqTRgwnryUh3nKF2PLDD/To1RuvJSWcRHaLvVUdNlm6EsbMvdkKf 0SzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764842661; x=1765447461; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jYJIwmIzAHmgYcwAHqAyW0oXzjS8vsesR3EEDMcroX8=; b=sMhDMVEC/YEJcepD9KdnPyg3VVKPveiq/ra7grqcgac190NY49YmbeSLoMEXs9fT2w HfqfCFmn+dY1xtORHSXQY1x1t4s+5bpcr23J41hRFtH/8w7gh6DJswJiPFoV4QpohZD8 EZWrav1PXkRiuawTqO4T4A6EBP6jCXFg7vhp9AzapaAdhmBvltlX/QUhhfm4+0JduPo7 Xlz2HUFUpW8Rt72dVFnUWGzEwdb3R24yJmcdunKilwL2UIUbwO1VROj5cuH+YEpvEIO/ Cuwcc5fKFcjtFi4af/UtLpKoav5k+wVOd6QOqSeLGCAntri+saiggkrZ8QRtnUGFJa3f JfxQ== X-Forwarded-Encrypted: i=1; AJvYcCWTCNMc+LuHtXtyeIAAeEVtW8lQZhIqipNXpRgNyAObCWqzNqUv6aW6cvBDA4Wf68V5Jbx0nykjNuGC3m8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7g0XXZTTqmpz4k6FBo82Y4DUcexcudxjzdPuUqAm+SpC7O3+B fzYhNRo6IeG0gsCM/WR8ud5WPCh5xfG3sZeQFSv23OzowcPvYAZ2pdTc82Rrp9fSE77tohGY4bY SrQ2e//9VYn/LGTgxbBgNfKUA73dRcrEuroQZLaMI3lO0+cX9CEouITxdJ9lWAGxl/w== X-Gm-Gg: ASbGnctJehMD3mcX64HlXmT0UYmBUTGmKwvgrkwibv7/O5fPyGgGiKgI5oyZKKHcXlo lubfArO702YR6kIGemXj2Q225PS67/MBrSm1RUtlLtS8C/DH+NhXN5YFSlALRCKIem5Bw8TTK+o B/bLjjOp8cPwAlthDZ3Pfo9Xb38loKrcl7cqfwVyL6t3Dim3284LK6WFdxhOSC0ojkkF0nH/oLO /xKn3V57JBgmmqhe7nbj/G4mRLNqxQJle7GOiXXcjkzcRUlagqC7My3iiLyNqRawzKsqJB81jTc 6FUiIEDDUIFpasF5bycMfXVzu7nCmLAK4BXqCCU2t3BAA/bAtxMHqLI6mu2SyBqvRGnQWUoAUjJ zdb6f8Lkxu3zV X-Received: by 2002:a05:600c:3b1f:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-4792f386f92mr20088195e9.20.1764842661086; Thu, 04 Dec 2025 02:04:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtlgpbU3wPzpHckIiNG7MkxJnSSWwzko1ByQE61szhPF3nugo4abw7JPrLtUp1XhZD817+Jg== X-Received: by 2002:a05:600c:3b1f:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-4792f386f92mr20087785e9.20.1764842660674; Thu, 04 Dec 2025 02:04:20 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792b12411fsm42744815e9.3.2025.12.04.02.04.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 02:04:20 -0800 (PST) Message-ID: <7bea2244-dc28-4c67-b515-739b8b7d7901@redhat.com> Date: Thu, 4 Dec 2025 11:04:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: netrom: fix memory leak in nr_output() To: Wang Liang , Deepanshu Kartikey , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+d7abc36bbbb6d7d40b58@syzkaller.appspotmail.com References: <20251129034232.405203-1-kartikey406@gmail.com> <17e41b73-3497-4ea0-b91c-4710514f7b14@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <17e41b73-3497-4ea0-b91c-4710514f7b14@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/29/25 5:01 AM, Wang Liang wrote: > 在 2025/11/29 11:42, Deepanshu Kartikey 写道: >> When nr_output() fragments a large packet, it calls sock_alloc_send_skb() > > Hi! > > Coincidentally, we both are working on this issue simultaneously. > > From the syz test requests: > https://syzkaller.appspot.com/bug?extid=d7abc36bbbb6d7d40b58 > > I sended the test patch earlier, only a dozen seconds... FTR and future similar cases, we don't have the send time information handy. Instead we use the timestamp as available on patchwork. In this specific case Deepanshu's patch landed first, but does not apply cleanly, so I'll apply Wang's one. Cheers, Paolo