From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754893AbeARLhd (ORCPT ); Thu, 18 Jan 2018 06:37:33 -0500 Received: from mail-by2nam03on0071.outbound.protection.outlook.com ([104.47.42.71]:52192 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750724AbeARLhb (ORCPT ); Thu, 18 Jan 2018 06:37:31 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo To: Dan Carpenter , Michal Simek , Dhaval Shah CC: , , References: <20180118102823.GA21064@mwanda> From: Michal Simek Message-ID: <7bea45bc-a684-3c6e-c818-c2428a5990b5@xilinx.com> Date: Thu, 18 Jan 2018 12:37:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180118102823.GA21064@mwanda> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23604.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39380400002)(39860400002)(396003)(376002)(346002)(2980300002)(438002)(199004)(189003)(31686004)(58126008)(83506002)(316002)(106002)(50466002)(54906003)(110136005)(5660300001)(65956001)(65806001)(106466001)(64126003)(63266004)(966005)(47776003)(478600001)(36386004)(6306002)(6246003)(305945005)(230700001)(229853002)(9786002)(356003)(77096007)(36756003)(26005)(4326008)(76176011)(81166006)(81156014)(53546011)(23676004)(2486003)(2950100002)(6666003)(86362001)(8936002)(65826007)(6636002)(8676002)(2906002)(31696002)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB1332;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT041;1:HnApZdY50qTT8PBPwKX5MigKMMXp+dZ+u/9KVG9AcOtan/tKzqZYPqrSUctH6PQzMrN0FLpz/zumm4ytMhhIQqlAgMSymUdNYJfKnERw6rUypPI343RhYCARiRqiA4mJ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1d45a2a7-6f68-49ad-96eb-08d55e67da59 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4608076)(2017052603307)(7153060);SRVR:BY2PR02MB1332; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB1332;3:jhIz13G67NTTTWb0laCrx8VigIXmafLTMPvDkER4vKwF1JYpv/pCng6s/tq/+zDpjUpWtdfflHTDIC/41rh/HF7sdIptPniYK9vqoc85pTMdLnDSAyFqkTvazICvM8r/YAEOYoobn4DVsbjend8h/Jvn+lbFWuE2RxrYPVKfFAwQ3KUyswVIjw9oFm0F/PBhH1lrrL2kZUP1jItZ6Obnj36n+FPoCcO9fo+PuSdod5Hds29BVstdhRhWiF1JYQRIRC8rreawitJcFz2xgmltAKXsy/FaGyCMkkx6cilvM3HP3QbY7fK8Nv9F3E7p7U2ijfzgrYIrMIvk9tp6wkRnnE8NVook9qKNqNwdjC0yClo=;25:7ul/+5sbuZadfXtvCMGrmbOfxca7wo0iLcmJI86jWlcCMK7SJ6cWfV8c1zl9ZeRpXlWO3GSaowxSXXJhHyMK7T7ECdKZlogIJnQ5MYDWTAHwpZbDMHOLK242qD1cmzqbco8ZwodVOkLdJaxwbRX0RJ+QjQ9jwkpeHHInOK5QjAMVPPPHSxm5NsxxHoCKrOCSPxXSEaeRqNnEYgIvbqZf6ZHNZ09h1HOgOSjx/Bl8+RIGeDFYuR+1XeQ/Jx2pv28ZERqj1PFmZnMCybRuWXoXdZGZYIA8XPpDMPhupj6RrDIzicxIk8qFKA7IUE+B9s/79+cBi/xqnCIdI9ui9IrqUw== X-MS-TrafficTypeDiagnostic: BY2PR02MB1332: X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB1332;31:oADGez0tadB+cD2YUwSxESXI9bRGRjszhn7dwDNmsb2kIA1OLamVbPf3tydrS1HXwbgH2385NbK6yC4b1eX0srzrJ3bCKvVc6X0LHXGIo9KRrCZcZj1yQ1VDc6Cbr5XlmZEj72CZVC65uhsfagvjhL8kyvf3lu605zmn+yqGodQDURwvEsxGnu49GC7jnVJ4/hcOuHDPtQJb+isuHjO1bVoN7Q0Z7+WkIxxhhBysFMM=;20:BTTqLN4LVvLxcnctSxe6+JxayBtTICQ0/zlnlPGBAW8N7UyndcEkyZw7ORTqLocX+w8mlBaVNba7S92v/edhk4ohxmIyNnVsnnhFaWkHwJmHAvqn7F7Katb+mvEIo08vWZ/N7e9poKTSHgWRvx3vDjf3ki4CYvlXuR+wnDdR7xbSzhHprpHVna0sCHn/1nrJIHOzMipB2ri1kI6a6H1G2jVGXp6VR4tcs184PI0y5Hg2PBef0W5aQCGnacd5AtUiy1kab9f7oeln8qGaRvJjm20muv6hxUNzXG87LVuAFkskQIVGfTGuwdK49DeOCOD1DnhgGK6XXcR5kcFKDoT39L7Na+6m0n1a+X2O5P24JQhg9ornBAKStjA5b9iCaENwFHgKvjanWFQze5+Hcs8/t07vy+OAEFtctE8XppL+a67J0WbNHhGXsS5fhPFHAtZMhD/bForgoNDgdptgBTziAv/vWPk/KpzTQBwnfxSnRUoqLI+PjrRoRRZfFQp1fhfe X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(3231023)(2400061)(944501161)(93006095)(93004095)(10201501046)(6055026)(6041268)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011);SRVR:BY2PR02MB1332;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BY2PR02MB1332; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB1332;4:v/11kaN3p/FEAVObe4CvEHbzuXuyt7G/1xP0BAmgPAhIxtbH4ePZfYRSWeWWT6Crq1skHgwwmg++t+TtRWD3x3DNRdkpWAHe0BeTPoD2xK3RaSXUFGgaQkET9cPKR26i1nfCP505HNyAlol5fBZTImdbn57dhC4AMn2fg+kzzFFoONntKGIDgExwV2c9+Be2cZVMTGToNSOBnuzPgDGVcaWp55uY3lDqrab4TTB30501KNVc3JD9NV7z87aO8q7z0d11oMI1/0B+dVpIL5amjDvLo1AbNKVkhJjqRyBEhXHk1BbyeTiuIcTF6UkOEExU X-Forefront-PRVS: 05568D1FF7 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAyTUIxMzMyOzIzOkJlQ1VKeUJBelZ0VTlUSDIwRWVtY0l5aTJG?= =?utf-8?B?NkhURXRVSkdqb0JCMk1YcDVuUXRHcmdYeHd5RXNXRjlvN0tGTUJvdzlGd2pl?= =?utf-8?B?NHJPYmN3bHVhS0RXMUNoWWNjNDRjTGxWNHV5TTB2bStWdVZHWDhKMXRWK2NB?= =?utf-8?B?RUYxaWNlQlptWnFuVit1QnQrREtqdDk2U2ZJMnpjeVN1d2JZd2lvRlhhbGY3?= =?utf-8?B?YWh0VTVYNmp1aUJRNHc5OVBmVWJPc1pBVEVod2NkanJRYW1zTi84VW5TV3dK?= =?utf-8?B?WXRpOU5UU1VXRUE0cmlMOVVEQUtBekhZcDg4cWxzVWcvNEFVNU9laTNaUEEz?= =?utf-8?B?R2pqeGxpT3dQSnZMV0dkNm5SenJsWlllUVI0L05DSGFWUlpOMVRjMStTNnNF?= =?utf-8?B?UDUzL3U0YkQ4bkN0SGdwSkFhOUc1ZExDWTl3RWpDdmlrekFOR3pDMVlnWk5o?= =?utf-8?B?NS92Q0FQK1JyWllyUVRRU2twM1FCR25hUG9zNzlBQktKbVBIQyswZUlZUTN0?= =?utf-8?B?Zjk5b0ZOQk52cC9qUDZtYVpDR1JsK3JsVmJsQ09ZSk1RK0tRMXg1dE1XL1lw?= =?utf-8?B?R3RYYWI3NVIvL0ZsMCtsQ3ZvdWJzblhkbldXWCtCbFNCaWhSZkxSR2czL1NY?= =?utf-8?B?QjBScDR5cEI5K3Q5UmtQWnBXL3V0VlFFelg3dHBKSzBGdHdUTHRhaGVJVDF2?= =?utf-8?B?VzRNdnFIWlFwZmdadXpWNlJ0VnFLMVVKOU5ndkJFR0N0cVFMTnhqQngraGU1?= =?utf-8?B?elR4Q3E5OGhSeXpZS21wc1JmbzYxOWllVElESDZwU0VPQ094MG5mZzd5QnFx?= =?utf-8?B?aGUxZlZCbzVIbmJFMHN6UnQ2UlhhUnBrYXd4UW1LTFBmK1krNzh3RWJtazJK?= =?utf-8?B?dUtRK3BVdUNWdm1JL1hMaHBrcVdwUDM5TVF6RExGK0dBWGlhb21CNFBISlZ5?= =?utf-8?B?cTRGS0pUNU9sMTFZQ0xrUC9zV0lMUkZzazJSZ2U0dXdka3lmMkhZdE1lZEJH?= =?utf-8?B?UXRNVlhwRFRCZXkrZWZXcGJGZnZHNUpkUlVkWElYWDY4d0lIWGhHMDdQUUEx?= =?utf-8?B?aEp3TmdadXBXTHJkOURWOFZTUTBxQVJTa2VNdFJhSy85YmFNb0tRUlRxRHE3?= =?utf-8?B?Z3NldlE1NXNFbG9QMEpKdEZJanUwYXF1SXNBKzYranlsUXpYckF2U3hmR21L?= =?utf-8?B?ZmJRQlVPQmN3SUM1MjZFQUt5alpmcFhzdy8rc2Fzbkk3cVhxVUtYM1hra3pY?= =?utf-8?B?cXZWd0xFSlpyQXl0WExIY1g3NTJKeGhabXlJZG5JcmJqRUczUTY0a29Oc0kz?= =?utf-8?B?L090TlN4akt6bytFK1psd3cvSnE1MlR2anFGbFByUHVUR0t6UUJoZThObzk4?= =?utf-8?B?TTJtS1ZtN2lPb0FZUHdqT0kxSjVHUEMzZVN1WHFtQVBHUjRoMGR4eTFmNUxj?= =?utf-8?B?WjVvN3dOTml2enV3VnFiSmRUL2NYQnp5Y24xNjA3Zkt3TkRudWgveGRUL2pn?= =?utf-8?B?bG1CYSs1a2IrNmhkRy96eVRTcWRFS1VkY0tNYlFUZ2lRWEZzU1hmSnFDQU5r?= =?utf-8?B?ZW5SQzBQMk9GV0ZVbE15NFcvTXhlSjlsS2Q1RUhYV09HRzhBeXgrUnVnQjBz?= =?utf-8?B?Z1hGSCtTZDNsVHorckt4T2ZJQ2tURkhHUHZxRVE5NWFsK1JuQ2x1aURuQzd5?= =?utf-8?Q?MP4uK//V7kSR6IXJ+HtaYtWfYCT99DcwTrO0u2L?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB1332;6:AYVFYYlMwha4PBIdVcPBfH+ey9uWA+0vGhjNZpduHpoJibPiiWAxWXKcq4MhpB2XhaTzVdYtOOjJPZAlnC2fi/94zvd9r4yfebdsAhJ4aO4WaI/bd3g/XoiZJtlkhWa5zeH7nz4gPAFqrTuaOCPO9L4Fb3zuG2rjePBF4QqKyUzcBXoN5nXJUycoml7OGckUH/4ioTF25P+yFKdA6x2W2pac3N4LjkilBPWkGMX7HU4ZYvrkOXWs1FonN56POEPNxtKHY2K5HxeQSBR9RVbM6m0aCq1cdrDbriFbrK2LZUA6yZ7yrSwOGQoBvyXSAhrHSOOivhLNSscTyMyuMzgGWZ7xXCAsGOUW69TZo2JFYvk=;5:vSkTbjGMdMUtrg12mfIcv4OCwU3/md9/GlAGZ9Uotkvz+yV7vKbNpjujhI+ZOraZBC4vKDxZLDhQ1hH7z1t7SWPS3s8ImtJa5GcRPYMIR2ly7WmDP7VMkyLxNhIjwNnlb1HM5p9YJHNz9lhIVhSDSvzy3YAJnh5hZrnlMEaxvx0=;24:fqua6nMftoL11y8YoMcA5w+Rg66OiZs+DcHRBOjpCsk+zydkehtgehapoHPyDBXB8MaVaRpOwk1RLkH01bYAXkEQPovrIpMLE2BB/VSPuYk=;7:NOfl6p5PYgVciAdtxH6T9cx3XWOrmF2SnJvCYNZgwo7uP4hMFJ0VS9JDDS0EqMCQzld1Q8S0w+waD/VPriHbK7ooYiOMxuu53Fj8/YQb17qBFXqLlA0AFRODaIBrp2Al/Q4iHN+wV7peFvEVE4Bd+m1GXBK80fnJTU5RHnJyx5qfM01p1Dd5YHZul+BeJZpnRkv7rEWBmbICmTdtParCU2FalAoDPLsltl8fvF1DO8WeY4atSYY+yXJPk6UBl/Lm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 11:37:27.8708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d45a2a7-6f68-49ad-96eb-08d55e67da59 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB1332 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.1.2018 11:28, Dan Carpenter wrote: > We accidentally used a logical AND instead of a bitwise AND here. > > Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c > index c1d6f1b190b6..a840c0272135 100644 > --- a/drivers/soc/xilinx/xlnx_vcu.c > +++ b/drivers/soc/xilinx/xlnx_vcu.c > @@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu) > */ > vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL); > clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT; > - clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK; > + clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK; > if (clkoutdiv != 1) { > dev_err(xvcu->dev, "clkoutdiv value is invalid\n"); > return -EINVAL; > Already fixed by https://www.spinics.net/lists/arm-kernel/msg628989.html Thanks, Michal