mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhuyinbo <zhuyinbo@loongson.cn>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
	wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
	loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn
Subject: Re: [PATCH v7 2/2] spi: loongson: add bus driver for the loongson spi controller
Date: Sat, 15 Apr 2023 09:42:42 +0800	[thread overview]
Message-ID: <7bea4fc0-9c9b-d4fa-b996-4271a1cb8ad7@loongson.cn> (raw)
In-Reply-To: <f0989d13-4520-461f-8715-3595e11f988e@sirena.org.uk>



在 2023/4/15 上午2:32, Mark Brown 写道:
> On Wed, Apr 12, 2023 at 12:51:52PM +0800, Yinbo Zhu wrote:
> 
>> +static int __maybe_unused loongson_spi_suspend(struct device *dev)
>> +{
>> +	struct loongson_spi *loongson_spi;
>> +	struct spi_master *master;
>> +
>> +	master = dev_get_drvdata(dev);
>> +	loongson_spi = spi_master_get_devdata(master);
>> +
>> +	loongson_spi->spcr = loongson_spi_read_reg(loongson_spi, LOONGSON_SPI_SPCR_REG);
> 
> This is missing a call to spi_controller_suspend(), and similarly resume
> is missing a call to spi_controller_resume().  Otherwise this looks
> good.
okay, I will add it.

Thanks.
> 


  reply	other threads:[~2023-04-15  1:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  4:51 [PATCH v7 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-04-12  4:51 ` [PATCH v7 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-04-13 17:02   ` Krzysztof Kozlowski
2023-04-14 10:57   ` kernel test robot
2023-04-15  1:25     ` zhuyinbo
2023-04-14 11:13   ` Krzysztof Kozlowski
2023-04-15  1:23     ` zhuyinbo
2023-04-12  4:51 ` [PATCH v7 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-04-14 18:32   ` Mark Brown
2023-04-15  1:42     ` zhuyinbo [this message]
2023-04-14 20:43 ` [PATCH v7 0/2] spi: loongson: add bus driver for the loongson spi Krzysztof Kozlowski
2023-04-18  2:53   ` zhuyinbo
2023-04-18  7:06     ` Krzysztof Kozlowski
2023-04-18 11:21       ` zhuyinbo
2023-04-19  1:53       ` zhuyinbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bea4fc0-9c9b-d4fa-b996-4271a1cb8ad7@loongson.cn \
    --to=zhuyinbo@loongson.cn \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=liupeibao@loongson.cn \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=lvjianmin@loongson.cn \
    --cc=robh+dt@kernel.org \
    --cc=wanghongliang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®