mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Koichiro Den <koichiro.den@canonical.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] gpio: aggregator: Fix Smatch warnings
Date: Sat, 12 Apr 2025 19:43:19 +0300	[thread overview]
Message-ID: <7bed7798-1671-4926-8d97-2e9ce34a683d@stanley.mountain> (raw)
In-Reply-To: <52ap2hc6ii7hlk2zixxf455nens3rxtwvrrwhlv4ii5avpgmcq@lbrdov3ygay3>

On Sat, Apr 12, 2025 at 11:45:08PM +0900, Koichiro Den wrote:
> On Sat, Apr 12, 2025 at 01:14:53PM GMT, Dan Carpenter wrote:
> > Fix some static checker warnings from Smatch:
> > https://github.com/error27/smatch
> > 
> > Dan Carpenter (5):
> >   gpio: aggregator: fix "_sysfs" prefix check in
> >     gpio_aggregator_make_group()
> >   gpio: aggregator: Fix gpio_aggregator_line_alloc() checking
> >   gpio: aggregator: Return an error if there are no GPIOs in
> >     gpio_aggregator_parse()
> >   gpio: aggregator: Fix error code in gpio_aggregator_activate()
> >   gpio: aggregator: Fix leak in gpio_aggregator_parse()
> > 
> >  drivers/gpio/gpio-aggregator.c | 21 ++++++++++++---------
> >  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> Thank you very much for spotting these issues. I doubt myself for having
> overlooked these.

Heh.  Don't beat yourself up.  Humans can never compete with a computer
at being nit-picky.

regards,
dan carpenter


  reply	other threads:[~2025-04-12 16:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-12 10:14 Dan Carpenter
2025-04-12 10:15 ` [PATCH 1/5] gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group() Dan Carpenter
2025-04-14  7:52   ` Geert Uytterhoeven
2026-01-21 14:04   ` Andy Shevchenko
2025-04-12 10:15 ` [PATCH 2/5] gpio: aggregator: Fix gpio_aggregator_line_alloc() checking Dan Carpenter
2025-04-12 10:15 ` [PATCH 3/5] gpio: aggregator: Return an error if there are no GPIOs in gpio_aggregator_parse() Dan Carpenter
2025-04-12 10:15 ` [PATCH 4/5] gpio: aggregator: Fix error code in gpio_aggregator_activate() Dan Carpenter
2025-04-12 10:15 ` [PATCH 5/5] gpio: aggregator: Fix leak in gpio_aggregator_parse() Dan Carpenter
2025-04-12 14:45 ` [PATCH 0/5] gpio: aggregator: Fix Smatch warnings Koichiro Den
2025-04-12 16:43   ` Dan Carpenter [this message]
2025-04-14 20:26 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bed7798-1671-4926-8d97-2e9ce34a683d@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=geert+renesas@glider.be \
    --cc=koichiro.den@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®