From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235BFC4363D for ; Fri, 2 Oct 2020 06:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DED15206DD for ; Fri, 2 Oct 2020 06:27:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbgJBG1N (ORCPT ); Fri, 2 Oct 2020 02:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgJBG1N (ORCPT ); Fri, 2 Oct 2020 02:27:13 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC5A7C0613D0; Thu, 1 Oct 2020 23:27:12 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kOEWp-00F5MO-KU; Fri, 02 Oct 2020 08:26:51 +0200 Message-ID: <7bf217ced62816b1bd3404bcfe279082347fb265.camel@sipsolutions.net> Subject: Re: WARNING in cfg80211_connect From: Johannes Berg To: syzbot , a@unstable.cc, b.a.t.m.a.n@lists.open-mesh.org, davem@davemloft.net, david@fromorbit.com, dchinner@redhat.com, hch@lst.de, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, mareklindner@neomailbox.ch, netdev@vger.kernel.org, sw@simonwunderlich.de, syzkaller-bugs@googlegroups.com Date: Fri, 02 Oct 2020 08:26:50 +0200 In-Reply-To: <0000000000000a954d05b0a89a86@google.com> (sfid-20201002_063111_703712_8FE82506) References: <0000000000000a954d05b0a89a86@google.com> (sfid-20201002_063111_703712_8FE82506) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-10-01 at 21:31 -0700, syzbot wrote: > syzbot has bisected this issue to: > > commit 16d4d43595b4780daac8fcea6d042689124cb094 > Author: Christoph Hellwig > Date: Wed Jul 20 01:38:55 2016 +0000 > > xfs: split direct I/O and DAX path > LOL! Unlike in many other cases, here I don't even see why it went down that path. You'd think that Christoph's commit should have no effect whatsoever, but here we are with syzbot claiming a difference? I mean, often enough it says something is "caused" by a patch because that caused e.g. generic netlink family renumbering, or because it emitted some other ioctl() calls or whatnot that are invalid before and valid after some other (feature) patch (or vice versa sometimes), but you'd think that this patch would have _zero_ userspace observable effect? Which I guess means that the reproduction of this bug is random, perhaps timing related. johannes