From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B131FC05027 for ; Thu, 26 Jan 2023 10:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236270AbjAZK2Q (ORCPT ); Thu, 26 Jan 2023 05:28:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235934AbjAZK2N (ORCPT ); Thu, 26 Jan 2023 05:28:13 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CA7F126D5; Thu, 26 Jan 2023 02:28:11 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BC4785C049B; Thu, 26 Jan 2023 05:28:10 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 26 Jan 2023 05:28:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674728890; x=1674815290; bh=zSxeHsJFyS /kUWqCkulRCicQEyvTrnSPfQJ9Vnyj+Es=; b=SArs0rsYB9RWF5dkIyHLpNFlkb A6B/vxNkxxGSIZTFLSjBZ3SypIMUaOVzeI85EINFh3ByivPJRYOe+ioypqeDiGw+ vFWmXKYWXWI+mExnoK9nUfsr0pmc71Q+SjDhVCL6+BUrjo48HzO7OsIcl27WjBWR cSPqgKiTJ3ykqilErfLUd/PNnjcXADql5OGXKHQDG2W6iAbrwpw1db14fRlta/tz JOiWzh5ubJP/Qik+o9hnwaVSlZmrYfo74uFpw8h/qeX1lY8eEkphGwGo4hKQLBjv pLASKGczh9wu1aj0x3KMlca2kgG/A58C9oc5Y5ZAFiF1Klbs6jVwG57OkgMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674728890; x=1674815290; bh=zSxeHsJFyS/kUWqCkulRCicQEyvT rnSPfQJ9Vnyj+Es=; b=Sso2PvjhwJF4F5wOQFN0RKyOKVFKUUn3jkb/sRa4lbU/ G3LTnT4u7N9evUUEJAhKLDn2CQcZ+27pLH0Uh2vva0EeAZ+jfRrZwIROdbrOK4rz ZdXpKENxRWHgwPdWQML8LfaaJaTxPTPP9WKtxF2myiVe6tVVem6CaunAxqqdag67 MUHtcpQ5/00MGTlqvGpox/4HF2qQD7kpQcBLwXtjHAzpUdkahaEgnVl5DNJBfxxS wWdaj8vw7qqHUZKre0WwqJprca4l3f/JXVemKQRWGYgY6udNEChRRQQtAX9mA2dQ P5yeCaQn43WdnrYXNj5MLjpmUcfZsrJlDbjCuZleeA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvgedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4B436B60086; Thu, 26 Jan 2023 05:28:10 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0 Mime-Version: 1.0 Message-Id: <7bf72f8f-1936-4b1e-b970-2fe09b6641ca@app.fastmail.com> In-Reply-To: References: <20230125201020.10948-1-andriy.shevchenko@linux.intel.com> <20230125201020.10948-2-andriy.shevchenko@linux.intel.com> <05d32a58-c119-4abb-8e62-9d79bd95324f@app.fastmail.com> Date: Thu, 26 Jan 2023 11:27:51 +0100 From: "Arnd Bergmann" To: "Andy Shevchenko" Cc: "Christophe Leroy" , "Bartosz Golaszewski" , "Dmitry Torokhov" , "open list:GPIO SUBSYSTEM" , Linux-Arch , "linux-kernel@vger.kernel.org" , "Linus Walleij" , "Bartosz Golaszewski" , "Pierluigi Passaro" , "kernel test robot" Subject: Re: [PATCH v1 1/5] gpiolib: fix linker errors when GPIOLIB is disabled Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2023, at 11:17, Andy Shevchenko wrote: > On Thu, Jan 26, 2023 at 09:40:18AM +0100, Arnd Bergmann wrote: >> On Thu, Jan 26, 2023, at 09:14, Christophe Leroy wrote: >> >> All of these should already prevent the link failure through >> a Kconfig 'depends on GPIOLIB' for the driver, or 'select GPIOLIB' >> for the platform code. I checked all of the above and they seem fine. >> If anything else calls the function, I'd add the same dependency >> there. > > So, you think it's worth to send a few separate fixes as adding that > dependency? But doesn't it feel like a papering over the issue with > that APIs used in some of the drivers in the first place? If there are drivers that use the interfaces but shouldn't then fixing those drivers is clearly better than adding a dependency, but we can decide that when someone sends a patch. Adding a stub helper that can never be used legitimately but turns a build time error into a run time warning seems counterproductive to me, as the CI systems are no longer able to report these automatically. Arnd