From: Harald Mommer <harald.mommer@opensynergy.com>
To: Haixu Cui <quic_haixcui@quicinc.com>
Cc: quic_ztu@quicinc.com, Matti Moell <Matti.Moell@opensynergy.com>,
Mikhail Golubev <Mikhail.Golubev@opensynergy.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [virtio-dev] Re: [RFC PATCH v3 3/3] SPI: Add virtio SPI driver.
Date: Tue, 5 Mar 2024 11:57:43 +0100 [thread overview]
Message-ID: <7bfbf09f-67d1-43d0-8ecd-aedf3b9e2287@opensynergy.com> (raw)
In-Reply-To: <c7c939c9-50e0-4d86-bd44-d8b4b90ca14d@quicinc.com>
Hello,
I took next/stable as base giving the exact tag/sha of the current
next/stable so that it's known what was used as base version even when
next/stable moves. The ordinary next tags are currently not of best
quality, gets better, therefore next/stable now. We were on v6.8-rc7
yesterday with next/stable.
VMM is qemu for the driver you have. But it's a specially modified qemu
which allows that we use our proprietary virtio SPI device as backend.
Proprietary virtio SPI device is started first, this is an own user
process in our architecture. Subsequently the special internal qemu
version is started. The virtio SPI driver is compiled as a module and
inserted manually by a startup script by "modprobe spi-virtio". The
driver goes live immediately.
In this simple setup I do not have udev rules (no service supporting
udev => no rules) so no /dev/spidevX.Y automatically after the driver
went live. What I'm using to test the latest driver before sending it to
the mailing lists is really a naked kernel + a busybox running in a
ramdisk. The udev rule I've sent are used on some more complete setup on
real hardware.
So without udev I have to bring this device up manually:
In /etc/spidev-up.sh there is a script tp bring up /dev/spidev0.0 manually:
#!/bin/sh
SPIDEV=spi0.0
echo spidev > /sys/bus/spi/devices/$SPIDEV/driver_override
echo $SPIDEV > /sys/bus/spi/drivers/spidev/bind
Afterwards there is /dev/spidev0.0.
In linux/tools/spi there are spidev_test.c and spidev_fdx.c. Those
(somewhat hacked locally, and I mean "hacked" to be able to test
somewhat more) are used to play around with /dev/spidev0.0.
I can do this on my Laptop which has no underlying SPI hardware which
could be used as a backend for the virtio SPI device. The proprietary
virtio SPI device has a test mode to support this. Using this test mode
the driver does not communicate with a real backend SPI device but does
an internal simulation. For example, if I do a half duplex read it
always gives back the sequence 01 02 03 ...
For full duplex it gives back what has been read but with letter case
changed, in loopback mode it gives back exactly what was sent. With this
test mode I could develop a driver and parts of the device (device -
real backend communication to an actual SPI device) on a board which had
no user space /dev/spiX.Y available which could have served as backend
for the virtio SPI device on the host.
Slightly different module version is tested on real hardware with the
virtio SPI device not in test mode. "Tested on hardware" means that
device + module work for our special use case (some hardware device
using 8 bit word size) and the project team for which device and driver
have been made did until now not complain.
Regards
Harald Mommer
On 05.03.24 08:46, Haixu Cui wrote:
> Hello Harald,
>
> Thank you for your detailed expatiation. To my knowledge, you took
> Vanilla as the front-end, and VMM is QEMU. Can you please explain
> further how do you test the SPI transfer without the Vanilla userspace
> interface? Thanks again.
>
> Haixu Cui
next prev parent reply other threads:[~2024-03-05 10:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 13:53 [RFC PATCH v3 0/3] Virtio SPI Linux driver compliant to draft spec V10 Harald Mommer
2024-02-13 13:53 ` [RFC PATCH v3 1/3] virtio: Add ID for virtio SPI Harald Mommer
2024-02-13 13:53 ` [RFC PATCH v3 2/3] virtio-spi: Add virtio-spi.h Harald Mommer
2024-02-13 13:53 ` [RFC PATCH v3 3/3] SPI: Add virtio SPI driver Harald Mommer
2024-02-13 17:49 ` Mark Brown
2024-02-27 14:12 ` Harald Mommer
2024-02-27 14:25 ` Mark Brown
2024-02-20 8:30 ` Haixu Cui
2024-02-26 10:41 ` Harald Mommer
2024-03-04 7:11 ` Haixu Cui
2024-03-04 10:52 ` [virtio-dev] " Harald Mommer
2024-03-05 7:46 ` Haixu Cui
2024-03-05 10:57 ` Harald Mommer [this message]
2024-03-05 17:54 ` [virtio-dev] Re: [RFC PATCH v3 3/3] SPI: Add virtio SPI driver. - Correction Harald Mommer
2024-03-06 7:48 ` Haixu Cui
2024-03-06 16:18 ` Harald Mommer
2024-03-11 9:28 ` Haixu Cui
2024-03-13 7:05 ` Haixu Cui
2024-02-14 16:22 ` [virtio-dev] [RFC PATCH v3 0/3] Virtio SPI Linux driver compliant to draft spec V10 Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bfbf09f-67d1-43d0-8ecd-aedf3b9e2287@opensynergy.com \
--to=harald.mommer@opensynergy.com \
--cc=Matti.Moell@opensynergy.com \
--cc=Mikhail.Golubev@opensynergy.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_haixcui@quicinc.com \
--cc=quic_ztu@quicinc.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®