From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB3083E8C7C for ; Fri, 22 May 2026 11:33:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779449594; cv=none; b=LHF9GFslbsCRr60g0r7fNifVgsK1vASJM1xyeGOzA6meLA91Kw3X/y0hOtZ7authWbl747rVzbrMqLL8HFPplZsvLEEjiOXN0eyVPYGyWjxJ9prchsFW79fDFmwbGVU8zvLCembLMv6S7tuNPZT6opN0AbN07GVye9y5Y7ffT9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779449594; c=relaxed/simple; bh=k76CFvOUtYTWX2742eULvV2pXmKvLaBCzSxRd/5zrtg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=urWAM+epLPKwxhJnyAem52siepaMqNZgaa7VuwhmATiva1rYz+ftT41EwFT95t0ANUM2NLQN7aoTHZIcaSrPwzjFlVdbpwjiizm6pCjyLUTjbUlvdct/jrDmRK4vu/zs1gLdzXt7OvFeuYEu9EH/wMoSLKimNqPi66HOB9Whjx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ELr8j3nF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C/1u/Som; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ELr8j3nF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C/1u/Som" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M901qb3005132 for ; Fri, 22 May 2026 11:33:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gW8frZZ8Fde1HC+RzR+WMWPFCf5xWqdVBkT+AH22Cr0=; b=ELr8j3nFK7SWU342 WKeO/0WJnKRJ+BrSmgT1N/7BFttmEH4vUwJVkS0Pfj23OC8ixVonLXJIAudwVoZt 1bcsdFv5xhEVFhBk2EEKVwZ0y8tXwhsaFqrmc0YutDA469E3Dk+j1ybhppUGU4OJ veYKLKaTBEGIQpeNZxrAyeiZeY1pBLxqeQCjPmUDXRWCZR/WA+cSKWK0/jpBrY7W BvkwUtCy+l/trEPGBor/yFjX1sBWR7eyTKd/OrCER07Lsp97vVCE+ok7KLhs1jvl hlJR3JTMQTjyH32k8JqRleFLI8qoolSnD88mJ5dHMfCvtiMDiunCyQsz18MOhAqb MsLlzQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eafrt9re1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 11:33:12 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8b49bb5a914so19114926d6.0 for ; Fri, 22 May 2026 04:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779449591; x=1780054391; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gW8frZZ8Fde1HC+RzR+WMWPFCf5xWqdVBkT+AH22Cr0=; b=C/1u/Somhuz9XczxRkHvt4hHShGWENhZ5VJuo1EfoY80fCwwq/jYeHwVuvYdyWIvFw TELWNwmwCSXT2ZPt1/qgx6ogkt0PKsi1+X6zhorPeuKG/5rFAWj7R5HrIApHYf0n1K4t IxIp5z6BSSKaCFDoasOg6/RvswbHXpmx3dDiss4yWXHbbeufbwgozvViEKCbz/w+yOKG 8iSfkRmiOZPVuW0+En2ipq0EQtFEJ79b5IQdF7uD/4wFh3T4CPNV4koTVlL4bUeXDvR0 ZrTTPFTomvdC5qOublTNg5MimO3/DdkezT8rZ7Vo/gNHRMqc9PYNv939Nam0PsSESpu/ 4V5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779449591; x=1780054391; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gW8frZZ8Fde1HC+RzR+WMWPFCf5xWqdVBkT+AH22Cr0=; b=cRrQNlSE46/e7CzwFPCEFq4DWvEx9j6EWmOzvOg7guPo5RECpdyYT/NWeRPZszZ2p1 E3w+G5ulXok78kKHmLNitu8Ov3H4qtbDZztBCjLoBlv2bmVcfFglxAo+o7isjq9kYV/E A/Lms8vh+MV0fcFOav4AwjUcPvG6XnxPxd/ZvC1rQ5GoxG62ah09vCXWMLPE62DlMT9N 5gTl2JEDV3NmLSMq0fhvvUGJ5H9xPjvj4gjFgJ5U+4wO86vIUtG6ie61wBFD/KztpXhe sNESW7BojMnH8wcQ4hq9nhJGiyc+DRfdyjwVnhHOFPylF/mGE88qX398UTE3XIAkWbWW kQcw== X-Forwarded-Encrypted: i=1; AFNElJ+K/coEadJRm+yuGYVBaDPE+jaj6scx7nP3/yl75nFVp02mvJ78fwStkSBFCSpgfPGhZv8CnlDTCU2JaWE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzdu8E5njR0AEQluY8jjOCFj37Wv1peBrJCT4yPZ5jrMo7yVoe+ 2togHxqK280XuILWyqxh0N7ICuMTIuO44SbfXpQMreQIoEvgYjP7ESZUmKNjNoPkbFkmM/JRAKD EBpqOoQ1hAqKmQqcqENC5Dsd+jurHzd0WxOsHuSJhbqO4NGT7O67LgSKltYBhboowd/k= X-Gm-Gg: Acq92OFUseJzDxq5EQXnwU/rfo/JsDasipM9/W4g+iZP3BT86K3MxIZvSqoYDdw1Ylc IDYHqHSnIGJ0nWcpsElDawJM/JI3g/XZ+YeIFx4PukbZHKBuxAUNkdLjbYjROclVCRBWK9Z8CQo cNa/2nu7vz0StKU1AkNW17A2gDMPRY9ll7riFf116nDW4oBQjAf5Y5VY+C2Ur6kL+z4Xy/shFL9 ZqDYMoIGoBp/ht/E0HulDwKzpWLAPPD0EI9FfamrQibWkDfe97cc60/sSIc+K4W9CrWCE7w0JdT RSFcgCuMoCVcEawJZDD5yi8wkaHYPUnys06A5Oqv/0ehGxMYXTBB7+xvKJ2S9H2Hg420pU3154T s/ljdulJN52mPwPYzzs4jR7yx7Z7LaqPqklVYWCiGSmoyIw== X-Received: by 2002:ac8:5916:0:b0:516:cae0:c6e9 with SMTP id d75a77b69052e-516d419f0e0mr36225861cf.0.1779449591119; Fri, 22 May 2026 04:33:11 -0700 (PDT) X-Received: by 2002:ac8:5916:0:b0:516:cae0:c6e9 with SMTP id d75a77b69052e-516d419f0e0mr36225491cf.0.1779449590594; Fri, 22 May 2026 04:33:10 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc62d5d0csm45618666b.43.2026.05.22.04.33.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 04:33:09 -0700 (PDT) Message-ID: <7bfcdf7c-f114-4f4f-9ca7-6a0d31c856d5@oss.qualcomm.com> Date: Fri, 22 May 2026 13:33:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 04/10] drm/msm/dp: Move link training to atomic_enable() To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> <20260314-hpd-refactor-v5-4-0c8450737d64@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260314-hpd-refactor-v5-4-0c8450737d64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JN0LdcKb c=1 sm=1 tr=0 ts=6a103ef8 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=DFjhG9jlQqNoXxgc5tgA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDExNSBTYWx0ZWRfX17jda7+Jmt4P /n8rMyCVodXc4PIKQORq7XFKVpesGfWzsLWn2pzyl5EJVUq0yhzV+dyZCZJ8fIN0AFCpPPuUBhF q5K7q9jq34iQUfqlBsZR8ix9gy7qRPXgzaPmbzsDWQajXcVrraygqXrhfL1/JgDGIgKEmMgq4bL OaN0HsPRtIz5g4FzRabxnqUwk4vanWBDGZ/V/DmpGT1F77HZrzM9oQn4aCmtv0oktbGmdkgYBAK KKyT+wIKgpO7iwyZ7y3974QH9/yFsFb5lWqWliFRrWZjzADlcrc/3kSCIBI3luZfHJ2ZUcqIOy8 vjV18x3fZwKl4NRrY1EaiZNXHFYeZ6gLnn1qu/9Bjjj//qt0iUrewjGM9JT0L6gjSTHHXN1HVhM CscDV9jCHaWJ5K0afmItXVDrzJ03N8L3CNhmVUexr89jC9YHN+3WcC1lJOgJ6m+sHXhOztlR7Eu 9WQNZNUuip0aeJyaK6w== X-Proofpoint-GUID: LQD2Qorr2S1QvJKcKUQC2Zii3lEYiiTy X-Proofpoint-ORIG-GUID: LQD2Qorr2S1QvJKcKUQC2Zii3lEYiiTy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220115 On 3/14/26 2:09 AM, Dmitry Baryshkov wrote: > From: Jessica Zhang > > Currently, the DP link training is being done during HPD. Move > link training to atomic_enable() in accordance with the atomic_enable() > documentation. > > Link disabling is already done in atomic_post_disable() (as part of the > dp_ctrl_off_link_stream() helper). > > Finally, call the plug/unplug handlers directly in hpd_notify() instead > of queueing them in the event thread so that they aren't preempted by > other events. > > Signed-off-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index a05144de3b93..e7b1ed5491c4 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -436,11 +436,6 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) > msm_dp_link_psm_config(dp->link, &dp->panel->link_info, false); > > msm_dp_link_reset_phy_params_vx_px(dp->link); > - rc = msm_dp_ctrl_on_link(dp->ctrl); > - if (rc) { > - DRM_ERROR("failed to complete DP link training\n"); > - goto end; > - } > > msm_dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); > > @@ -1695,6 +1690,11 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *drm_bridge, > force_link_train = true; > } > > + rc = msm_dp_ctrl_on_link(msm_dp_display->ctrl); > + if (rc) > + DRM_ERROR("Failed link training (rc=%d)\n", rc); So this will still crash the device if the above fails - there's some return statements in this function, should we bail out if that happens? Konrad